Bug #11401

robust_notification_wait sometimes opens the Applications menu which breaks tests

Added by intrigeri 2016-05-05 09:44:27 . Updated 2016-06-08 01:26:53 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Test suite
Target version:
Start date:
2016-05-05
Due date:
% Done:

100%

Feature Branch:
test/11401-notification-wait-is-fragile
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Unsafe Browser
Deliverable for:
270

Description


Files


Subtasks


Related issues

Related to Tails - Bug #13469: Starting applications "via GNOME Activities Overview" step is fragile Resolved 2017-07-14
Blocks Tails - Bug #10497: wait_until_tor_is_working helper is fragile Resolved 2015-11-06

History

#1 Updated by intrigeri 2016-05-05 09:44:41

#2 Updated by intrigeri 2016-05-05 09:46:14

Perhaps desktop notification handling would be a good candidate for dogtail’ification? The way it looks visually changes a lot in Stretch, our handling of it has historically been quite brittle, and now even our “robust” helper breaks stuff.

#3 Updated by intrigeri 2016-05-20 19:07:05

One more case, attaching video. I’ll mark this test as fragile, and IMO we should go on doing this until we can check if this breaks too many tests and needs to be prioritized higher.

#4 Updated by intrigeri 2016-05-21 21:08:57

  • Priority changed from Normal to Elevated

FTR, all recent test failures I’ve seen while running tests on 4 branches intensively were caused either by this problem, or by Bug #11398 => bumping priority.

And now I wonder: did we ever see this before we merged the dogtail branch? I can’t remember this, and this ticket is pretty new, and I see this problem very often these days. So I wonder if robust_notification_wait is really guilty, or if we’re experiencing some dogtail-induced bug.

#5 Updated by intrigeri 2016-05-22 09:28:22

  • Status changed from Confirmed to In Progress
  • Feature Branch set to test/11401-notification-wait-is-fragile

In def robust_notification_wait I see:

  # Click anywhere to close the notification applet
  @screen.hide_cursor
  @screen.click("GnomeApplicationsMenu.png")
  @screen.hide_cursor

… which probably explains very clearly what we’re seeing. JFTR this code was introduced in commit:bd2d2bdf. I’m pushing a different implementation, will merge it into test/10497-tor-bootstrap-is-fragile so that we can see how it goes in Jenkins.

#6 Updated by intrigeri 2016-05-22 09:29:38

  • blocks Bug #10497: wait_until_tor_is_working helper is fragile added

#7 Updated by intrigeri 2016-05-22 09:32:49

  • Assignee set to intrigeri
  • Target version set to Tails_2.4
  • % Done changed from 0 to 10

Will try to do that during this cycle, since it blocks Bug #10497 (and in turn, those that Bug #10497 itself blocks).

#8 Updated by intrigeri 2016-05-22 10:39:07

  • Deliverable for set to 270

#10 Updated by intrigeri 2016-05-22 14:48:23

  • Subject changed from robust_notification_wait sometimes fails to close a notification which breaks tests to robust_notification_wait sometimes opens the Applications menu which breaks tests
  • Description updated

(Repurposing this ticket to track the specific problem I’m trying to fix here, instead of two unrelated things at a time. The issue it was previously about, that’s specifically about browser close notifications, is now tracked by Bug #11457.)

#11 Updated by intrigeri 2016-05-22 14:50:56

  • File deleted (03_55_28_Closing_the_Unsafe_Browser_shows_a_stop_notification_and_properly_tears_down_the_chroot..mkv)

#12 Updated by intrigeri 2016-05-25 09:01:41

  • Assignee changed from intrigeri to anonym
  • % Done changed from 10 to 50
  • QA Check set to Ready for QA

I’ve not seen this bug happen anymore on Jenkins with this fix in, while it happened pretty regularly before. FTR this branch has been merged into the one for Bug #10497, and in turn into the ones for Bug #10442, Bug #10376 and Bug #10381, so it has seen a fair amount of testing. Then I think we’re good and should merge this :)

#13 Updated by anonym 2016-06-01 19:56:04

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

#14 Updated by anonym 2016-06-08 01:26:53

  • Status changed from Fix committed to Resolved

#15 Updated by intrigeri 2017-07-17 15:13:24

  • related to Bug #13469: Starting applications "via GNOME Activities Overview" step is fragile added