Tails

#1 Updated by kytv 2015-10-15 07:05:00

• blocks Bug #10288: Fix newly identified issues to make our test suite more robust and faster added

#2 Updated by intrigeri 2015-10-16 03:15:41

• blocked by deleted (Bug #10288: Fix newly identified issues to make our test suite more robust and faster)

#3 Updated by intrigeri 2015-10-16 03:15:50

• Parent task set to Bug #10288

#4 Updated by intrigeri 2015-10-16 03:16:03

• Assignee set to anonym

#5 Updated by intrigeri 2015-10-16 03:16:21

• blocks #8668 added

#6 Updated by anonym 2015-10-16 05:51:30

• Assignee changed from anonym to kytv
• Target version changed from Tails_1.7 to Tails_1.8

#7 Updated by kytv 2015-10-16 07:28:44

• Feature Branch set to kytv:test/5d797fe-fix-I-open-the-address-test-is-fragile

#8 Updated by kytv 2015-10-16 07:36:36

• Feature Branch changed from kytv:test/5d797fe-fix-I-open-the-address-test-is-fragile to kytv:test/10381-fix-I-open-the-address-test-is-fragile

#9 Updated by anonym 2015-10-16 09:39:23

• Feature Branch changed from kytv:test/10381-fix-I-open-the-address-test-is-fragile to test/10381-fix-I-open-the-address-test-is-fragile

Branch imported to our Git, scenarios marked as @fragile in devel.

#10 Updated by intrigeri 2015-11-06 06:06:21

• Deliverable for set to 270

#11 Updated by intrigeri 2015-11-06 06:06:42

• related to Feature #10379: Check that we do not see any error pages in the "I open the address" step. added

#12 Updated by anonym 2015-11-06 06:12:11

• Assignee changed from kytv to bertagaz

There might be something smart to do that will fix all of {Bug #10442, Bug #10381, Bug #10376} at the same time, and increase browser page loading throughout the test suite.

#13 Updated by anonym 2015-11-06 11:44:08

• Assignee changed from bertagaz to anonym

#14 Updated by intrigeri 2015-12-05 13:21:12

• Target version changed from Tails_1.8 to Tails_2.0

(We’re going to mark as fragile all tests that depend on Tor to have bootstrapped for the moment => not so urgent.)

#15 Updated by anonym 2016-01-06 14:05:32

• Target version changed from Tails_2.0 to Tails_2.2

#16 Updated by anonym 2016-02-20 13:21:28

• Priority changed from Normal to Elevated
• Target version changed from Tails_2.2 to Tails_2.4

#17 Updated by anonym 2016-02-20 14:56:33

• Priority changed from Elevated to Normal
• Target version deleted (Tails_2.4)
• Deliverable for deleted (270)

I’m gonna gamble and focus on Chutney (Feature #9521) hoping it will fix this issue.

#18 Updated by anonym 2016-02-20 14:57:28

• blocked by Feature #9521: Use the chutney Tor network simulator in our test suite added

#19 Updated by intrigeri 2016-05-18 13:16:27

• Assignee changed from anonym to intrigeri
• Target version set to Tails_2.4

Will give it a try.

#20 Updated by intrigeri 2016-05-18 15:10:21

• blocked by deleted (#8668)

#21 Updated by intrigeri 2016-05-18 15:10:32

• blocked by Bug #10497: wait_until_tor_is_working helper is fragile added

#22 Updated by intrigeri 2016-05-18 15:19:50

• Status changed from Confirmed to In Progress
• Assignee changed from intrigeri to anonym
• % Done changed from 0 to 50
• QA Check set to Ready for QA

(Or should it be for bertagaz?)

Seems to be fixed by chutney.

#23 Updated by intrigeri 2016-05-20 19:13:05

• Assignee changed from anonym to intrigeri
• QA Check changed from Ready for QA to Dev Needed

Too many false positives, back onto my plate. I’ve marked more tests as fragile, we’ll see.

#24 Updated by intrigeri 2016-05-24 13:59:07

• File 01_19_06_Anti_test__Detecting_TCP_leaks_from_the_Unsafe_Browser_with_the_firewall_leak_detector.mkv added

I’ve just seen it fail again (video attached):

call returned: [0, "Creating logfile at /tmp/dogtail-amnesia/logs/tmp.IAB6SjAMOS_20160524-105252_debug ...\nClicking on [label | Unsafe Browser]\nMouse button 1 click at (309,380)\n", ""]
calling as root: rm -f '/tmp/tmp.IAB6SjAMOS'
call returned: [0, "", ""]
    When I successfully start the Unsafe Browser                                                   # features/step_definitions/browser.rb:18
calling as root: . /usr/local/lib/tails-shell-library/tor-browser.sh && echo ${TBB_INSTALL}/firefox
call returned: [0, "/usr/local/lib/tor-browser/firefox\n", ""]
    And I open Tails homepage in the Unsafe Browser                                                # features/step_definitions/browser.rb:219
      FindFailed: can not find BrowserAddressBar.png on the screen.
      Line ?, in File ? (RuntimeError)
      ./features/step_definitions/browser.rb:89:in `/^I open the address "([^"]*)" in the (.*)$/'
      ./features/step_definitions/browser.rb:220:in `/^I open Tails homepage in the (.+)$/'
      features/tor_enforcement.feature:23:in `And I open Tails homepage in the Unsafe Browser'
    And Tails homepage loads in the Unsafe Browser                                                 # features/step_definitions/browser.rb:228

It seems to me that the click on the new tab button might be lost due to the window moving down when the notification bar closes. If my guess is correct, then think that the solution is easy: in robust_notification_wait, we should wait for the notification bar to actually have disappeared, before returning (and this should be tracked by a different ticket).

#25 Updated by intrigeri 2016-05-25 08:57:10

• Assignee deleted (intrigeri)
• Target version deleted (Tails_2.4)
• % Done changed from 50 to 10

I’m giving up on this one (I was merely looking for very low hanging fruits during this cycle, and I’ll let someone else fix the problem, now that it’s been diagnosed).

#26 Updated by intrigeri 2016-05-28 09:43:55

• blocks Bug #10442: Totem "Watching a WebM video over HTTPS" test never passes on Jenkins added

#27 Updated by bertagaz 2016-07-22 05:22:23

• related to Bug #11592: Step "[...] has loaded in the Tor Browser" is fragile added

#28 Updated by intrigeri 2016-07-22 05:33:46

• Feature Branch changed from test/10381-fix-I-open-the-address-test-is-fragile to wip/test/10381-fix-I-open-the-address-test-is-fragile

#29 Updated by anonym 2016-12-05 20:43:54

• Assignee set to anonym
• Target version set to Tails 2.10

#30 Updated by anonym 2017-01-21 08:19:13

• % Done changed from 10 to 20
• Feature Branch changed from wip/test/10381-fix-I-open-the-address-test-is-fragile to test/10381-fix-I-open-the-address-test-is-fragile

intrigeri wrote:
> I’ve just seen it fail again (video attached):
>
> […]
>
> It seems to me that the click on the new tab button might be lost due to the window moving down when the notification bar closes. If my guess is correct, then think that the solution is easy: in robust_notification_wait, we should wait for the notification bar to actually have disappeared, before returning (and this should be tracked by a different ticket).

Makes a lot of sense. Implemented in the feature branch.

#31 Updated by anonym 2017-01-22 13:44:58

• Assignee changed from anonym to intrigeri
• % Done changed from 20 to 50
• QA Check changed from Dev Needed to Ready for QA

Beyond what you sugested, intrigeri, I also made this step retry not only for the Tor Browser, but for all browsers. If this step is still fragile, it’s due to reasons not yet clear to me, so I think this is all I can do for now. We have other similar tickets open (e.g. Bug #11592) which probably captures these other ways we can have failures in this area.

Please review’n’merge into testing and devel!

#34 Updated by intrigeri 2017-01-23 07:28:01

• Target version changed from Tails 2.10 to Tails_2.11

#35 Updated by intrigeri 2017-01-25 09:19:38

• Assignee changed from intrigeri to anonym
• % Done changed from 50 to 70

Code review passes. Unmarked one more test as fragile, that I think you had forgotten. Works for me locally. So if Jenkins is happy with that change, please merge into stable and devel :)

#36 Updated by anonym 2017-02-17 17:05:32

• Status changed from In Progress to Fix committed
• Assignee deleted (anonym)
• % Done changed from 70 to 100
• QA Check changed from Ready for QA to Pass

intrigeri wrote:
> So if Jenkins is happy with that change

AFAICT it is…

> please merge into stable and devel :)

… so merged!

#38 Updated by anonym 2017-03-09 13:59:12

• Status changed from Fix committed to Resolved