Bug #10376
The "the Tor Browser loads the (startup page|Tails roadmap)" step is fragile
100%
Description
Refactoring would allow retry_tor
magic to be used for this step in case loading the page fails.
Subtasks
Related issues
Blocked by Tails - |
Resolved | 2016-04-15 | |
Blocked by Tails - |
Resolved | 2015-11-06 |
History
#1 Updated by kytv 2015-10-15 05:41:42
- Parent task set to Bug #10288
#2 Updated by kytv 2015-10-15 05:56:27
anonym wrote:
> The ‘I see the Tails roadmap URL’ doesn’t use the retrying-magic we have in the ‘I open the address …’ step. We should refactor out that code from the latter so it can be used in the former step.
#3 Updated by anonym 2015-10-15 06:30:08
- Subject changed from Refactor the "loaded the Tails roadmap" step in the test suite to The "the Tor Browser loads the (startup page|Tails roadmap)" step is fragile
kytv wrote:
> anonym wrote:
> > The ‘I see the Tails roadmap URL’ doesn’t use the retrying-magic we have in the ‘I open the address …’ step. We should refactor out that code from the latter so it can be used in the former step.
Sorry, I meant that the ‘the Tor Browser has started and loaded the Tails roadmap
’ step is fragile. Hence we need to refactor out the retrying code from the ‘I open the address ...
’ step so it can be used in this step as well.
Note that the problematic step’s definition matches /^the Tor Browser (?:has started and )?load(?:ed|s) the (startup page|Tails roadmap)$/
so all scenarios using it for the startup page case are also fragile. That’s another 11 scenarios (essentially all of torified_browsing.feature
).
#4 Updated by intrigeri 2015-10-16 02:37:59
- Assignee set to anonym
kytv, anonym: this has a target version (rightfully I guess), so it needs an assignee. Tentatively assigning to anonym, please sort this out together :)
#5 Updated by intrigeri 2015-10-16 02:38:10
- blocks #8668 added
#6 Updated by intrigeri 2015-10-16 03:19:11
- Tracker changed from Feature to Bug
#7 Updated by anonym 2015-10-16 05:51:41
- Assignee changed from anonym to kytv
- Target version changed from Tails_1.7 to Tails_1.8
Could this reasonably be part of the rest of the test suite work you have? Optimistically reassigning to you (note that I’ll do this for the other children of Bug #10288, but won’t comment there).
In any case, let’s postpone this to 1.8. We have way to much on our plates this cycle.
#8 Updated by kytv 2015-10-16 07:27:34
- Feature Branch set to test/1e5fd8f-fix_startup-page_roadmap-test-is-fragile
#9 Updated by kytv 2015-10-16 07:37:45
- Feature Branch changed from test/1e5fd8f-fix_startup-page_roadmap-test-is-fragile to test/10376-fix_startup-page_roadmap-test-is-fragile
#10 Updated by anonym 2015-10-16 09:39:26
Branch imported to our Git (but you forgot “kytv/” in that field, so no update), scenarios marked as @fragile
in devel.
#11 Updated by intrigeri 2015-11-06 06:05:07
- Deliverable for set to 270
#12 Updated by anonym 2015-11-06 06:12:15
- Assignee changed from kytv to anonym
There might be something smart to do that will fix all of {Bug #10442, Bug #10381, Bug #10376} at the same time, and increase browser page loading throughout the test suite.
#13 Updated by intrigeri 2015-12-05 13:20:23
- Target version changed from Tails_1.8 to Tails_2.0
(We’re going to mark as fragile all tests that depend on Tor to have bootstrapped for the moment => not so urgent.)
#14 Updated by anonym 2016-01-06 14:06:29
- Target version changed from Tails_2.0 to Tails_2.2
#15 Updated by anonym 2016-02-20 13:20:58
- Priority changed from Normal to Elevated
- Target version changed from Tails_2.2 to Tails_2.4
#16 Updated by anonym 2016-02-20 14:56:30
- Priority changed from Elevated to Normal
- Target version deleted (
Tails_2.4) - Deliverable for deleted (
270)
I’m gonna gamble and focus on Chutney (Feature #9521) hoping it will fix this issue.
#17 Updated by anonym 2016-02-20 14:57:49
- blocked by
Feature #9521: Use the chutney Tor network simulator in our test suite added
#18 Updated by intrigeri 2016-05-18 15:06:12
- blocked by deleted (
#8668)
#19 Updated by intrigeri 2016-05-18 15:09:53
- Assignee changed from anonym to intrigeri
- Target version set to Tails_2.4
#20 Updated by intrigeri 2016-05-18 15:10:10
- blocked by
Bug #10497: wait_until_tor_is_working helper is fragile added
#21 Updated by intrigeri 2016-05-18 18:51:55
- Status changed from Confirmed to In Progress
- % Done changed from 0 to 10
I’ll wait a few days to see how it works in Jenkins, now that we are using chutney.
#22 Updated by intrigeri 2016-05-25 10:25:11
- % Done changed from 10 to 60
This now works well (after flagging more tests as fragile), so we’re only blocked by Bug #10497 before this branch can be reviewed’n’merged.
#23 Updated by intrigeri 2016-05-27 14:08:11
- Assignee changed from intrigeri to anonym
- QA Check set to Ready for QA
#24 Updated by anonym 2016-06-01 19:56:56
- Status changed from In Progress to Fix committed
- Assignee deleted (
anonym) - % Done changed from 60 to 100
- QA Check changed from Ready for QA to Pass
#25 Updated by anonym 2016-06-08 01:31:57
- Status changed from Fix committed to Resolved