Bug #11457

"I close the Unsafe Browser" step is fragile

Added by intrigeri 2016-05-22 14:41:43 . Updated 2019-08-30 14:18:59 .

Status:
Resolved
Priority:
Normal
Assignee:
hefee
Category:
Test suite
Target version:
Start date:
2016-05-22
Due date:
% Done:

100%

Feature Branch:
https://salsa.debian.org/tails-team/tails/merge_requests/33
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Unsafe Browser
Deliverable for:

Description

Video attached. I suspect that ctrl-q doesn’t reach the right window, e.g. because it’s emitted immediately after we close the notification area, and before GNOME Shell has had time to focus the browser’s window. Perhaps we should explicitly focus it first?


Files


Subtasks


History

#1 Updated by intrigeri 2016-05-22 14:43:35

  • Feature Branch set to test/11457-I-close-the-browser-is-fragile

#2 Updated by spriver 2017-05-31 13:19:35

  • Subject changed from "I close the (?:Unsafe|I2P) Browser" step is fragile to "I close the Unsafe Browser" step is fragile

#3 Updated by spriver 2017-05-31 14:03:26

  • Assignee set to anonym
  • QA Check set to Ready for QA
  • Feature Branch changed from test/11457-I-close-the-browser-is-fragile to spriver:feature/11457-closing-unsafe-browser-is-fragile

Done this by implementing clicking on the Unsafe Browser’s icon on the start page.

#4 Updated by intrigeri 2017-06-28 15:15:24

  • Target version set to Tails_3.2

#5 Updated by anonym 2017-06-29 13:33:10

  • blocks Feature #13239: Core work 2017Q3: Test suite maintenance added

#6 Updated by anonym 2017-08-16 11:51:32

  • Assignee changed from anonym to spriver
  • % Done changed from 0 to 50
  • QA Check changed from Ready for QA to Dev Needed

From commit:023a16b0fbf2bff4a70285b9823d57dfea64be7c:

 When /^I close the Unsafe Browser$/ do
+  # Click on the picture on the start page to have the focus
+  # definitely in the Unsafe Browser before closing it
+  @screen.click('UnsafeBrowserHomepage.png')
   @screen.type("q", Sikuli::KeyModifier.CTRL)
 end

My only gripe here is that this step will only work if the Unsafe Browser’s homepage is shown, and not if we have navigated to any other page. I suppose we currently only use this step in that situation, but it’s good practice to avoid such surprising preconditions.

Normally how we deal with window detection and focusing is to have an image of the window title that we look for and click, respectively. It pains me to have us introduce more images, but I think that is the sensible solution here.

#7 Updated by BitingBird 2017-08-30 13:47:27

  • Status changed from Confirmed to In Progress

#8 Updated by intrigeri 2017-09-07 12:58:56

  • Target version changed from Tails_3.2 to Tails_3.3

#9 Updated by intrigeri 2017-10-01 09:58:45

  • blocks Feature #13240: Core work 2017Q4: Test suite maintenance added

#10 Updated by intrigeri 2017-10-01 09:58:46

  • blocked by deleted (Feature #13239: Core work 2017Q3: Test suite maintenance)

#11 Updated by anonym 2017-11-15 11:30:50

  • Target version changed from Tails_3.3 to Tails_3.5

#12 Updated by intrigeri 2018-01-01 17:01:08

  • blocked by deleted (Feature #13240: Core work 2017Q4: Test suite maintenance)

#13 Updated by anonym 2018-01-23 19:52:35

  • Target version changed from Tails_3.5 to Tails_3.6

#14 Updated by bertagaz 2018-03-14 11:32:09

  • Target version changed from Tails_3.6 to Tails_3.7

#15 Updated by bertagaz 2018-05-10 11:09:15

  • Target version changed from Tails_3.7 to Tails_3.8

#16 Updated by intrigeri 2018-06-26 16:27:52

  • Target version changed from Tails_3.8 to Tails_3.9

#17 Updated by intrigeri 2018-09-05 16:26:52

  • Target version changed from Tails_3.9 to Tails_3.10.1

#18 Updated by intrigeri 2018-10-24 17:03:37

  • Target version changed from Tails_3.10.1 to Tails_3.11

#19 Updated by CyrilBrulebois 2018-12-16 13:54:05

  • Target version changed from Tails_3.11 to Tails_3.12

#20 Updated by intrigeri 2019-01-27 10:48:17

  • Target version deleted (Tails_3.12)

#21 Updated by intrigeri 2019-08-30 10:21:36

  • Affected tool set to Unsafe Browser

#22 Updated by intrigeri 2019-08-30 13:29:14

  • Status changed from In Progress to Needs Validation
  • Assignee changed from spriver to hefee
  • Target version set to Tails_4.0
  • Feature Branch changed from spriver:feature/11457-closing-unsafe-browser-is-fragile to https://salsa.debian.org/tails-team/tails/merge_requests/33

#23 Updated by Anonymous 2019-08-30 14:18:59

  • Status changed from Needs Validation to Resolved
  • % Done changed from 50 to 100

Applied in changeset commit:tails|a7ca22afb536e8936727d1e681baa6140cc95f37.