Feature #10400

Activate Farsi on our website

Added by Anonymous 2015-10-20 14:30:14 . Updated 2016-01-06 11:30:17 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Tails_2.0
Start date:
Due date:
% Done:

60%

Feature Branch:
web/10400-farsi-only
Type of work:
End-user documentation
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

If enough core files have been translated, we could activate Farsi.

Files

0002-Fix-download-button-in-Farsi.patch (825 B) sajolida, 2015-11-15 03:35:06
0001-Format-relative-URL-in-lowercase-Farsi-translators-g.patch (3408 B) sajolida, 2015-11-15 03:35:06

Subtasks

Related issues

Related to Tails - Feature #10326: Check the percentage of translated core files in farsi Resolved
Related to Tails - Feature #10411: Translate .index files correctly into farsi Resolved 2015-10-23
Blocked by Tails - Feature #10305: Verify rtl language support / setup in Ikiwiki for farsi translations Resolved 2015-09-30

History

#1 Updated by Anonymous 2015-10-20 14:30:23

  • related to Feature #10305: Verify rtl language support / setup in Ikiwiki for farsi translations added

#2 Updated by Anonymous 2015-10-20 14:30:32

  • related to Feature #10326: Check the percentage of translated core files in farsi added

#3 Updated by Anonymous 2015-10-26 08:37:18

  • Assignee deleted (None)

Assigning this to myself.

We need to

  • activate “fa” in ikiwiki config
  • pull from weblate
  • ask for review and merge

#4 Updated by Anonymous 2015-10-26 08:45:29

  • Feature Branch set to 451f:tails/feature/10400-farsi-documentation

#5 Updated by Anonymous 2015-10-26 08:51:05

  • related to Feature #10411: Translate .index files correctly into farsi added

#6 Updated by Anonymous 2015-10-26 08:55:17

  • Status changed from New to Confirmed
  • Assignee set to sajolida
  • % Done changed from 0 to 10
  • QA Check set to Ready for QA

Hi sajolida,

as you are also the one who will review the rtl feature of ikiwiki, I am assigning this ticket to you, too.

I’ve prepared a branch containing the current farsi translations (about 50% of the whole website has been translated, and nearly 100% of core files). There will be more, and I’ll add them to this branch as soon as they arrive.

I’ve rebased the branch on current master and I think that this is ready to be launched.

Maybe we should talk about if/when/how we announce this lucky event publicly :)

#7 Updated by Anonymous 2015-10-26 11:41:06

  • % Done changed from 10 to 20

Updated the branch again.

#8 Updated by intrigeri 2015-10-26 12:37:52

I’m slightly concerned that we might be merging something before we have a process to update it in the future (that is, to merge future changes from weblate). Not a blocker, I thought I would just raise it to make sure you folks take this into account, and then it’s your call.

#9 Updated by Anonymous 2015-10-26 13:21:50

Hi,

thanks for raising that very valid concern.

That’s why I created https://labs.riseup.net/code/issues/10331 after having discussed exactly that at the last meeting.

This time, I’ve taken some time to merge this into current master, build the wiki, test some translations randomly to make sure they match.

But I agree completely that we need a process for the review, unless I play the translation manager regularly - which I am not opposed to :)

#10 Updated by intrigeri 2015-11-05 10:49:15

u wrote:
> That’s why I created https://labs.riseup.net/code/issues/10331 after having discussed exactly that at the last meeting.

Cool. So perhaps “Feature #10331 blocks Feature #10400” should be expressed clearly via Redmine?

#11 Updated by sajolida 2015-11-15 03:41:49

It’s super cool to see the website in Farsi!

In attachment you’ll find two patches to fix the download button. I think that translators got confused by having an URL with a capital letter.

I also have some concerns about the automatic commits made by Weblate. I think it’s problematic with ikiwiki to have PO files in your source that don’t correspond to any activate language. For example Polish is added in c6b7d37 and many others (Italian, Spanish, etc.).

Do you think we could do something from Weblate to fix this? Otherwise we might have to do this in ikiwiki but that sounds complicated.

#12 Updated by Anonymous 2015-11-20 06:45:45

  • QA Check changed from Dev Needed to Ready for QA

sajolida wrote:
> It’s super cool to see the website in Farsi!

Yeah!

> In attachment you’ll find two patches to fix the download button. I think that translators got confused by having an URL with a capital letter.

Awesome. I’ve merged them into my branch as well as latest translations to farsi and current master.

> I also have some concerns about the automatic commits made by Weblate. I think it’s problematic with ikiwiki to have PO files in your source that don’t correspond to any activate language. For example Polish is added in c6b7d37 and many others (Italian, Spanish, etc.).
>
> Do you think we could do something from Weblate to fix this? Otherwise we might have to do this in ikiwiki but that sounds complicated.

No we can’t because these are simply files which were added to git, so either we gitgnore them or delete them. For now, as we do not merge weblate’s commits automatically anyway, I’ve simply deleted them from my branch to make it mergeable.

#13 Updated by Anonymous 2015-11-20 06:45:58

  • Assignee set to sajolida

#14 Updated by Anonymous 2015-11-20 06:47:10

intrigeri wrote:
> u wrote:
> > That’s why I created https://labs.riseup.net/code/issues/10331 after having discussed exactly that at the last meeting.
>
> Cool. So perhaps “Feature #10331 blocks Feature #10400” should be expressed clearly via Redmine?

I do not think that Feature #10331 blocks Feature #10400.

#15 Updated by sajolida 2015-11-22 08:32:27

  • related to deleted (Feature #10305: Verify rtl language support / setup in Ikiwiki for farsi translations)

#16 Updated by sajolida 2015-11-22 08:32:37

  • blocked by Feature #10305: Verify rtl language support / setup in Ikiwiki for farsi translations added

#17 Updated by sajolida 2015-11-27 10:39:23

We’re almost ready. We’re now missing only a few reviews in French and German (sic): https://mailman.boum.org/pipermail/tails-l10n/2015-November/003035.html

#18 Updated by intrigeri 2015-11-29 11:05:44

I got the feeling on some related ticket that the plan might be to merge a Git history that introduces PO files for a bunch of non-active languages, and then deletes them all. I’d like to make sure you folks have checked the implications in terms of size of the .git directory (especially if in the future we’re going to merge again lots of changes to these PO files, and then delete them again, etc., each time we want to merge stuff from Weblate’s Git repo). I’m quite confident it’s going to be OK, but there’s no easy going back for this kind of things, so since we’ve rewritten the Git history to make it smaller, I’ve grown warry of potentially big changes in this area :)

#19 Updated by sajolida 2015-11-30 06:19:41

  • Target version set to Tails_1.8

#20 Updated by sajolida 2015-11-30 13:15:28

  • Assignee changed from sajolida to intrigeri
  • QA Check changed from Ready for QA to Info Needed

Actually, I’m sorry but I didn’t consider this. I’m cautious about binary files but I didn’t realize that hunders of PO files can be as bad :(

I checked and the size of the files removed in 08ae428 once XZipped and it’s 278 kB. Quite bad. But this commit should only be in two branches of the main repo web/10400-farsi and web/10305-rtl-support. Does it still makes sense to delete these branches remotely? and maybe ask people with the commit bit to delete them locally and hope for the best…

I also raised this issue in the ticket where we’re discussing merge (and review) policy from weblate. This should be adressed there to prevent this from happening in the future.

#21 Updated by intrigeri 2015-12-01 09:24:44

  • Subject changed from Activate farsi on website to Activate Farsi on our website

#22 Updated by intrigeri 2015-12-01 14:19:12

  • Assignee changed from intrigeri to sajolida
  • QA Check changed from Info Needed to Dev Needed

> I checked and the size of the files removed in 08ae428 once XZipped and it’s 278 kB.

OK.

> Quite bad.

Well, it’s only 0.5% of our current Git repo, so it’s not that bad. Note, however, that the Git history contains more than just this: it also has all deltas that added or updated these files previously. I’m more concerned about this than about a mere 278 kB that went it by mistake.

> But this commit should only be in two branches of the main repo web/10400-farsi and web/10305-rtl-support. Does it still makes sense to delete these branches remotely? and maybe ask people with the commit bit to delete them locally and hope for the best…

Yes, please do that but don’t spend too much energy on it (e.g. don’t bother tracking acknowledgements). Worst case, we can live with these 278 kB + past history.

Note that web/10305-rtl-support hasn’t the bunch of not-quite-useful-yet PO files: only web/10400-farsi should be deleted.

Also note that this ticket’s advertised topic branch (451f/feature/10400-farsi-documentation) also has a commit that removes a bunch of PO files, so if that’s what we plan to merge it may need to be taken care of as well.

> I also raised this issue in the ticket where we’re discussing merge (and policy from weblate. This should be adressed there to prevent this from happening in the future.

Right.

#23 Updated by Anonymous 2015-12-11 07:00:10

intrigeri wrote:
> Well, it’s only 0.5% of our current Git repo, so it’s not that bad. Note, however, that the Git history contains more than just this: it also has all deltas that added or updated these files previously. I’m more concerned about this than about a mere 278 kB that went it by mistake.

Then let’s revert the deletion in this branch?

> > But this commit should only be in two branches of the main repo web/10400-farsi and web/10305-rtl-support. Does it still makes sense to delete these branches remotely? and maybe ask people with the commit bit to delete them locally and hope for the best…
>
> Yes, please do that but don’t spend too much energy on it (e.g. don’t bother tracking acknowledgements). Worst case, we can live with these 278 kB + past history.
>
> Note that web/10305-rtl-support hasn’t the bunch of not-quite-useful-yet PO files: only web/10400-farsi should be deleted.

web/10305-rtl-support does not have the translations though, only the modifications on ikiwiki needed for RTL.

> Also note that this ticket’s advertised topic branch (451f/feature/10400-farsi-documentation) also has a commit that removes a bunch of PO files, so if that’s what we plan to merge it may need to be taken care of as well.
>
> > I also raised this issue in the ticket where we’re discussing merge (and policy from weblate. This should be adressed there to prevent this from happening in the future.
>
> Right.

Can I do something to make this work this time?
Maybe we can simply copy all the *.fa.po files somewhere now that they are translated instead of merging this branch directly into master?

#24 Updated by sajolida 2015-12-15 00:55:35

Yes, my plan was to delete the problematic branch remotely and ask for people with commit rights to do so locally. Then import the PO files for Farsi manually on top of master. I’ll work on it this week I promise!

#25 Updated by sajolida 2015-12-15 00:56:10

  • Priority changed from Normal to Elevated
  • Target version changed from Tails_1.8 to Tails_2.0

But likely not in time for 1.8.

#26 Updated by Anonymous 2015-12-15 03:37:31

sajolida wrote:
> Yes, my plan was to delete the problematic branch remotely and ask for people with commit rights to do so locally. Then import the PO files for Farsi manually on top of master. I’ll work on it this week I promise!

yaaay! :)))

#27 Updated by sajolida 2015-12-18 08:17:45

  • % Done changed from 20 to 60
  • Feature Branch changed from 451f:tails/feature/10400-farsi-documentation to web/10400-farsi-only

Ok, so here is what I did today:

  1. Created a fresh branch from master.
  2. Imported the Farsi PO files only (without the history from Weblate).
  3. Merged web/10305-rtl-support into it.
  4. Asked people on tails-dev and tails-l10n to delete web/10400-farsi (https://mailman.boum.org/pipermail/tails-dev/2015-December/009928.html).
  5. Rebuilt and checked the website from that branch.
  6. Asked root@boum.org to activate Farsi on the website.

We’re almost there!

#28 Updated by intrigeri 2015-12-19 01:22:27

sajolida, just in case you’ve missed it, Farsi PO files have issues according to our test suite: https://jenkins.tails.boum.org/view/Tails_ISO_tests/job/test_Tails_ISO_web-10400-farsi-only/lastFailedBuild/cucumberTestReport/check-po-files/check-all-po-files/ (perhaps the test suite needs fixing, I didn’t look any closer).

#29 Updated by sajolida 2015-12-20 02:19:36

  • Assignee changed from sajolida to intrigeri
  • QA Check changed from Dev Needed to Info Needed

I received emails about failed build until “Jenkins build is back to normal : build_Tails_ISO_web-10400-farsi-only #2” without me doing nothing.

I don’t think I received any mail regarding the test suite (what would be the subject?) and the URL you’re giving me here asks me for a password that I think I don’t have. What shall I do?

#30 Updated by intrigeri 2015-12-20 02:37:54

  • Assignee changed from intrigeri to sajolida
  • QA Check deleted (Info Needed)

sajolida wrote:
> I don’t think I received any mail regarding the test suite (what would be the subject?)

Indeed you had not (due to a bug in the notifications system that has been solved) — now you should have received one I’m told :)

> and the URL you’re giving me here asks me for a password that I think I don’t have.

It’s in the internal Git’s keyringer.

#31 Updated by sajolida 2015-12-20 08:55:30

I thought is was a personal password. Now I call check out Jenkins, so cool!

I think I fixed this now: https://jenkins.tails.boum.org/job/test_Tails_ISO_web-10400-farsi-only/

#32 Updated by sajolida 2016-01-06 11:13:59

  • Status changed from Confirmed to Resolved
  • Assignee deleted (sajolida)

#33 Updated by intrigeri 2016-01-06 11:30:18

Congrats!