Feature #10305
Verify rtl language support / setup in Ikiwiki for farsi translations
20%
Description
Subtasks
Related issues
Related to Tails - |
Resolved | 2015-12-25 | |
Blocks Tails - |
Resolved |
History
#1 Updated by Anonymous 2015-09-30 04:55:16
- Type of work changed from Test to End-user documentation
Weblate seems to correctly support RTL languages.
But our Ikiwiki templates lack the use of the dir=“rtl” and lang=“$lang_shortcode” attribute on the
tag. http://ikiwiki.info/forum/Right-to-left_support
This fixes the problem.
We would still need to adjust the download and donation button, using CSS :
html[dir="rtl"] .sidebar .download a {
background-position: left 30%;
}
html[dir="rtl"] .sidebar .donate a,
html[dir="rtl"] .sidebar .donate .selflink {
padding-left: 0;
padding-right: 0;
background-position: center right;
}
I suggest adding a rtl.css stylesheet which would contain only direction overrides.
#2 Updated by Anonymous 2015-09-30 04:56:43
- Category set to Internationalization
- Status changed from New to In Progress
- % Done changed from 0 to 10
- Starter set to No
Help welcome, this is relatively easy if you know html+css.
#3 Updated by Anonymous 2015-09-30 05:00:10
The same sort of css corrections need to be made for the download page.
#4 Updated by Anonymous 2015-09-30 08:05:34
- Assignee set to sajolida
thanks for proposing to work on this :) and yes, we need that only when there are enough farsi translations :)
#5 Updated by Anonymous 2015-10-20 14:30:23
- related to
Feature #10400: Activate Farsi on our website added
#6 Updated by Anonymous 2015-10-20 15:48:59
- Feature Branch set to 451f:tails/wiki_rtl_support
In the branch wiki_rtl_support I modified wiki/src/templates/page.tmpl
commit 97993a9f3e7f330c8351d016ae6ddd1d4c4c338a
This adds lang and dir to the html tag.
I did not modify the stylesheet though.
#7 Updated by Anonymous 2015-10-20 16:26:38
I’ve now also adapted the stylesheet a little bit, see commit ca3ebe9.
#8 Updated by intrigeri 2015-10-21 00:23:56
> In the branch wiki_rtl_support I modified wiki/src/templates/page.tmpl […] This adds lang and dir to the html tag.
May you please check if upstream ikiwiki templates (templates/page.tmpl
in git://git.ikiwiki.info/) did that since we’ve forked them? If not, it would be good to contribute these template improvements there to keep our delta smallish.
#9 Updated by sajolida 2015-10-21 01:58:42
- Target version set to Tails_1.7
#10 Updated by Anonymous 2015-10-21 02:21:57
Hi,
this has not been applied in Ikiwiki upstream: http://source.ikiwiki.branchable.com/?p=source.git;a=blob;f=templates/page.tmpl;h=9e8b330a4a25124eb799b52ad9b840b0c6105fd6;hb=HEAD
there was a patch: http://ikiwiki.info/todo/expose_html_language_and_direction/
I can write to JoeyH to ask him specifically.
#11 Updated by Anonymous 2015-10-23 03:29:40
I’ve talked to Joey and I will submit an upstream patch. In the meantime I’ve added another IF statement around my modifications because the variables which i used are only available if the po plugin is enabled.
This can now be reviewed IMO.
#12 Updated by Anonymous 2015-10-23 03:30:15
- % Done changed from 10 to 20
#13 Updated by intrigeri 2015-10-23 06:24:06
- QA Check set to Ready for QA
> This can be reviewed IMO.
Adjusting ticket metadata accordingly.
#14 Updated by Anonymous 2015-10-26 07:36:59
fyi: i’ve submitted a patch to upstream in the meantime. My branch contains the same modifications.
#15 Updated by Anonymous 2015-10-26 14:16:47
The patch has been applied upstream see http://ikiwiki.info/recentchanges/ (grep RTL)
#16 Updated by sajolida 2015-11-03 09:58:34
- Target version changed from Tails_1.7 to Tails_1.8
#17 Updated by sajolida 2015-11-03 09:58:51
- Priority changed from Normal to Elevated
Postponing and raising priority.
#18 Updated by sajolida 2015-11-04 12:40:47
- Assignee deleted (
sajolida) - QA Check changed from Ready for QA to Info Needed
First of all, sorry for the delay. Then, can I ask for more instructions on how to actually test that? I understand that I need to have HTML_LANG_DIR set to “rtl” but how can I get that? Maybe you can send me a patch for ikiwiki.setup and some Farsi po files to test (or tell me where to get them).
#19 Updated by intrigeri 2015-11-04 18:04:43
> I understand that I need to have HTML_LANG_DIR set to “rtl” but how can I get that?
My (untested) understanding of the code leads me to believe that ikiwiki automatically sets HTML_LANG_DIR
to rtl for Arabic, Farsi and Hebrew (sub htmllangdir
in the po plugin).
#20 Updated by Anonymous 2015-11-05 02:28:28
intrigeri wrote:
> > I understand that I need to have HTML_LANG_DIR set to “rtl” but how can I get that?
>
> My (untested) understanding of the code leads me to believe that ikiwiki automatically sets HTML_LANG_DIR
to rtl for Arabic, Farsi and Hebrew (sub htmllangdir
in the po plugin).
Correct, the variables will be set automatically to rtl depending on the language.
To get farsi po files you could use my repository branch: 451f:feature/10400-farsi-documentation
Or use the weblate repository if you wish (_git remote add weblate https://git-tails.immerda.ch/weblate/tails_) On my branch I did the tests already though. I should update since last time i guess.
In ikiwiki.setup (with line numbers i have:)
200 po_slave_languages:
201 - de|Deutsch
202 - fa|Farsi
#21 Updated by Anonymous 2015-11-05 02:28:46
- Assignee set to sajolida
- QA Check changed from Info Needed to Ready for QA
#22 Updated by sajolida 2015-11-15 03:33:17
- Assignee deleted (
sajolida) - QA Check changed from Ready for QA to Dev Needed
I reviewed this and I’m fine with your changes.
Note that for RTL support we need ikiwiki/jessie, so we should clarify this on the website (in various places below /contribute).
I’m fine with having a dedicated CSS for RTL support. We used the @import directive successfully for the Installation Assistant so I think we should do that.
#23 Updated by Anonymous 2015-11-20 06:55:15
- Assignee set to sajolida
- QA Check changed from Dev Needed to Ready for QA
Hi,
I’ve updated my branch using an external RTL stylesheet. Please review n merge.
#24 Updated by Anonymous 2015-11-20 06:55:47
sajolida wrote:
> Note that for RTL support we need ikiwiki/jessie, so we should clarify this on the website (in various places below /contribute).
I’ll try to submit a modification for this.
done in 451f:tails/feature/10305-document-ikiwiki-rtl
#25 Updated by sajolida 2015-11-22 08:32:27
- related to deleted (
)Feature #10400: Activate Farsi on our website
#26 Updated by sajolida 2015-11-22 08:32:37
- blocks
Feature #10400: Activate Farsi on our website added
#27 Updated by sajolida 2015-11-27 10:39:49
Cool, but it seems like you missed:
- Adding local.rtl.css to your branch (see c0163f9).
- Adjusting the ikiwiki version in build.mdwn and maybe elsewhere too.
We’re almost there so I also wrote root@boum.org about their ikiwiki version as well so they are ready to update.
#28 Updated by sajolida 2015-11-27 10:40:35
- Assignee deleted (
sajolida) - QA Check changed from Ready for QA to Dev Needed
By the way, I don’t mind doing these silly little tasks myself but I would as you for a review anyway. If you prefer I can do them, I don’t mind :)
#29 Updated by Anonymous 2015-11-28 04:36:38
Hi,
indeed i forgot to add the css file. Done in 472b21f47f185a587e3a364e53ca8aff388b6074 on451f:tails/wiki_rtl_support.
#30 Updated by Anonymous 2015-11-28 04:42:00
sajolida wrote:
> Cool, but it seems like you missed:
> * Adjusting the ikiwiki version in build.mdwn and maybe elsewhere too.
done on a different branch than the one for the stylesheet (sorry about that): 451f:tails/feature/10305-document-ikiwiki-rtl
I had only edited wiki/src/contribute/build/website.mdwn. Now also wiki/src/contribute/build.mdwn.
> We’re almost there so I also wrote root@boum.org about their ikiwiki version as well so they are ready to update.
Great, thanks.
#31 Updated by Anonymous 2015-11-28 04:43:02
- Assignee set to sajolida
- QA Check changed from Dev Needed to Ready for QA
#32 Updated by Anonymous 2015-11-28 04:43:52
sajolida wrote:
> By the way, I don’t mind doing these silly little tasks myself but I would as you for a review anyway. If you prefer I can do them, I don’t mind :)
Thanks for proposing. This time it feels like that’s a proper review process, so let’s keep it that way :)))
#33 Updated by sajolida 2015-11-30 13:02:48
- Status changed from In Progress to Resolved
- Assignee deleted (
sajolida) - QA Check deleted (
Ready for QA)
Ok, so I merged your branch into web/10400-farsi. Let’s consider this issue as resolved then.
#34 Updated by sajolida 2015-12-25 17:02:03
- related to
Bug #10794: Fix placement of "Tor check" button added