Bug #10794

Fix placement of "Tor check" button

Added by sajolida 2015-12-25 17:01:47 . Updated 2016-01-26 00:07:52 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Internationalization
Target version:
Tails_2.0
Start date:
2015-12-25
Due date:
% Done:

10%

Feature Branch:
451f:tails/wiki_rtl_support
Type of work:
Website
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Now that we merged the RTL branch web/10305-rtl-support, the “Tor check” button is on the left of the news page in English and Farsi, while it should be on the right, covering up the “Download” button. See attachment.

Files

tor_check.png (84303 B) sajolida, 2015-12-25 17:01:18
no local.rtf.css.png (192637 B) sajolida, 2016-01-07 15:42:12
farsi.png (81472 B) sajolida, 2016-01-12 13:49:55
english.png (80778 B) sajolida, 2016-01-12 13:49:55

Subtasks

Related issues

Related to Tails - Feature #10305: Verify rtl language support / setup in Ikiwiki for farsi translations Resolved 2015-09-30

History

#1 Updated by sajolida 2015-12-25 17:02:02

  • related to Feature #10305: Verify rtl language support / setup in Ikiwiki for farsi translations added

#2 Updated by sajolida 2015-12-25 17:03:07

  • Assignee deleted (None)
  • Priority changed from Normal to Elevated
  • Target version set to Tails_2.0

Assigning to u who wrote ca3ebe9 originally (I didn’t cbeck this commit was breaking the layout, but it’s quite likely) and setting as Elevated and for 2.0 as it’s a regression.

#3 Updated by Anonymous 2016-01-06 13:15:41

For some reason I cannot seem to find the RTL stylesheet in the source tree.

The modifications https://tails.boum.org/local.rtl.css should be:
(This file is not in the tree??)

 html[dir=rtl] #tor_check {
      float: right;
      margin: 0 0 2em 0;
  }
  html[dir=rtl] .sidebar .download a {
      background-position: 1em 50%;
  }

#4 Updated by Anonymous 2016-01-06 13:18:55

  • Status changed from Confirmed to In Progress
  • Assignee set to sajolida
  • % Done changed from 0 to 10
  • QA Check set to Ready for QA
  • Feature Branch set to 451f:tails/wiki_rtl_support

Modifications are in [wiki_rtl_support 99d0efa]

#5 Updated by sajolida 2016-01-07 15:42:38

  • File no local.rtf.css.png added
  • Assignee deleted (sajolida)
  • QA Check changed from Ready for QA to Info Needed

Oops, I probably fucked it up with merging your branch initially.

Now local.rtf.css is up https://tails.boum.org/local.rtl.css but I can’t see any change on the placement of the “Tor check” button. Also, from Tor Browser and the developers tools of Firefox, I don’t see local.rtl.css being loaded. See attachment. How could that be?

#6 Updated by Anonymous 2016-01-07 16:01:57

  • Assignee set to sajolida
  • QA Check changed from Info Needed to Ready for QA

Yes, it seems that the stylesheet is not loaded at all.
The line which does the @import simply misses a “;” at the end.

Could you fix that?
Cheers!

#7 Updated by Anonymous 2016-01-07 16:10:36

Committed the modifications to my branch. So you could just merge it :)

#8 Updated by sajolida 2016-01-08 16:24:29

  • Assignee deleted (sajolida)
  • QA Check changed from Ready for QA to Dev Needed

Merged, now local.rtl.css is loading, ba767e3 is applied but the “Tor check” button is still at the same place :(

#9 Updated by Anonymous 2016-01-12 11:33:10

  • Assignee set to sajolida
  • QA Check changed from Dev Needed to Ready for QA

Please pull again from [wiki_rtl_support af72eb7] Improve farsi CSS and
[wiki_rtl_support c0a3023] remove trailing whitespace

I also made some other minor improvements.

#10 Updated by sajolida 2016-01-12 13:49:58

  • File english.png added
  • File farsi.png added
  • Assignee deleted (sajolida)
  • QA Check changed from Ready for QA to Dev Needed

I still see weird stuff, see attachments.

#11 Updated by Anonymous 2016-01-12 16:43:33

woah, sorry. fixed again, now for good i hope in [wiki_rtl_support 7ba0f5d] fix tor check btn placement again.

#12 Updated by Anonymous 2016-01-12 16:43:46

  • Assignee set to sajolida
  • QA Check changed from Dev Needed to Ready for QA

#13 Updated by sajolida 2016-01-13 11:52:49

  • Assignee deleted (sajolida)
  • QA Check changed from Ready for QA to Dev Needed

Merged and pushed.

But that’s still not what I expected and maybe I should clarify the expected result.

Before we merged the Farsi branch, the “Tor check” button was exactly on top of the “Download Tails” button. It had the same size and so it was hiding it. That’s the way I found some years ago to replace this button with something else different on one page only.

We did that because people freaked out after we changed the homepage from check.torproject.org to our /news. So we still wanted to provide people with some “Tor check” button on this page only (as it’s the homepage).

I’m still in favor of doing this.

#14 Updated by Anonymous 2016-01-15 18:05:21

  • Assignee set to sajolida
  • QA Check changed from Dev Needed to Ready for QA

Ack, I did indeed not know what it was supposed to be.

fixed in [wiki_rtl_support 5c9131a] fix Bug #10794 the Tor button should lie over the download button.

#15 Updated by sajolida 2016-01-26 00:07:52

  • Status changed from In Progress to Resolved
  • Assignee deleted (sajolida)
  • QA Check deleted (Ready for QA)

With 6895b84 on top, it’s fixed now. We made it! :)