Tails

#1 Updated by intrigeri 2015-03-30 11:39:54

• Category set to Installation
• Assignee set to kurono

kurono, wanna give it a try?

#2 Updated by anonym 2015-03-30 11:40:51

• Tracker changed from Bug to Feature

#3 Updated by BitingBird 2015-03-30 23:23:46

• Starter set to Yes

#5 Updated by kurono 2015-04-28 11:27:25

• Status changed from Confirmed to In Progress
• Assignee deleted (kurono)
• QA Check set to Ready for QA
• Feature Branch set to feature/9130-tails-installer-notify-on-small-device

#6 Updated by intrigeri 2015-04-28 16:36:46

• Tracker changed from Feature to Bug
• Assignee set to intrigeri
• % Done changed from 0 to 30

#7 Updated by intrigeri 2015-04-29 06:30:33

• Feature Branch changed from feature/9130-tails-installer-notify-on-small-device to kurono:feature/9130-tails-installer-notify-on-small-device

#8 Updated by intrigeri 2015-05-01 07:34:20

• Assignee changed from intrigeri to kurono
• Target version changed from Tails_1.4 to Tails_1.4.1
• QA Check changed from Ready for QA to Dev Needed

Thanks!

• I find the is_device_big key name a bit unclear. How about is_device_big_enough instead, to match what we’re using in the rest of the related code?
• The branch hardcodes the “at least 3.5GB is required” string. I bet this will be forgotten next time we bump the size requirements, so please derive this string from the min_system_partition_size and min_persistence_partition_size config settings.
• I recommend asking to sajolida or tails-ux@ for a review of the newly introduced string.

#9 Updated by kurono 2015-05-04 10:28:59

• Assignee deleted (kurono)
• QA Check changed from Dev Needed to Ready for QA

#11 Updated by intrigeri 2015-05-31 13:50:09

• Assignee set to sajolida

Explicitly assigning to sajolida, then, because it seems it might have slipped through the cracks.

#12 Updated by sajolida 2015-06-08 17:02:31

• Assignee changed from sajolida to kurono
• QA Check deleted (Ready for QA)

Thanks for pinging me on Redmine, I missed the email on tails-ux.

I think you string is fine. Maybe I would say “The selected device is too small to install Tails” instead of “”The selected device is too small to install Tails to".

Oh, and you introduced a trailing whitespace in commit:10f891c. I suggest you to activate diff coloring in your gitconfig:

[color]
        branch = true
        diff = true
        decorate = true
        grep = true
        interactive = true
        pager = true
        showbranch = true
        status = true
        ui = true

:)

#13 Updated by intrigeri 2015-06-09 07:09:12

• QA Check set to Dev Needed

#14 Updated by kurono 2015-06-09 17:03:23

• QA Check changed from Dev Needed to Ready for QA

#16 Updated by intrigeri 2015-06-10 08:14:34

• Assignee changed from kurono to intrigeri

Thanks!

#17 Updated by intrigeri 2015-06-12 08:39:20

• Assignee changed from intrigeri to sajolida
• QA Check changed from Ready for QA to Info Needed

sajolida wrote:
> I think you string is fine. Maybe I would say “The selected device is too small to install Tails” instead of “”The selected device is too small to install Tails to".

Thanks for the input! It seems that there’s something I don’t understand here, though: why are we saying “The selected device”, while the user has not selected anything (and they can’t possibly have selected it since we hare hiding too small devices)?

#18 Updated by sajolida 2015-06-16 09:38:06

• Assignee changed from sajolida to kurono

Right, if overlooked this. Silly me. I only looked at the phrasing without questioning the scenario :)

kurono, if I understand correctly this message appears in the log when the user plugs in a device. Then could it be possible to say:

The device ${device} is too small to install Tails (at least %s GB is required).

With ${device} being the same description as we would otherwise display in the Target Device drop-down list.

#19 Updated by intrigeri 2015-06-18 03:27:38

• QA Check changed from Info Needed to Dev Needed

#20 Updated by kurono 2015-06-22 08:42:24

• Assignee changed from kurono to sajolida
• QA Check changed from Dev Needed to Ready for QA

Ok, ready fo the next iteration.
I also add a exception as in
https://labs.riseup.net/code/issues/5623

#21 Updated by sajolida 2015-06-23 05:18:07

• Assignee changed from sajolida to anonym

The wording is good for me now. Assigning it anonym for the final merge.

#22 Updated by anonym 2015-06-27 08:36:28

• Assignee changed from anonym to intrigeri

sajolida wrote:
> The wording is good for me now. Assigning it anonym for the final merge.

I think intrigeri is more suitable, being the RM and the person who has looked at the code so far.

#23 Updated by intrigeri 2015-06-28 03:48:53

• Target version changed from Tails_1.4.1 to Tails_1.5

This arrived too late => postponing.

#25 Updated by intrigeri 2015-07-03 08:01:33

• Assignee changed from intrigeri to kurono
• QA Check changed from Ready for QA to Info Needed

kurono wrote:
> I also add a exception as in https://labs.riseup.net/code/issues/5623

So you went for listing all devices (even those that are too small), and then error’ing out with a dialog window if the user select a device that’s too small, right?

I think I would prefer the other option, that iirc you implemented initially, that is: to let the user know that some device was filtered out of the available target devices list. This avoids letting users attempt to do something we already know won’t work. What do you think?

#27 Updated by kurono 2015-07-09 08:33:21

• Assignee deleted (kurono)
• QA Check changed from Info Needed to Ready for QA

Yes, I think it is better to not show the user the device, if she can not use it anyway. New changes done in https://git-tails.immerda.ch/kurono/liveusb-creator/commit/?h=feature/9130-tails-installer-notify-on-smal-device

#28 Updated by intrigeri 2015-07-09 08:38:37

• Assignee set to intrigeri

Cool! I’ll take it.

#29 Updated by intrigeri 2015-07-09 09:53:35

• % Done changed from 30 to 50

Code looks good. Next steps are:

1. Update the automated test suite as said in Bug #9130#note-26, which I’ll do as part of the review… unless Kill Your TV is faster.
2. Merge into the feature/gtk3 branch (Feature #8980), and adapt => kurono, if you want to give it a try, feel free!

#30 Updated by intrigeri 2015-07-09 12:00:13

• Feature Branch changed from kurono:feature/9130-tails-installer-notify-on-small-device to kurono:feature/9130-tails-installer-notify-on-smal-device

#31 Updated by intrigeri 2015-07-09 23:05:23

• Assignee changed from intrigeri to kytv
• % Done changed from 50 to 60

intrigeri wrote:
> Code looks good. Next steps are:
>
> Update the automated test suite as said in Bug #9130#note-26, which I’ll do as part of the review… […]

Done. Kill Your TV, please review+test feature/9130-tails-installer-notify-on-smal-device in the main Tails repo, and then reassign to me for merging.

> Merge into the feature/gtk3 branch (Feature #8980), and adapt => kurono, if you want to give it a try, feel free!

Any taker, please file a subtask of Feature #8980 for it, otherwise I’ll do it.

#33 Updated by kytv 2015-07-17 11:05:14

• Assignee changed from kytv to intrigeri
• QA Check changed from Ready for QA to Pass

Test code review passes and the test works as intended.

=> MERGE!

#34 Updated by intrigeri 2015-07-18 03:31:32

• Status changed from In Progress to Fix committed
• % Done changed from 60 to 100

Applied in changeset commit:c3285bd33bcb99479c8485b066a177358cc202cc.

#35 Updated by intrigeri 2015-07-18 03:31:49

• related to Feature #9734: Tails Installer should notify when too small USB drives are not listed on gtk3 added

#36 Updated by intrigeri 2015-07-18 03:32:16

• Assignee deleted (intrigeri)

#37 Updated by intrigeri 2015-08-03 10:07:47

• related to Bug #9886: Tails Installer should not raise an exception when a too small USB drive is detected added

#39 Updated by BitingBird 2015-08-11 10:46:47

• Status changed from Fix committed to Resolved