Tails

#1 Updated by intrigeri 2015-07-16 06:39:04

• Status changed from New to Confirmed
• Affected tool set to Installer

#2 Updated by kurono 2015-07-16 09:13:54

• Assignee deleted (kurono)
• QA Check set to Ready for QA
• Feature Branch set to kurono:feature/jessie

Ok, the change was done in this branch:
https://git-tails.immerda.ch/kurono/liveusb-creator/log/?h=feature/jessie
Finally I decided to remove the exception since an user can have several devices
conected and it does not make sense to completely stop the installer only because one of them
is small.

#3 Updated by intrigeri 2015-07-17 01:55:49

• Status changed from Confirmed to In Progress

#4 Updated by intrigeri 2015-07-18 03:31:49

• related to Bug #9130: Tails Installer should notify when too small USB drives are not listed added

#5 Updated by intrigeri 2015-07-18 04:47:05

• Assignee set to kurono
• % Done changed from 0 to 20
• QA Check changed from Ready for QA to Info Needed

kurono wrote:
> Ok, the change was done in this branch:
> https://git-tails.immerda.ch/kurono/liveusb-creator/log/?h=feature/jessie

Yay!

> Finally I decided to remove the exception since an user can have several devices
> conected and it does not make sense to completely stop the installer only because one of them
> is small.

Full ack. But then, why would this be done on feature/jessie, and not on the master branch (Bug #9130) as well? I feel stupid to notice that only after having merged your branch for Bug #9130, so if you agree this should be done in current Tails (Wheezy) as well, may you please try to do that in time for 1.5?

#6 Updated by kurono 2015-07-21 12:47:14

• Assignee deleted (kurono)
• QA Check changed from Info Needed to Ready for QA

ok, I will pay attention the next time :)
this is done.

#7 Updated by intrigeri 2015-08-03 07:41:01

• Assignee set to intrigeri

#8 Updated by intrigeri 2015-08-03 08:54:12

• Assignee changed from intrigeri to kurono
• QA Check changed from Ready for QA to Info Needed

kurono wrote:
> ok, I will pay attention the next time :)
> this is done.

In which branch? I understand that your changes for Jessie are in your feature/jessie branch, but I’ve no idea where you did the same work for Wheezy.

#9 Updated by kurono 2015-08-03 09:33:01

• Assignee changed from kurono to intrigeri
• QA Check changed from Info Needed to Ready for QA

For Wheezy the changes were done in the wheezy branch,
https://git-tails.immerda.ch/kurono/liveusb-creator/commit/?h=feature/9130-tails-installer-notify-on-smal-device&id=244f46fef438d594d8550126d22c9fc4118a6d90

https://labs.riseup.net/code/issues/9130

#10 Updated by intrigeri 2015-08-03 10:05:25

• Assignee changed from intrigeri to kurono
• QA Check changed from Ready for QA to Info Needed

It seems that one of us (possibly me) is a bit confused.

> For Wheezy the changes were done in the wheezy branch,
> https://git-tails.immerda.ch/kurono/liveusb-creator/commit/?h=feature/9130-tails-installer-notify-on-smal-device&id=244f46fef438d594d8550126d22c9fc4118a6d90

> https://labs.riseup.net/code/issues/9130

Sure, but the branch that’s been merged into master for Bug #9130 contained commit dc010dd (that disappeared from your branch since then, apparently). That commit raises an exception when a too small device is detected. The thing is, removing that commit from your branch after it has been merged didn’t revert it in our master branch. And since then, as discussed on this very ticket we’ve changed our mind and decided that no such exception should be raised. So, what we need for Tails 1.5 is a branch that reverts said commit, no?

#11 Updated by intrigeri 2015-08-03 10:06:08

• Description updated

#12 Updated by intrigeri 2015-08-03 10:07:59

• related to Bug #9886: Tails Installer should not raise an exception when a too small USB drive is detected added

#13 Updated by intrigeri 2015-08-03 10:09:27

• Assignee changed from kurono to intrigeri
• QA Check changed from Info Needed to Ready for QA

I’ve created Bug #9886 to track the need for a Wheezy-specific fix for the UX regression (exception raised instead of merely notifying the user) introduced in the branch for Bug #9130.

So, we can now re-focus this ticket on what it’s really about, which is the GTK3 version :)

#14 Updated by intrigeri 2015-08-03 10:13:54

• Target version changed from Tails_1.5 to Tails_1.6

With my recent “discovery” that I should have put a RC out two days ago, I won’t have time to review this branch (and in particular, to update the test suite accordingly) before 1.5. Sorry!

#17 Updated by intrigeri 2015-08-04 03:21:18

• Status changed from In Progress to Resolved
• Assignee deleted (intrigeri)
• % Done changed from 20 to 100
• QA Check changed from Ready for QA to Pass

Merged! Not built a new .deb, though.