Feature #6811

Add Tails Greeter option for disabling networking

Added by sajolida 2014-03-02 17:40:02 . Updated 2020-04-15 06:05:27 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_1.7
Start date:
2014-05-11
Due date:
% Done:

100%

Feature Branch:
tails:feature/6811-disable-networking greeter:feature/6811-disable-networking
Type of work:
Code
Blueprint:

Starter:
0
Affected tool:
Welcome Screen
Deliverable for:

Description

As a side effect on the work on MAC spoofing, it is now relatively easy to start Tails with no network module enabled. This could be proposed as an offline mode.

Files

greeter-with-disable-network.png (89856 B) anonym, 2015-09-01 10:18:07

Subtasks

Bug #7219: Having a disable Wi-Fi option at Greeter Rejected

0
Feature #10126: Write user docs for the Greeter's "Disable Networking" option Resolved

100
Feature #10128: Update automated test suite vs the Greeter's "Disable networking" option Resolved

100

Related issues

Related to Tails - Feature #6260: Offline additional software Duplicate 2013-09-07
Related to Tails - Bug #7165: NetworkManager autoconnects to persistent wireless networks In Progress 2014-07-20
Related to Tails - Bug #11593: Network disabling does not always work Resolved 2016-07-22

History

#1 Updated by BitingBird 2014-04-03 14:38:17

#2 Updated by BitingBird 2014-05-09 18:14:55

#3 Updated by BitingBird 2014-05-09 18:15:21

#4 Updated by intrigeri 2014-05-10 01:41:55

#5 Updated by intrigeri 2014-06-11 12:41:20

  • related to Bug #7165: NetworkManager autoconnects to persistent wireless networks added

#6 Updated by BitingBird 2015-01-02 18:05:37

  • Status changed from Confirmed to In Progress

#7 Updated by intrigeri 2015-05-31 13:58:35

  • Status changed from In Progress to Confirmed

There’s been work on that >1 year ago, but nothing since then, so we can hardly call it “in progress” today.

#8 Updated by anonym 2015-08-31 03:39:10

  • Feature Branch changed from feature/disable-networking to greeter:feature/disable-networking

#9 Updated by anonym 2015-08-31 05:14:08

  • Description updated
  • Status changed from Confirmed to In Progress
  • Feature Branch changed from greeter:feature/disable-networking to greeter:feature/6811-disable-networking

intrigeri wrote:
> There’s been work on that >1 year ago, but nothing since then, so we can hardly call it “in progress” today.

I refreshed the branch and improved it slightly. AFAICT it works well, but there are a few more things to do before it’s ready for merging…

#10 Updated by anonym 2015-08-31 06:07:33

  • Feature Branch changed from greeter:feature/6811-disable-networking to greeter:feature/6811-disable-networking-improved

Actually, there’s a better and simpler way to do this by grouping the option in the radio button section for the Tor configuration options (pushed into a new branch). Heh, I think this was the original plan, but I blindly updated the old branch where it was done differently, as a separate option.

#11 Updated by intrigeri 2015-09-01 01:13:49

> AFAICT it works well,

Congrats! :)

> but there are a few more things to do before it’s ready for merging…

If you have time to list what those things are (as a comment or sub-tasks, I see you’ve started the latter), it might allow someone else to complete this work. I guess we e.g. need some design doc update, no idea what else.

#12 Updated by anonym 2015-09-01 03:25:08

intrigeri wrote:
> > but there are a few more things to do before it’s ready for merging…
>
> If you have time to list what those things are (as a comment or sub-tasks, I see you’ve started the latter), it might allow someone else to complete this work. I guess we e.g. need some design doc update, no idea what else.

Done (I had just forgotten to set the parent of Feature #10128). I’ll prepare a package and prepare a Tails Git branch so people (and the automated test suite) can test it.

#13 Updated by sajolida 2015-09-01 07:08:58

I’m really excited to see this moving on! Can you send me a screenshot of the new option in the Greeter, so that I can check the wording, UI, and write the doc?

#14 Updated by anonym 2015-09-01 07:22:56

sajolida wrote:
> I’m really excited to see this moving on! Can you send me a screenshot of the new option in the Greeter, so that I can check the wording, UI, and write the doc?

I think a description will suffice: it’s just another radio button in the “Network configuration” section. It’s added below the existing two ones, and its wording is: “Disable all networking”. That’s it! :)

#15 Updated by anonym 2015-09-01 10:16:44

  • Subject changed from Propose an offline mode to Add Tails Greeter option for disabling networking

#16 Updated by anonym 2015-09-01 10:19:47

anonym wrote:
> sajolida wrote:
> > I’m really excited to see this moving on! Can you send me a screenshot of the new option in the Greeter, so that I can check the wording, UI, and write the doc?
>
> I think a description will suffice: it’s just another radio button in the “Network configuration” section. It’s added below the existing two ones, and its wording is: “Disable all networking”. That’s it! :)

Whatever, here’s a screenshot. At least at my vertical resolution (900) this unfortunately introduces the scroll bar since the window becomes too tall :/.

#17 Updated by anonym 2015-09-01 10:26:14

anonym wrote:
> At least at my vertical resolution (900) this unfortunately introduces the scroll bar since the window becomes too tall :/.

Pushed a fix for this.

#18 Updated by anonym 2015-09-01 10:29:17

  • Feature Branch changed from greeter:feature/6811-disable-networking-improved to tails:feature/6811-disable-networking greeter:feature/6811-disable-networking-improved

Ok, I’ve pushed a Tails branch with an updated Greeter package that you can build and test if you like.

#19 Updated by anonym 2015-09-01 10:29:38

  • Feature Branch changed from tails:feature/6811-disable-networking greeter:feature/6811-disable-networking-improved to tails:feature/6811-disable-networking greeter:feature/6811-disable-networking

#20 Updated by sajolida 2015-09-02 05:41:06

> It’s added below the existing two ones, and its wording is: “Disable all networking”.

I see. What about “Disable networking”? Or do you think “all” is really
needed here?

#21 Updated by anonym 2015-09-02 06:40:38

  • Assignee set to sajolida
  • Target version set to Tails_1.7
  • QA Check set to Info Needed

sajolida wrote:
> > It’s added below the existing two ones, and its wording is: “Disable all networking”.
>
> I see. What about “Disable networking”? Or do you think “all” is really
> needed here?

I don’t really care, but we already say “Spoof all MAC addresses” in another option. Also, the “all” makes the wording more future-proof if we ever want to provide options for only disabling e.g. WiFi, WAN or other wireless technologies.

Your call, it’s of course trivial for me to fix.

Also, let’s try to get this into the next major Tails release!

#22 Updated by sajolida 2015-09-03 04:51:25

  • Assignee deleted (sajolida)

You have good arguments, while I don’t. So let’s keep “Disabled all networking” as you are proposing :)

#23 Updated by BitingBird 2015-09-22 15:40:09

  • Assignee set to anonym
  • QA Check deleted (Info Needed)

Answer has been provided -> removing “info needed”. Reassigning to anonym to determine the next step.

#24 Updated by anonym 2015-10-06 03:47:43

  • Assignee changed from anonym to alant
  • QA Check set to Ready for QA

All looks good to me, so what remains is a review of my code, and an automated test. If Feature #6302 (which the automated tests will depend on) is not resolved for 1.7, we may want to ship this feature without the automated test. It’s not like we’re in a position where we can be very strict with “no test, no merge” yet. :)

alan, could you please review my code, i.e. greeter:feature/6811-disable-networking?

#25 Updated by anonym 2015-10-20 03:24:29

  • Assignee changed from alant to bertagaz

anonym wrote:
> All looks good to me, so what remains is a review of my code, and an automated test. If Feature #6302 (which the automated tests will depend on) is not resolved for 1.7, we may want to ship this feature without the automated test. It’s not like we’re in a position where we can be very strict with “no test, no merge” yet. :)

Seeing as things are moving slowly for Feature #6302, can we agree that skipping the automated tests in 1.7 is ok? I’d rather see kytv focus on Icedove too.

> alan, could you please review my code, i.e. greeter:feature/6811-disable-networking?

Doesn’t seem like it. bert, would you like to procrastinate on this? :)

#26 Updated by bertagaz 2015-10-20 04:07:03

anonym wrote:
> anonym wrote:
> > All looks good to me, so what remains is a review of my code, and an automated test. If Feature #6302 (which the automated tests will depend on) is not resolved for 1.7, we may want to ship this feature without the automated test. It’s not like we’re in a position where we can be very strict with “no test, no merge” yet. :)
>
> Seeing as things are moving slowly for Feature #6302, can we agree that skipping the automated tests in 1.7 is ok? I’d rather see kytv focus on Icedove too.

I agree if we somehow keep track somewhere (a ticket I guess) that we will need to write tests for that feature. We may need to add that to the manual test suite meanwhile too, if we think it will take more than one release to have this tests merged.

> > alan, could you please review my code, i.e. greeter:feature/6811-disable-networking?
>
> Doesn’t seem like it. bert, would you like to procrastinate on this? :)

Can try to commit on that. Alan, if you still find time to review, don’t hesitate to steal it to me. :)

#27 Updated by intrigeri 2015-10-20 04:27:36

> Alan, if you still find time to review, don’t hesitate to steal it to me. :)

FYI, I doubt Alan will see this comment.

#28 Updated by bertagaz 2015-10-24 09:24:48

  • Assignee changed from bertagaz to anonym
  • QA Check changed from Ready for QA to Info Needed

anonym wrote:
> Doesn’t seem like it. bert, would you like to procrastinate on this? :)

I had a look and build it, first feedback is that it seems that the branch is not up-to-date compared to the package.

The branch claims that its head is at 3666970 with a commit 96391e6 that contains a typo (obtacle), while the package that is in the Tails APT repo for that branch is build on commit @75b9404705bc6677dea52d4657700c56405896a6, which doesn’t exists.

The typo is not present in this package, so I suspect that it’s just an update to this package that has not been pushed to the Git repo.

I’ve run manual tests of this functionality, melting it with others options like mac spoofing (enabled/disabled), and think it’s working. I’m running the automated test on it now.

I think it’s ready to be merged (we’ll see with the automated tests result), but this Git repo weirdness needs to be fixed first, so that I can have a look at the real patches to the greeter.

#29 Updated by bertagaz 2015-10-25 03:07:15

bertagaz wrote:
> I’m running the automated test on it now.

Done. Goes fine, so with the manual tests I’ve run I think this branch is ready.

> I think it’s ready to be merged (we’ll see with the automated tests result), but this Git repo weirdness needs to be fixed first, so that I can have a look at the real patches to the greeter.

This is the only blocker for me to merge this branch.

#30 Updated by anonym 2015-10-26 02:32:06

  • QA Check changed from Info Needed to Ready for QA

bertagaz wrote:
> The branch claims that its head is at 3666970 with a commit 96391e6 that contains a typo (obtacle), while the package that is in the Tails APT repo for that branch is build on commit @75b9404705bc6677dea52d4657700c56405896a6, which doesn’t exists.

Yeah, it had a few other issues too. The correct commit has been force pushed now.

> This is the only blocker for me to merge this branch.

Yay! I think I’ll end up merging this myself since I’m gonna build a Greeter .deb for 1.7~rc1 soon so it should be done ASAP. The 3666970..75b9404 diff is pretty safe.

#31 Updated by bertagaz 2015-10-26 05:31:07

  • QA Check changed from Ready for QA to Pass

anonym wrote:
> bertagaz wrote:
> > The branch claims that its head is at 3666970 with a commit 96391e6 that contains a typo (obtacle), while the package that is in the Tails APT repo for that branch is build on commit @75b9404705bc6677dea52d4657700c56405896a6, which doesn’t exists.
>
> Yeah, it had a few other issues too. The correct commit has been force pushed now.

Code sounds good to me, so if it is the same code than the package I’ve tested (the one actually in the feature branch APT repo), it’s ready to be merged IMO.

> > This is the only blocker for me to merge this branch.
>
> Yay! I think I’ll end up merging this myself since I’m gonna build a Greeter .deb for 1.7~rc1 soon so it should be done ASAP. The 3666970..75b9404 diff is pretty safe.

Ok, if you take care of this merge and of the deb package that’d be nice, so that I can keep on focusing on the icedove feature branch review. I plan to post the result of my investigation on this real soon.

#32 Updated by anonym 2015-10-26 13:01:12

  • Status changed from In Progress to Fix committed
  • % Done changed from 75 to 100

Applied in changeset commit:9a25bd07df10d439fb48b94beddab0ef558a0df3.

#33 Updated by anonym 2015-10-26 16:04:33

  • Assignee deleted (anonym)

#34 Updated by anonym 2015-11-23 04:57:44

#35 Updated by anonym 2015-11-23 04:58:00

  • Status changed from Fix committed to Resolved

#36 Updated by intrigeri 2016-07-22 11:28:36

  • related to Bug #11593: Network disabling does not always work added

#37 Updated by intrigeri 2020-04-15 06:05:27

  • Affected tool changed from Greeter to Welcome Screen