Tails

#1 Updated by intrigeri 2017-11-08 15:09:14

• blocks Feature #13240: Core work 2017Q4: Test suite maintenance added

#2 Updated by intrigeri 2017-11-08 15:09:26

• related to Bug #14923: devel branch FTBFS since torbrowser-launcher 0.2.8-4 was uploaded added

#3 Updated by intrigeri 2017-11-10 14:16:34

• Target version changed from Tails_3.3 to Tails_3.5

#5 Updated by intrigeri 2018-01-01 16:56:51

• blocked by deleted (Feature #13240: Core work 2017Q4: Test suite maintenance)

#6 Updated by intrigeri 2018-01-01 16:57:04

• blocks Feature #13240: Core work 2017Q4: Test suite maintenance added

#7 Updated by intrigeri 2018-01-01 16:57:48

• blocks Feature #13241: Core work: Test suite maintenance added

#8 Updated by intrigeri 2018-01-01 16:57:53

• blocked by deleted (Feature #13240: Core work 2017Q4: Test suite maintenance)

#10 Updated by anonym 2018-01-23 19:52:53

• Target version changed from Tails_3.5 to Tails_3.6

#11 Updated by anonym 2018-01-30 21:23:27

• Target version changed from Tails_3.6 to Tails_3.7

Since the banner was removed, this is now fixed. For now. So I’ll just post-pone this so it won’t happen again next time we do something similar.

> How about we look for the “Tor check” button instead?

Since it’s the Tor Browser we can use Dogtail, so I’ll probably do that.

#12 Updated by anonym 2018-01-30 21:24:42

• Subject changed from "The persistent Tor Browser directory is usable" test is broken by the fundraising campaign header to Future-proof the test suite vs future fundraising campaign headers
• Description updated

#13 Updated by intrigeri 2018-02-07 12:29:33

• Target version changed from Tails_3.7 to Tails_3.6

> Since the banner was removed, this is now fixed.

FYI Scenario: The persistent Tor Browser directory is usable fails for me here due to Bug #14962. I understand it’s not the same problem as the one this ticket was originally about, but nevertheless this scenario is still unusable to validate changes that affect the Tor Browser on the current devel branch and I think this should be fixed with a different timing than “before the next fundraising campaign” :)

#15 Updated by anonym 2018-02-20 15:17:45

• Status changed from Confirmed to In Progress
• Assignee changed from anonym to intrigeri
• % Done changed from 0 to 50
• QA Check set to Ready for QA
• Feature Branch set to test/14935-dogtailify-tor-browser

> intrigeri wrote:
> FYI Scenario: The persistent Tor Browser directory is usable fails for me here due to Bug #14962. I understand it’s not the same problem as the one this ticket was originally about, but nevertheless this scenario is still unusable to validate changes that affect the Tor Browser on the current devel branch and I think this should be fixed with a different timing than “before the next fundraising campaign” :)

Confirmed, and agreed. Fixed in the feature branch, please review’n’merge into stable! But the next step (And I can print the current page as "output.pdf"...) will fail due to Bug #15336.

#16 Updated by intrigeri 2018-02-21 10:42:33

• % Done changed from 50 to 60

Code review passes, testing.

#17 Updated by intrigeri 2018-02-21 11:04:28

• File TorBrowserSaveOutputFileSelected.png added
• File 00_14_26_The_persistent_Tor_Browser_directory_is_usable.png added
• Assignee changed from intrigeri to anonym
• QA Check changed from Ready for QA to Dev Needed

This fails for me:

  Scenario: The persistent Tor Browser directory is usable                                                        # features/torified_browsing.feature:129
    Given I have started Tails without network from a USB drive with a persistent partition enabled and logged in # features/step_definitions/snapshots.rb:172
    And the network is plugged                                                                                    # features/step_definitions/common_steps.rb:79
    And Tor is ready                                                                                              # features/step_definitions/common_steps.rb:347
    And available upgrades have been checked                                                                      # features/step_definitions/common_steps.rb:379
    And all notifications have disappeared                                                                        # features/step_definitions/common_steps.rb:441
    Then the persistent Tor Browser directory exists                                                              # features/step_definitions/common_steps.rb:688
    And there is a GNOME bookmark for the persistent Tor Browser directory                                        # features/step_definitions/common_steps.rb:698
    When I start the Tor Browser                                                                                  # features/step_definitions/common_steps.rb:385
    And I open the address "https://tails.boum.org/about" in the Tor Browser                                      # features/step_definitions/browser.rb:66
    And I can save the current page as "index.html" to the persistent Tor Browser directory                       # features/step_definitions/common_steps.rb:742
      FindFailed: TorBrowserSaveOutputFileSelected.png: (50x34) seen at (203, 97) with 0.79 in S(0)[0,0 1024x768] E:Y, T:3.0
        Line 2757, in file Region.java
       (RuntimeError)
      features/torified_browsing.feature:139:in `And I can save the current page as "index.html" to the persistent Tor Browser directory'

I’m attaching the sikuli candidate.

I think that “the Tor Browser loads the startup page” waited long enough for the page title to be loaded, while “I open the address” does not necessarily (Bug #11592), which can be noticed with a slow enough Internet connection such as mine. This looks like a race condition since on the failure screenshot we can see the proper title in the window titlebar. Maybe workaround this (that is, probably <=> workaround Bug #11592) by adding "Tails - About" has loaded in the Tor Browser?

#18 Updated by anonym 2018-02-26 10:52:34

• Priority changed from Normal to Elevated

I’ll try to finish this one before bert imports the next Tor Browser (i.e. around March 9).

#19 Updated by bertagaz 2018-03-14 11:32:27

• Target version changed from Tails_3.6 to Tails_3.7

#20 Updated by anonym 2018-04-06 11:45:41

• Assignee changed from anonym to intrigeri
• QA Check changed from Dev Needed to Ready for QA

I merged in stable and resolved the conflicts, which fixes you issue in Bug #14935#note-17.

#22 Updated by intrigeri 2018-04-10 06:44:47

• Status changed from In Progress to Fix committed
• % Done changed from 60 to 100

Applied in changeset commit:0241795ebf2350adb35caf0ef0e021f2f454edb8.

#23 Updated by intrigeri 2018-04-10 06:45:38

• Assignee deleted (intrigeri)
• QA Check changed from Ready for QA to Pass

#24 Updated by bertagaz 2018-05-10 10:59:50

• Status changed from Fix committed to Resolved