Bug #15336

"The persistent Tor Browser directory is usable" test suite scenario is fragile

Added by anonym 2018-02-20 14:40:33 . Updated 2019-08-30 12:19:10 .

Status:
In Progress
Priority:
Normal
Assignee:
anonym
Category:
Test suite
Target version:
Start date:
2018-02-20
Due date:
% Done:

10%

Feature Branch:
test/15336-cannot-print-local-pages
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

I.e. we are still affected by Bug #15024, but when trying to print a local (“offline”) page.

Files

02_59_26_The_persistent_Tor_Browser_directory_is_usable (1).mkv (889777 B) intrigeri, 2018-04-14 19:11:35
debug.log (2072782 B) intrigeri, 2018-04-14 19:11:43

Subtasks

Related issues

Related to Tails - Bug #15024: Tor Browser cannot print to file Resolved 2017-12-08

History

#1 Updated by anonym 2018-02-20 14:40:44

  • related to Bug #15024: Tor Browser cannot print to file added

#2 Updated by anonym 2018-02-20 15:27:00

  • Assignee changed from anonym to intrigeri
  • Feature Branch set to bugfix/15336-cannot-print-local-pages

I found this issue while working on Bug #14935, which unblocked this error from being exposed. At first an image needed bumping, so I thought “let’s dogtailify instead”. Which I did (see feature branch) but it only exposes this real bug in Tor Browser. I’d like this merged even before this is fixed, since it kills 4 test suite images.

So, intrigeri, can you review’n’merge the feature branch into stable? If so, don’t close the ticket, just reassign it back to me for tracking of the real bug.

#3 Updated by intrigeri 2018-02-21 10:35:27

  • Assignee changed from intrigeri to anonym

The feature branch has one single commit, that deletes 3 images and that’s all. I doubt that’s what you want me to merge. Could you please check?

#4 Updated by anonym 2018-02-21 14:58:57

  • Status changed from Confirmed to In Progress

Applied in changeset commit:ca26d62a1c56710158803a6d294685eb5d2992e7.

#5 Updated by anonym 2018-02-26 10:55:09

  • Assignee changed from anonym to intrigeri
  • % Done changed from 0 to 50
  • QA Check set to Ready for QA

Not the branch is properly pushed.

#6 Updated by intrigeri 2018-02-26 11:27:20

  • Assignee changed from intrigeri to anonym
  • % Done changed from 50 to 0
  • QA Check deleted (Ready for QA)

Any reason to keep TorBrowserPrintDialog.png around? It seems it was used only by code your branch replaced.

Other than that, code review passes and I will now run the affected test.

#7 Updated by intrigeri 2018-02-26 11:29:13

  • QA Check set to Info Needed

#8 Updated by intrigeri 2018-02-26 11:31:13

> % Done changed from 0 to 50

I don’t think this reflects the status of this ticket: so far the only work we’ve done is refactoring the test case that exposes the bug but I don’t see progress towards fixing the actual bug. Next step is to report this bug upstream, right?

#9 Updated by intrigeri 2018-02-26 12:54:28

  • Status changed from In Progress to Confirmed
  • QA Check deleted (Info Needed)
  • Feature Branch deleted (bugfix/15336-cannot-print-local-pages)

Merged into stable and devel, but my comment wrt. TorBrowserPrintDialog.png is still valid. Feel free to fix directly in our release branches and then we can go back to the problem this ticket is about :)

#10 Updated by bertagaz 2018-03-14 11:32:29

  • Target version changed from Tails_3.6 to Tails_3.7

#11 Updated by intrigeri 2018-04-13 11:37:38

  • Subject changed from Tor Browser cannot print to file any local page to Tor Browser cannot print to file any local page
  • Assignee changed from anonym to intrigeri

#12 Updated by intrigeri 2018-04-14 08:25:11

intrigeri wrote:
> Merged into stable and devel, but my comment wrt. TorBrowserPrintDialog.png is still valid. Feel free to fix directly in our release branches […]

I’ve fixed this with commit:5f90c39ef157ff2c0b38633b770bb95861522fa1 on stable and devel.

#13 Updated by intrigeri 2018-04-14 09:01:52

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10
  • Feature Branch set to bugfix/15336-cannot-print-local-pages
  • Debian sid, fr_FR locales, tor-browser-linux64-7.5.3_en-US and tor-browser-linux64-7.5.3_fr: printing file:///usr/share/doc/debian/FAQ/ch-compat.en.html to a PDF works fine
  • Tails 3.6.2, fr_FR locales: I’ve saved the homepage to the Tor Browser directory, opened file:///home/amnesia/Tor%20Browser/Tails%20-%20Nouvelles.html in Tor Browser, and again printing it to a PDF works fine

=> looks like the problem is gone. I’ll run our relevant automated test and we’ll see how it goes.

#14 Updated by intrigeri 2018-04-14 09:02:42

#15 Updated by intrigeri 2018-04-14 19:09:36

Progress… somewhat. On my branch this passes:

And I open the address "file:///home/amnesia/Persistent/Tor Browser/index.html" in the Tor Browser
Then "Tails - About" has loaded in the Tor Browser

… but Tor Browser, despite having the right page name in the title bar, says “Gah. Your tab […]” (presumably “has crashed” but that’s hidden by the printing progress bar) and then the “I can print the current page as ”output.pdf" to the persistent Tor Browser directory" step fails.

The video shows that something “interesting” is happening: “I close the Tor Browser” has not closed Tor Browser. Instead, it displays a “Cancel All Downloads?” dialog that says “If you exit now, 1 download will be canceled”. This means that the “I can save the current page as ”index.html" to the persistent Tor Browser directory" step is buggy: it thinks it has succeeded a bit too early => commit:47df1d7fbde1a66402781df46d5b6491534f0cba might have improved some things but it does not work as well as planned. And then the “I start the Tor Browser” step just focusses the existing Tor Browser but for some reason, clicking the “new tab” icon opens a new window (perhaps because of the still open “Cancel All Downloads?” dialog?)

I’ll test this manually, bypassing test suite bugs, and if it works, I’ll close this bug and file a new one about the test suite robustness issue I’ve discovered.

#17 Updated by intrigeri 2018-04-15 07:08:35

  • Subject changed from Tor Browser cannot print to file any local page to "The persistent Tor Browser directory is usable" test suite scenario is fragile
  • Category set to Test suite
  • Assignee changed from intrigeri to anonym
  • QA Check set to Ready for QA
  • Feature Branch changed from bugfix/15336-cannot-print-local-pages to test/15336-cannot-print-local-pages

Tested manually, it works just fine, so I’m calling this a test suite robustness issue.

Please review’n’merge my branch since it clarifies the status of this test, but don’t close this ticket as the problem is still there.

#18 Updated by intrigeri 2018-04-15 07:09:16

  • blocked by deleted (Feature #15139: Core work 2018Q2: Foundations Team)

#19 Updated by bertagaz 2018-05-10 11:09:32

  • Target version changed from Tails_3.7 to Tails_3.8

#20 Updated by intrigeri 2018-05-25 13:29:12

  • Target version changed from Tails_3.8 to Tails_3.9

#21 Updated by intrigeri 2018-08-07 07:30:55

  • Target version deleted (Tails_3.9)
  • QA Check deleted (Ready for QA)

Merged.

#22 Updated by intrigeri 2019-08-30 12:19:10

Over the last two months, this scenario failed only 3 times on Jenkins:

  • 2 × at Step: I start the Tor Browser
  • 1 × at Step: I can save the current page as “index.html” to the persistent Tor Browser directory