Feature #9958
Don't display the splash screen for LibreOffice in Windows Camouflage mode
50%
Description
Follow up to bug 5530. Patch is attached.
Files
Subtasks
Related issues
Copied from Tails - |
Rejected | ||
Copied to Tails - |
Rejected | 2015-08-09 |
History
#1 Updated by hybridwipe 2015-08-09 22:42:21
- copied from
Feature #5530: Don't display the splash screen for some applications in Windows Camouflage mode added
#2 Updated by hybridwipe 2015-08-09 23:53:20
- copied to
Feature #9959: Don't display the splash screen for Orca in Windows Camouflage mode added
#3 Updated by intrigeri 2015-08-26 04:16:00
- Assignee changed from intrigeri to anonym
- % Done changed from 0 to 20
(Reassigning to the current RM.)
#4 Updated by hybridwipe 2015-10-07 08:37:01
Applied in changeset commit:79aa3eac3fa25e27960bc95e1691b6a939b6b702.
#5 Updated by anonym 2015-10-07 08:37:39
- % Done changed from 20 to 50
- Feature Branch set to feature/5530-disable-splash-screens-in-camouflage-mode
#6 Updated by anonym 2015-10-08 03:39:54
- Assignee changed from anonym to hybridwipe
- QA Check changed from Ready for QA to Dev Needed
Thanks for the patches! Some comments:
> dpkg-divert —add —rename —divert /usr/bin/soffice-real /usr/bin/soffice
>
> cat > /usr/bin/soffice <<_EOF
There’s also /usr/bin/libreoffice
, which is what all the .desktop
files use (see grep ^Exec /usr/share/applications/libreoffice-*.desktop
) so your wrapper is not called when starting Libreoffice via the Gnome Applications menu. In fact, both /usr/bin/{soffice,libreoffice}
are just symlinks to /usr/lib/libreoffice/program/soffice
, so that is probably the correct file to wrap.
> /usr/bin/soffice-real —no-logo “\$@”
The correct option seems to be --nologo
. Also, for these kind of wrappers (where nothing happens after calling the wrapped application), please use exec
so we do not leave a shell behind.
#7 Updated by anonym 2015-10-08 03:41:06
Also, when generating patches to send to us, please use git format-patch
. Thanks!
#8 Updated by hybridwipe 2015-10-19 04:25:16
- File deleted (
win8_libreoffice_camo.txt)
#9 Updated by hybridwipe 2015-10-19 04:25:42
Thanks for the review. This version should address your concerns.
#10 Updated by intrigeri 2015-12-14 09:43:03
Sadly, due to the ticket metadata not having been updated, this was not reviewed. hybridwipe, please give https://tails.boum.org/contribute/merge_policy/#submit a good read so we avoid such sad situations in the future :)
And Tails 2.0 won’t have a camouflage mode, so I have to reject this ticket.
#11 Updated by intrigeri 2015-12-14 09:43:24
- Status changed from In Progress to Rejected