Feature #5530
Don't display the splash screen for some applications in Windows Camouflage mode
50%
Description
Improvement for Windows Camouflage:
- add
--no-splash
startup setting to those applications: scribus, gimp
Files
Subtasks
Related issues
Related to Tails - |
Rejected | 2014-04-24 | |
Copied to Tails - |
Rejected | 2015-08-09 |
History
#1 Updated by intrigeri 2013-09-04 03:27:00
- Priority changed from Normal to Low
- Starter set to No
#2 Updated by BitingBird 2014-06-09 12:12:10
- related to
Feature #6342: Update Windows camouflage for GNOME3 added
#3 Updated by BitingBird 2014-06-09 12:12:23
- Subject changed from improve Windows Camouflage to Improve Windows Camouflage
#4 Updated by alant 2014-06-10 05:20:23
> easy-to-access shutdown button
Done
> add a shortcut to the desktop in the bottom panel
This wouldn’t look like win8
> add —no-splash startup setting to those applications: scribus, inkscape (?)
Please create a specific ticket for that one.
#5 Updated by alant 2014-06-10 05:22:03
- related to deleted (
)Feature #6342: Update Windows camouflage for GNOME3
#6 Updated by alant 2014-06-10 05:22:27
- related to
Feature #7377: Improve Windows 8 camouflage added
#7 Updated by BitingBird 2014-06-10 07:23:22
- Subject changed from Improve Windows Camouflage to Windows Camouflage: add @--no-splash@ startup setting to some applications
- Description updated
I changed the title and description, since the ticket had no other interest anymore.
#8 Updated by intrigeri 2014-06-10 09:54:46
- Subject changed from Windows Camouflage: add @--no-splash@ startup setting to some applications to Don't display the splash screen for some applications
#9 Updated by intrigeri 2014-06-10 13:02:19
- Subject changed from Don't display the splash screen for some applications to Don't display the splash screen for some applications in Windows Camouflage mode
#10 Updated by anonym 2014-06-11 16:45:58
- Category set to Camouflage
#11 Updated by hybridwipe 2015-07-07 17:34:50
Using tails 1.4.1, I tested a few apps:
gimp: splash is shown, but suppressed with —no-splash
inkscape: no splash is shown
scribus: splash is shown, but suppressed with —no-splash
I looked in the source but couldn’t find any reference to —no-splash or anything related for inkscape that I could replicate.
#12 Updated by BitingBird 2015-07-08 08:05:44
I asked hybridwipe to check without camouflage, and inkscape doesn’t have a splashscreen either. They probably removed it in a recent version.
#13 Updated by BitingBird 2015-07-08 08:07:05
- Description updated
removed inkscape from description, added gimp
#14 Updated by hybridwipe 2015-08-06 22:38:53
- File win8_no_splash.txt added
I’ve attached a patch for review. While it’s probably possible to change the icon in the application menu using gsettings or something else as user, that doesn’t prevent the user from running either program via the command line or some other GUI program and that option being ignored. Instead, I’ve opted to rename the executable to $executable-real and replace the original with a simple script that always sets —no-splash
#15 Updated by intrigeri 2015-08-07 02:20:39
- Status changed from Confirmed to In Progress
- Assignee set to hybridwipe
- QA Check set to Dev Needed
> I’ve attached a patch for review.
Thanks!
> While it’s probably possible to change the icon in the application menu using gsettings or something else as user, that doesn’t prevent the user from running either program via the command line or some other GUI program and that option being ignored. Instead, I’ve opted to rename the executable to $executable-real and replace the original with a simple script that always sets —no-splash
Makes sense to me. But the right way to replace files shipped by Debian packages is dpkg-divert
; you’ll find examples by git grep
’ing our source tree :)
Also:
- please quote everything that contains a variable for robustness
- please add
set -e
andset -u
for robustness
#16 Updated by hybridwipe 2015-08-07 14:05:50
- File win8_nosplash2.txt added
Thanks for the review, here’s a second patch with your changes incorporated.
#17 Updated by intrigeri 2015-08-07 14:19:23
- Assignee changed from hybridwipe to intrigeri
- QA Check changed from Dev Needed to Ready for QA
Thanks!
#18 Updated by intrigeri 2015-08-09 00:21:37
- Target version set to Tails_1.7
#19 Updated by hybridwipe 2015-08-09 22:42:20
- copied to
Feature #9958: Don't display the splash screen for LibreOffice in Windows Camouflage mode added
#20 Updated by intrigeri 2015-08-26 04:15:44
- Assignee changed from intrigeri to anonym
- % Done changed from 0 to 20
(Reassigning to the current RM.)
#21 Updated by hybridwipe 2015-10-07 08:37:01
Applied in changeset commit:cc744db8640049b8a93da08794940e981d104ba9.
#22 Updated by anonym 2015-10-07 08:37:36
- % Done changed from 20 to 50
- Feature Branch set to feature/5530-disable-splash-screens-in-camouflage-mode
#23 Updated by anonym 2015-10-08 04:06:55
Seems to work, but I think wrappers should call the wrapped application with exec
(see my comment on Feature #9958) but I can fix that later.
#24 Updated by hybridwipe 2015-10-28 09:04:12
Here’s a patch for exec.
#25 Updated by anonym 2015-11-23 04:39:04
- Target version changed from Tails_1.7 to Tails_1.8
#26 Updated by intrigeri 2015-12-05 13:37:51
- Status changed from In Progress to Rejected
- Assignee deleted (
anonym) - QA Check deleted (
Ready for QA)
Windows Camouflage mode was removed for Tails 2.0 (Jessie), so I’m sorry but I don’t think we’ll take this patch :/