Feature #9955

Localize the Wikipedia browser search engine plugin icons

Added by anonym 2015-08-08 11:06:19 . Updated 2015-08-11 10:43:23 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Internationalization
Target version:
Tails_1.5
Start date:
2015-08-08
Due date:
% Done:

100%

Feature Branch:
feature/9955-localize-wikipedia-searchplugin-icons
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Browser
Deliverable for:

Description

Files

wikipedia-icons.png (13150 B) anonym, 2015-08-08 14:36:27

Subtasks

History

#1 Updated by anonym 2015-08-08 11:06:29

#2 Updated by anonym 2015-08-08 11:18:10

  • Feature Branch set to feature/9951-reintroduce-esr38-search-bar

#3 Updated by anonym 2015-08-08 14:36:49

The current state of the branch generates icon where the lang code is almost impossible to read. I did some tweaking (will push to git soon), see attached file. IMHO that’s a pretty sweet result! :)

#4 Updated by anonym 2015-08-08 16:51:58

  • Assignee changed from anonym to kytv
  • Target version changed from Tails_1.6 to Tails_1.5
  • QA Check set to Ready for QA

Let’s give this a try! :)

#5 Updated by kytv 2015-08-09 04:56:55

I’ve reviewed the code and built an ISO from this branch.
Thoughts:

1. Impressive work! This turned out to be much, much easier to do than I thought it’d be.
2. It works. ☺ I tested “the proper way” by booting Tails into each of the supported languages. Each Wikipedia search plugin has the two-letter language code on top and it’s clear.

#6 Updated by anonym 2015-08-09 05:05:28

kytv wrote:
> I’ve reviewed the code and built an ISO from this branch.
> Thoughts:
>
> 1. Impressive work! This turned out to be much, much easier to do than I thought it’d be.
> 2. It works. ☺ I tested “the proper way” by booting Tails into each of the supported languages. Each Wikipedia search plugin has the two-letter language code on top and it’s clear.

And a clarification from IRC:

(13:32:39) anonym: KillYourTV: and you also tested that they issued their searches to the correct version of wikipedia?
(13:33:57) KillYourTV: Yes, and that Chutulu didn't make the search bar appear (with his über-tricky bit-swapping) in I2P-Browser

#7 Updated by anonym 2015-08-09 05:34:38

  • Status changed from Confirmed to In Progress

Applied in changeset commit:392eb593a2ff73472a7a25cc571c2a9c6462ccbd.

#8 Updated by anonym 2015-08-09 05:35:05

  • Status changed from In Progress to Confirmed
  • Feature Branch changed from feature/9951-reintroduce-esr38-search-bar to feature/9955-localize-wikipedia-searchplugin-icons

#9 Updated by anonym 2015-08-09 05:36:10

  • Assignee deleted (kytv)
  • % Done changed from 0 to 50
  • Parent task changed from Feature #9951 to Bug #9931
  • QA Check changed from Ready for QA to Pass

#10 Updated by kytv 2015-08-09 07:34:59

  • Status changed from Confirmed to In Progress

#11 Updated by anonym 2015-08-09 16:00:19

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:78e68491eaa608b64cddcfb007ed3d24300d010c.

#12 Updated by BitingBird 2015-08-11 10:43:23

  • Status changed from Fix committed to Resolved