Feature #9332
Test that notification-daemon is running
100%
Description
Subtasks
History
#1 Updated by kytv 2015-05-03 12:45:39
- Status changed from Confirmed to In Progress
Adding something like
step 'process "notification-daemon" is running'
to each step that looks for a desktop notification would make it clear that the notification was not displayed because of the bug in Bug #8686.
#2 Updated by kytv 2015-05-16 08:29:15
- % Done changed from 0 to 10
With what I have in my workspace:
And I log in to a new session # features/step_definitions/common_steps.rb:263
And the Tails desktop is ready # features/step_definitions/common_steps.rb:309
calling as root: . /usr/local/lib/tails-shell-library/tor.sh; tor_is_working
call returned: [1, "", ""]
calling as root: . /usr/local/lib/tails-shell-library/tor.sh; tor_is_working
call returned: [1, "", ""]
calling as root: . /usr/local/lib/tails-shell-library/tor.sh; tor_is_working
call returned: [0, "", ""]
calling as root: test -e /var/run/tordate/done
call returned: [0, "", ""]
calling as root: test -e /var/run/htpdate/success
call returned: [1, "", ""]
calling as root: test -e /var/run/htpdate/success
call returned: [1, "", ""]
calling as root: test -e /var/run/htpdate/success
call returned: [1, "", ""]
calling as root: test -e /var/run/htpdate/success
call returned: [1, "", ""]
calling as root: test -e /var/run/htpdate/success
call returned: [1, "", ""]
calling as root: test -e /var/run/htpdate/success
call returned: [0, "", ""]
And Tor is ready # features/step_definitions/common_steps.rb:335
calling as root: pidof -x -o '%PPID' notification-daemon
call returned: [1, "", ""]
Then I see the 'Tor is ready' notification # features/step_definitions/common_steps.rb:329
Process 'notification-daemon' is not running.
<false> is not true. (Test::Unit::AssertionFailedError)
./features/step_definitions/common_steps.rb:484:in `/^process "([^"]+)" is running$/'
./features/step_definitions/common_steps.rb:46:in `rescue in notification_helper'
./features/step_definitions/common_steps.rb:43:in `notification_helper'
./features/step_definitions/common_steps.rb:331:in `/^I see the 'Tor is ready' notification$/'
features/noti.feature:14:in `Then I see the 'Tor is ready' notification'
#3 Updated by kytv 2015-05-16 08:49:37
- Assignee changed from kytv to anonym
- QA Check set to Ready for QA
- Feature Branch set to kytv:test/9332-notification-daemon-running
#4 Updated by anonym 2015-05-26 15:12:25
- Assignee changed from anonym to kytv
- QA Check changed from Ready for QA to Dev Needed
I believe you have forgotten to push the branch.
I think doing this definitely makes sense. However, I am afraid that we will en up making the test suite a lot less “robust” for a few more months given that we have decided (IIRC) to not care about fixing the actual issue since it’s fixed in Jessie. Any way, push and I’ll give it a few complete runs. In the end, if it turns out to fail to many tests needlessly in Wheezy-based Tails, then we may temporarily just make it print a warning in case notification-daemon
isn’t running.
#5 Updated by kytv 2015-05-26 17:21:49
- Assignee changed from kytv to anonym
- QA Check changed from Dev Needed to Ready for QA
anonym wrote:
> I believe you have forgotten to push the branch.
Hmm.
$ git push cz
Everything up-to-date
And I see it at http://repo.or.cz/w/tails/kytv.git/shortlog/refs/heads/test/9332-notification-daemon-running
Passing back, hoping it’s visible.
#6 Updated by anonym 2015-05-27 06:47:45
kytv wrote:
> anonym wrote:
> > I believe you have forgotten to push the branch.
>
> Hmm.
>
> […]
>
> And I see it at http://repo.or.cz/w/tails/kytv.git/shortlog/refs/heads/test/9332-notification-daemon-running
>
> Passing back, hoping it’s visible.
My bad, my fetch failed and I didn’t notice it.
#7 Updated by anonym 2015-05-27 07:27:22
- Status changed from In Progress to Fix committed
- Assignee deleted (
anonym) - % Done changed from 10 to 100
- QA Check changed from Ready for QA to Pass
Ah! I like the idea to only check whether notification-daemon
is running if we fail to find some expected notification. That makes my concerns in Feature #9332#note-4 moot. Will merge!
#8 Updated by kytv 2015-05-27 07:27:40
- Status changed from Fix committed to In Progress
Applied in changeset commit:15c1278d49b0d4889335bb4349ab96157281d900.
#9 Updated by anonym 2015-05-27 07:27:41
- Status changed from In Progress to Fix committed
Applied in changeset commit:dc24a2bbd08176270b2eea02bd6f1142104104da.
#10 Updated by kytv 2015-05-27 18:42:01
anonym wrote:
> Ah! I like the idea to only check whether notification-daemon
is running if we fail to find some expected notification. That makes my concerns in Feature #9332#note-4 moot. Will merge!
Woohoo. (This was the best way that I could think of doing this.)
#11 Updated by intrigeri 2015-05-28 09:02:54
> anonym wrote:
>> Ah! I like the idea to only check whether notification-daemon
is running if we
>> fail to find some expected notification. That makes my concerns in Feature #9332#note-4
>> moot. Will merge!
> Woohoo. (This was the best way that I could think of doing this.)
Congrats!
#12 Updated by intrigeri 2015-07-03 03:40:40
- Status changed from Fix committed to Resolved