Feature #9143: Finish test for "Report an error" launcher

Feature #9143

Finish test for "Report an error" launcher

Added by anonym 2015-03-31 10:04:23 . Updated 2015-05-12 18:39:18 .

Status:

Resolved

Priority:

Normal

Assignee:

Category:

Test suite

Target version:

Tails_1.4

Start date:

2015-03-31

Due date:

% Done:

100%

Feature Branch:

kytv:test/9143-report-an-error

Type of work:

Code

Blueprint:

Starter:

Affected tool:

Deliverable for:

Description

We currently only automate the test in English, and not in “one language to which the website is translated”.

Subtasks

Related issues

Related to Tails - ~~Feature #6904~~: Write test for "Report an error" launcher

Resolved

2014-03-11

2015-06-01

History

#1 Updated by anonym 2015-03-31 10:04:49

blocks #8538 added

#2 Updated by intrigeri 2015-03-31 10:18:30

related to ~~Feature #6904~~: Write test for "Report an error" launcher added

#3 Updated by intrigeri 2015-03-31 10:18:44

blocked by deleted (~~#8538~~)

#4 Updated by intrigeri 2015-03-31 10:19:14

blocked by #8668 added

#5 Updated by intrigeri 2015-04-06 12:20:38

blocks deleted (~~#8668~~)

#6 Updated by intrigeri 2015-04-06 12:20:51

blocks #8668 added

#7 Updated by kytv 2015-04-20 20:19:47

Status changed from Confirmed to In Progress

#8 Updated by kytv 2015-04-20 22:14:35

Assignee changed from kytv to anonym
% Done changed from 0 to 30
QA Check set to Ready for QA
Feature Branch set to kytv:test/9143-report-an-error

This branch tests the “Report an Error” launcher in German, chosen because it’s at the top of the language list and should satisfy the manual test suite’s requirement…

* The "Report an error" desktop launcher should open the [[support]]
  page in one language to which the website is translated into
  (automate: [[!tails_ticket 9143]]).

…since German is one of the supported languages.

#9 Updated by anonym 2015-05-05 18:53:29

Assignee changed from anonym to kytv
% Done changed from 30 to 40
QA Check changed from Ready for QA to Dev Needed

-    desktop_started_picture = 'GnomeApplicationsMenu.png'
+    case @language
+    when "German"
+      desktop_started_picture = 'GnomeAnwendungenMenu.png'
+    else
+      desktop_started_picture = 'GnomeApplicationsMenu.png'
+    end
 end

I think this approach to supporting localized tests has a couple of issues:

It requires knowing German to know what that image is, and we normally assume that devs only have English in common.
Everywhere we want to support other languages, a similar case construct is needed, and it will grow with every language we support.

I suggest instead to initialize @language as the empty string (+ a comment stating that that default means “English”), and then reducing the above to:

  desktop_started_picture = "GnomeApplicationsMenu#{@language}.png"

(Which, btw, is what you already did in the the support documentation page opens in Tor Browser step)

#10 Updated by kytv 2015-05-05 22:37:32

Assignee changed from kytv to anonym
QA Check changed from Dev Needed to Ready for QA

You’re absolutely right, of course. Fixes pushed.

#11 Updated by kytv 2015-05-08 09:03:46

Applied in changeset commit:d7642da8e90c2107657cbefce2e792d5dc77fa75.

#12 Updated by kytv 2015-05-08 09:03:47

Applied in changeset commit:8c1e887da40948ac1f3e67086be7eb5dfc05b522.

#13 Updated by anonym 2015-05-08 09:03:48

Status changed from In Progress to Fix committed
% Done changed from 40 to 100

Applied in changeset commit:b936715aa17dbb9cc3ca7b5dc2af5ffbb13bb70b.

#14 Updated by anonym 2015-05-08 09:10:06

Assignee deleted (~~anonym~~)
QA Check changed from Ready for QA to Pass

#15 Updated by intrigeri 2015-05-08 10:47:34

Status changed from Fix committed to In Progress
Assignee set to anonym
QA Check changed from Pass to Info Needed

> Status changed from In Progress to Fix committed

I’m confused: TailsGreeterAnmeldenButton.png made its way into the testing branch, while you made it quite clear in ~~Feature #9143#note-9~~ why it shouldn’t have. Was that intended?