Feature #8640

Have the mirror pool dispatcher library audited

Added by intrigeri 2015-01-09 16:45:39 . Updated 2016-10-26 09:26:31 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Infrastructure
Target version:
Tails_2.7
Start date:
2016-05-10
Due date:
% Done:

100%

Feature Branch:
451f:mirror-pool-dispatcher/master
Type of work:
Communicate
Blueprint:

Starter:
Affected tool:
Deliverable for:
269

Description

Subtasks

Bug #11405: Test mirror pool dispatcher script in different browsers Resolved

100

Related issues

Blocked by Tails - Feature #8639: Write a mirror pool dispatcher script Resolved 2015-01-09 2016-04-15

History

#1 Updated by intrigeri 2015-01-09 16:45:54

  • blocked by Feature #8639: Write a mirror pool dispatcher script added

#2 Updated by intrigeri 2015-01-09 16:49:10

  • blocks Feature #8641: Have the mirror pool dispatcher script deployed on tails.b.o added

#3 Updated by Dr_Whax 2015-01-10 10:22:55

I can help out with this, maybe jvoisin is also interested in this.

#4 Updated by intrigeri 2015-01-10 15:26:36

> I can help out with this, maybe jvoisin is also interested in this.

Cool. Would be good to find someone who has a good knowledge of potential security pitfalls in PHP.

#5 Updated by intrigeri 2015-05-28 15:17:40

  • blocks #8668 added

#6 Updated by intrigeri 2015-05-28 15:18:16

  • Target version changed from Sustainability_M1 to Tails_2.2

#7 Updated by intrigeri 2015-08-02 09:56:55

  • Due date set to 2016-04-15

#8 Updated by Anonymous 2015-09-26 14:55:24

  • Subject changed from Have the server-side mirror pool dispatcher script audited to Have the mirror pool dispatcher script audited

We decided to implement this feature differently, changing the title accordingly.

#9 Updated by intrigeri 2016-02-13 15:47:28

  • blocked by deleted (Feature #8641: Have the mirror pool dispatcher script deployed on tails.b.o)

#10 Updated by Anonymous 2016-03-18 23:32:51

  • Target version changed from Tails_2.2 to Tails_2.3

#13 Updated by geb 2016-04-06 10:24:53

Hi,

The code looks great for me. If I may, I would like to do a few suggests, most (if not any) of them are cosmetic ones

  • max_weight, url_fallback and mirrors.json could be global variable wrote in CAPS on top of the code for readability.
  • getRandomMirrorUrlPrefix() could be split in two functions, one that generate the new array, one that select it.

* get(path) could maybe be avoided by using