Feature #8314

Jessie: integrate shutdown-helper extension with our translation system

Added by intrigeri about 10 years ago. Updated about 10 years ago.

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Internationalization
Target version:
Tails_1.6
Start date:
2014-11-26
Due date:
2015-10-15
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:
267

Description

Subtasks

History

#1 Updated by intrigeri about 10 years ago

  • Subject changed from Integrate shutdown-helper applet with our translation system to Integrate shutdown-helper extension with our translation system
  • Category set to Internationalization

#2 Updated by intrigeri about 10 years ago

  • blocks Feature #8315: Import existing translations of shutdown-helper extension added

#3 Updated by anonym about 10 years ago

  • Status changed from Confirmed to Resolved
  • Assignee deleted (anonym)

Done in commit 99db550.

#4 Updated by intrigeri about 10 years ago

  • Status changed from Resolved to In Progress
  • Assignee set to anonym
  • % Done changed from 0 to 50

Actually not, as discussed privately: the gettext domain is wrong, and the pot file name is cluttering the namespace.

#5 Updated by anonym about 10 years ago

I pushed fixes, but I can’t test them with the suggested method, i.e. orca. I’ve reopened Bug #8075.

#6 Updated by anonym about 10 years ago

  • blocked by Bug #8075: Orca crashes on Tails Jessie added

#7 Updated by anonym about 10 years ago

anonym wrote:
> I pushed fixes […]

That is commits 42edf46 and a57b237.

#8 Updated by intrigeri about 10 years ago

  • blocked by deleted (Feature #8315: Import existing translations of shutdown-helper extension)

#9 Updated by anonym about 10 years ago

  • blocks deleted (Bug #8075: Orca crashes on Tails Jessie)

#10 Updated by anonym about 10 years ago

Even with a working Orca, I cannot test this. Orca simply says nothing for these buttons, including the original ones, i.e. without the plugin. Is this an upstream GNOME bug? Overall, GNOME 3 seems like a huge step backwards in terms of accessibility; in my three minute test I found tons of GUI elements for which Orca says nothing at all, or says something only after they are pressed (how a blind user can find them in the first place is a mystery though).

#11 Updated by intrigeri about 10 years ago

> Overall, GNOME 3 seems like a huge step backwards in terms of accessibility

That’s not supposed to be the case, so I suspect something is wrong in our configuration.

> in my three minute test I found tons of GUI elements for which Orca says nothing at all, or says something only after they are pressed

Can you reproduce this on a non-Tails Jessie or sid system with the accessibility tools enabled?

#12 Updated by anonym about 10 years ago

intrigeri wrote:
> > in my three minute test I found tons of GUI elements for which Orca says nothing at all, or says something only after they are pressed
>
> Can you reproduce this on a non-Tails Jessie or sid system with the accessibility tools enabled?

It’s the same in up-to-date, completely default Debian Jessie, both in the default GNOME Shell, and in GNOME Classic. Switching to GNOME Flashback improves the situation a bit, mostly because more elements are text (like the user menu).

#13 Updated by intrigeri about 10 years ago

>> Can you reproduce this on a non-Tails Jessie or sid system with the accessibility tools enabled?

> It’s the same in up-to-date, completely default Debian Jessie, both in the default GNOME Shell, and in GNOME Classic.

Thanks. Do you want to check if there are Debian bugs, and if not report it, or would you rather avoid it?

#15 Updated by intrigeri about 10 years ago

BitingBird wrote:
> No relevant bugs in Debian (https://bugs.debian.org/cgi-bin/pkgreport.cgi?pkg=gnome-orca;dist=unstable).
>
> In upstream bug tracker no bug with the specific version, and in all versions I’m a bit lost: https://bugzilla.gnome.org/buglist.cgi?product=orca&bug_status=UNCONFIRMED&bug_status=NEW&bug_status=ASSIGNED&bug_status=REOPENED&version=unspecified

Thanks! I’ve filed Bug #8371 where this kind of information should go in the future.

#16 Updated by anonym about 10 years ago

  • Priority changed from Normal to Elevated

#17 Updated by anonym about 10 years ago

  • related to Bug #8371: Incomplete screen reader support in Jessie added

#18 Updated by anonym about 10 years ago

  • related to deleted (Bug #8371: Incomplete screen reader support in Jessie)

#19 Updated by anonym about 10 years ago

  • blocked by Bug #8371: Incomplete screen reader support in Jessie added

#20 Updated by intrigeri about 10 years ago

  • Subject changed from Integrate shutdown-helper extension with our translation system to Jessie: integrate shutdown-helper extension with our translation system
  • Due date set to 2015-10-15
  • Target version changed from Tails_2.0 to Tails_1.6

#22 Updated by intrigeri about 10 years ago

  • blocks #8668 added

#23 Updated by anonym about 10 years ago

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 50 to 100

So I ended up testing this by patching the applet like this:

--- a/config/chroot_local-includes/usr/share/gnome-shell/extensions/shutdown-helper@tails.boum.org/extension.js
+++ b/config/chroot_local-includes/usr/share/gnome-shell/extensions/shutdown-helper@tails.boum.org/extension.js
@@ -124,11 +124,11 @@ const Extension = new Lang.Class({
     },

     _onPowerOffClicked: function() {
-        Util.spawn(['sudo', '-n', 'poweroff'])
+        Util.spawn(['wall', _("Power Off")])
     },

     _onRestartClicked: function() {
-        Util.spawn(['sudo', '-n', 'reboot'])
+        Util.spawn(['wall', _("Restart")])
     }
 });


and then trying the “Power Off” button in a German session. In an open terminal I got “Ausschalten” through wall, so the translation integration works fine (it’s just that it seems like it’s useless since there’s no way users can actually see the translated text).

#25 Updated by anonym about 10 years ago

  • blocks deleted (Bug #8371: Incomplete screen reader support in Jessie)

#26 Updated by anonym about 10 years ago

  • Status changed from Fix committed to Resolved

#27 Updated by intrigeri about 10 years ago

> and then trying the “Power Off” button in a German session. In an open terminal I got “Ausschalten” through wall, so the translation integration works fine (it’s just that it seems like it’s useless since there’s no way users can actually see the translated text).

Congrats!