Bug #7450
Tails OpenPGP Applet is too easy to exit
100%
Description
Doing a double right-click on the applet closes it. This is a bit too easy to exit and quite harder to restore.
Subtasks
Related issues
|
Related to Tails - |
Duplicate | 2014-06-22 | |
|
Related to Tails - |
Resolved | 2014-11-26 | |
|
Has duplicate Tails - |
Duplicate | 2014-11-23 |
History
#1 Updated by intrigeri 2014-07-19 16:14:32
- related to
Feature #7433: Turn Tails OpenPGP Applet into a standalone application added
#2 Updated by intrigeri 2014-07-19 16:17:24
- Status changed from New to Confirmed
- Type of work changed from User interface design to Code
- Starter changed from No to Yes
Agreed. Turning this into a “Code” ticket, as just removing the “Exit” menu entry should be enough.
The code lives in config/chroot_local-includes/usr/local/bin/gpgApplet in the main Tails Git repository. It’s written in Perl, but the fix is likely to be easy, even without prior knowledge of Perl.
#3 Updated by nodens 2014-08-02 00:38:32
How about just moving the Exit down (invert Exit & About) ? One might want to close the applet.
#4 Updated by nodens 2014-08-02 00:41:07
- Assignee set to intrigeri
- QA Check set to Info Needed
Note : I’ll do it in the openpgp-applet repository, whether we choose to remove the exit menu or just move it.
#5 Updated by intrigeri 2014-08-02 10:13:45
> One might want to close the applet.
In the context of Tails, I thought we should just remove the Exit menu entry (it’s always possible to kill the process anyway). But, now that we have serious plans to upload this to Debian, I agree with you.
> How about just moving the Exit down (invert Exit & About) ?
That would be a good short-term improvement, I think, but probably not a real solution. I suggest adding a confirmation dialog.
#6 Updated by intrigeri 2014-08-02 10:14:38
- Assignee deleted (
intrigeri) - QA Check deleted (
Info Needed)
#7 Updated by sajolida 2014-08-02 10:27:55
> How about just moving the Exit down (invert Exit & About) ? One might want to close the applet.
Yeap, I think that would work!
#8 Updated by intrigeri 2014-11-24 13:20:40
- has duplicate
Feature #8293: Add gpgApplet to the Applications menu added
#9 Updated by nodens 2014-11-24 14:31:46
- Assignee set to nodens
#10 Updated by nodens 2014-11-24 15:18:13
- Status changed from Confirmed to In Progress
- Assignee deleted (
nodens) - % Done changed from 0 to 50
- QA Check set to Ready for QA
The short-term workaround is available in the bugfix/7450-too_easy_to_exit branch of nodens/openpgp-applet git repository, and should apply cleanly on current Tails’ version.
The longer-term solution (confirmation dialog) is quite easy to implement, but I’m unsure how to proceed, as current Tails’ version and the one in the nodens/openpgp-applet repository are starting to diverge (especially everywhere translated text is available).
How about using this workaround until the debian package (Feature #6507) is done and used in Tails ?
If that’s OK I’ll create a new bug for that (e.g Tails OpenPGP Applet : Add a confirmation dialog on exit).
Of course I could provide a patch for both versions but I’d rather spend time on other issues.
Cheers,
#11 Updated by intrigeri 2014-11-24 15:43:15
- Target version set to Tails_1.3
nodens wrote:
> The short-term workaround is available in the bugfix/7450-too_easy_to_exit branch of nodens/openpgp-applet git repository, and should apply cleanly on current Tails’ version.
Yay :)
> The longer-term solution (confirmation dialog) is quite easy to implement, but I’m unsure how to proceed, as current Tails’ version and the one in the nodens/openpgp-applet repository are starting to diverge (especially everywhere translated text is available).
>
> How about using this workaround until the debian package (Feature #6507) is done and used in Tails ?
Agreed.
> If that’s OK I’ll create a new bug for that (e.g Tails OpenPGP Applet : Add a confirmation dialog on exit).
Yes, please.
#12 Updated by nodens 2014-11-26 22:10:06
Done : Bug #8319
#13 Updated by intrigeri 2014-11-27 09:23:29
- related to
Bug #8319: OpenPGP Applet: Add a confirmation dialog on exit added
#14 Updated by nodens 2014-11-29 12:26:46
Note : the branch has been merged in the openpgp-applet repository to avoid future conflicts, but I won’t delete it until the fix is commited in main repository.
#15 Updated by nodens 2014-12-23 16:58:53
Applied in changeset commit:e511fc0cd00586a25dea8cfa58b506ed460504e3.
#16 Updated by alant 2014-12-23 18:10:20
- Feature Branch set to feature/7450-openpgp-applet-exit
Local test shows the patch works. I imported the commit to your repo and merged the feature branch in experimental so that we can actually test it in place.
#17 Updated by BitingBird 2015-01-04 17:39:31
- Affected tool set to OpenPGP Applet
#18 Updated by alant 2015-01-26 19:37:43
- Assignee set to alant
#19 Updated by Tails 2015-02-04 14:44:23
- Status changed from In Progress to Fix committed
- % Done changed from 50 to 100
Applied in changeset commit:59e32414e1816d98b2f5e73b3b072e19cc900d06.
#20 Updated by alant 2015-02-04 14:46:00
- Assignee deleted (
alant) - QA Check changed from Ready for QA to Pass
Merged, thanks!
#21 Updated by BitingBird 2015-02-24 22:50:32
- Status changed from Fix committed to Resolved
#22 Updated by tchou 2015-08-06 03:17:55
- Subject changed from Tails OpenPGP Applet is too easy to exit to Tails OpenPGP Applet is too easy to exit.
#23 Updated by tchou 2015-08-06 03:18:07
- Subject changed from Tails OpenPGP Applet is too easy to exit. to Tails OpenPGP Applet is too easy to exit