Bug #6902

Suboptimal size/placement of the Greeter's options window

Added by intrigeri 2014-03-11 15:33:26 . Updated 2020-04-15 06:05:28 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Tails_1.1
Start date:
2014-03-11
Due date:
% Done:

100%

Feature Branch:
bugfix/6902-wheezy-options-height
Type of work:
Code
Blueprint:

Starter:
0
Affected tool:
Welcome Screen
Deliverable for:

Description

On Wheezy, the “More options” window is displayed partly on top of the bottom panel (locales etc.), and take almost all available height of the screen. That’s with a 1366x768 display, so clearly this will be critical for smaller displays.

Subtasks

Related issues

Related to Tails - Bug #6882: The Greeter's "more options" screen does not fit in a 600px height display Resolved 2014-03-07

History

#1 Updated by intrigeri 2014-03-11 15:33:47

  • related to Bug #6882: The Greeter's "more options" screen does not fit in a 600px height display added

#2 Updated by intrigeri 2014-03-20 03:46:24

  • Assignee set to anonym
  • QA Check set to Info Needed

It’s better with the scrollbar thing (at least there’s no overlap and I can see all options), but there seems to be some suboptimal placement or size calculation occuring: the “more options” window seems to be centered vertically in the screen, without taking into account the bottom panel. If it was placed on top of the screen, it looks like it would fit entirely, and all options could be displayed without needing a scrollbar. That’s on a 1366x768 display.

anonym, could you please have a look? (Not to say you should fix it yourself, but at least guiding me a bit through the intended logics would be welcome :)

#3 Updated by intrigeri 2014-03-20 03:47:08

  • Subject changed from Misplaced and/or too big options window in the Greeter to Suboptimal size/placement of the Greeter's options window

#4 Updated by anonym 2014-03-21 15:36:02

  • Status changed from Confirmed to In Progress
  • Assignee changed from anonym to intrigeri
  • QA Check changed from Info Needed to Ready for QA
  • Feature Branch set to bugfix/6902-wheezy-options-height

intrigeri wrote:
> It’s better with the scrollbar thing (at least there’s no overlap and I can see all options), but there seems to be some suboptimal placement or size calculation occuring

See bugfix/6902-wheezy-options-height for a quick fix that is largely untested (only tested on a live system in 1024x768). I hope the commit messages are self-explanatory, so I won’t elaborate further here unless something is unclear.

#5 Updated by intrigeri 2014-03-22 13:49:42

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 0 to 100
  • QA Check changed from Ready for QA to Pass

Merged, thanks! Works for me in various resolutions.

#6 Updated by BitingBird 2014-07-22 22:50:35

  • Status changed from Fix committed to Resolved

#7 Updated by intrigeri 2020-04-15 06:05:28

  • Affected tool changed from Greeter to Welcome Screen