Bug #6882

The Greeter's "more options" screen does not fit in a 600px height display

Added by intrigeri 2014-03-07 17:13:49 . Updated 2020-04-15 06:05:20 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Tails_0.23
Start date:
2014-03-07
Due date:
% Done:

100%

Feature Branch:
feature/6882-scrollable-options
Type of work:
Code
Blueprint:

Starter:
0
Affected tool:
Welcome Screen
Deliverable for:

Description

The bottom of the more options window does not fit, and the login button is hidden.

Subtasks

Related issues

Related to Tails - Bug #6902: Suboptimal size/placement of the Greeter's options window Resolved 2014-03-11

History

#1 Updated by intrigeri 2014-03-07 17:14:16

#2 Updated by intrigeri 2014-03-11 15:33:47

  • related to Bug #6902: Suboptimal size/placement of the Greeter's options window added

#3 Updated by anonym 2014-03-13 13:24:50

  • Assignee changed from anonym to alant
  • QA Check set to Dev Needed
  • Feature Branch set to feature/6882-scrollabe-options

I’ve pushed a broken fix to Tails Greeter’s feature/6882-scrollabe-options branch. I’m too ignorant of GTK/glade/etc to make the added GtkScrollableWindow not collapse to its minimal height, so I’ll ask our in-house GTK expert to have a look. Without help I can’t commit to having this fixed for the 0.23 release.

#4 Updated by anonym 2014-03-13 16:02:15

  • Feature Branch changed from feature/6882-scrollabe-options to feature/6882-scrollable-options

Whoops, even the pushed branch was named wrong. It should be feature/6882-scrollable-options. Fixed in the repo now.

#5 Updated by intrigeri 2014-03-14 10:54:03

anonym wrote:
> so I’ll ask our in-house GTK expert to have a look.

I’m not sure Alan will have the bandwidth to look at it in due time. If not, I’ll try to have a look later today. anonym, what’s the deadline?

#6 Updated by intrigeri 2014-03-14 10:57:47

  • Status changed from Confirmed to In Progress

#7 Updated by intrigeri 2014-03-14 18:29:51

  • Status changed from In Progress to Confirmed
  • Assignee changed from alant to intrigeri
  • % Done changed from 0 to 20
  • QA Check changed from Dev Needed to Ready for QA

Proxying from IRC: anonym says it fixed it in a better way since then, and I should review it.

#8 Updated by intrigeri 2014-03-14 19:36:01

  • Assignee changed from intrigeri to anonym
  • % Done changed from 20 to 50

Reviewed, pushed an untested bugfix, reassigning to anonym for review’n’merge.

See details on tails-dev.

#9 Updated by intrigeri 2014-03-14 19:36:53

  • Category set to 165

#10 Updated by BitingBird 2014-03-14 19:41:19

  • Status changed from Confirmed to In Progress

#11 Updated by anonym 2014-03-17 11:20:41

  • Assignee changed from anonym to intrigeri

#12 Updated by intrigeri 2014-03-17 12:33:56

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

Merged into the greeter’s master branch, not updated the .deb though.

#13 Updated by anonym 2014-03-19 07:23:42

  • Status changed from Fix committed to Resolved

#14 Updated by intrigeri 2020-04-15 06:05:20

  • Affected tool changed from Greeter to Welcome Screen