Feature #5644: Test suite: always check for firewall leaks

Feature #5644

Test suite: always check for firewall leaks

Added by Tails 2013-07-18 07:43:56 . Updated 2015-02-24 22:51:56 .

Status:

Resolved

Priority:

Normal

Assignee:

Category:

Test suite

Target version:

Tails_1.3

Start date:

Due date:

% Done:

100%

Feature Branch:

test/7821-tor

Type of work:

Code

Blueprint:

Starter:

Affected tool:

Deliverable for:

Description

Should we check for firewall leaks in every scenario, or at least, in every scenario that involves the Internet?

If we want to fully replace the manual leak check we’ve been doing until now, yes, we do want this. I don’t see why we would not want this. Feel free to re-add a todo/discuss tag (and perhaps raise the discussion on tails-dev) if there’s some good reason I’ve missed that makes it worth discussing this any further. —intrigeri

Actually, we don’t want to do it for all features/scenarios involving the Internet (think about e.g. unsafe_browser.feature). Instead we could:

add a tag @uses_tor (which is relevant for other things, like retrying when Tor fails (~~Feature #5770~~)) to all features/scenarios that uses Tor.
add a Before('@uses_tor') hook that starts the sniffer, and a After('@uses_tor') hook that check for leaks.

Looks good. —intrigeri

We’d still keep the current firewall leak checker steps for the features and scenarios that need more control, like the firewall_leaks.feature:s anti-tests.

Implemented in branch test/firewall-check-tag (note: it depends on branch test/reorg being merged first). Once merged, please remove the following test (and sub-tests) from the manual test suite:

Verify that all destinations reached from an intensive Tails session are tor routers or authorities …

Subtasks

Related issues

Related to Tails - ~~Feature #7821~~: Automatic tests for Tor

Resolved

2014-08-26

History

#1 Updated by intrigeri 2013-07-18 13:57:26

Type of work changed from Qa to Code

#2 Updated by intrigeri 2013-07-27 10:37:32

Assignee set to intrigeri
Feature Branch set to test/firewall-check-tag
Starter set to No

#3 Updated by intrigeri 2013-07-27 11:15:37

Status changed from Confirmed to In Progress
Assignee changed from intrigeri to anonym
QA Check changed from Ready for QA to Dev Needed

Initial review emailed to tails-dev.

#4 Updated by anonym 2013-08-15 03:59:54

QA Check changed from Dev Needed to Ready for QA

Fixes pushed, also see thread on tails-dev.

#5 Updated by intrigeri 2013-10-04 07:32:42

% Done changed from 0 to 70
QA Check changed from Ready for QA to Dev Needed

Reviewed again (August 19). We’re almost there!

#6 Updated by intrigeri 2013-12-27 10:46:43

Has been discussed in the “Please review’n’merge test/firewall-check-tag” thread on tails-dev.
According to last review (August 19), a function lacks documentation, and then some commits should be squashed.