Feature #5770

Retry when tor fails

Added by Tails 2013-07-18 07:46:02 . Updated 2013-10-03 13:33:50 .

Status:
Rejected
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Start date:
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
0
Affected tool:
Deliverable for:

Description

Some scenarios uses the live Tor network, which is not entirely reliable, so we may get failing scenarios when in fact we just happened to pick a Tor circuit that’s too slow, or even one that’s broken but Tor fails to remedy the situation.

I’ve never experienced it yet, and I’ve run the test suite on pretty bad connections, so perhaps let’s just wait a while and see if this problem happens in practice, and then retag this ticket todo/code? —intrigeri

For this reason we should tag such scenarios with @uses_tor, and create an Around('@uses_tor') hook which re-tries those scenarios some number of times before actually failing it. That hook should retry only when it catches some custom exception (e.g. TorFailed) that we make steps throw whenever something that uses Tor times out, but it should not retry for other exceptions.


Subtasks


Related issues

Related to Tails - Bug #9478: How to deal with transient network errors in the test suite? Resolved 2015-05-27

History

#1 Updated by intrigeri 2013-10-03 13:32:39

  • Status changed from Confirmed to Rejected
  • Type of work changed from Discuss to Code
  • Starter set to No

If the need arises in the wild, we’ll reopen. In the meantime, let’s focus on problems we can experience more widely :)

#2 Updated by sajolida 2013-10-03 13:33:07

  • Category set to Test suite

#3 Updated by sajolida 2013-10-03 13:33:50

  • Subject changed from test suite: retry when tor fails to Retry when tor fails

#4 Updated by anonym 2015-05-27 07:05:19

  • related to Bug #9478: How to deal with transient network errors in the test suite? added