Bug #17426

“double-upgrades” after 4.1.1 → 4.2.1 (IUKv1)

Added by CyrilBrulebois 2020-01-11 18:28:50 . Updated 2020-01-11 19:04:50 .

Status:
Duplicate
Priority:
Urgent
Assignee:
intrigeri
Category:
Target version:
Start date:
Due date:
% Done:

0%

Feature Branch:
Type of work:
Research
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

(I would assume this is a duplicate of Bug #17425, but I hate to speculate, and I don’t want to mix everything in a single ticket if this ends up being caused by different things.)

Here’s another issue from the “tests are important, really” department, with this scenario:

  • install an old version of Tails, which contains an “upgrader v1”, from scratch (in my test: 4.1.1)
  • an upgrade to the published 4.2 is offered, which contains an “upgrader v2”
  • do not upgrade to 4.2
  • enable the test channel
  • an upgrade to the to-be-published-one-day-maybe 4.2.1 is offered
  • upgrade, reboot, verify the advertised version is 4.2.1 (/etc/os-release)
  • enable the test channel just to be on the safe side
  • the upgrade to 4.2.1 is offered again!

Subtasks


History

#1 Updated by intrigeri 2020-01-11 19:04:50

  • Status changed from Confirmed to Duplicate

> (I would assume this is a duplicate of Bug #17425,

I confirm it is a duplicate: the Upgrader blindly assumes that any upgrade path that’s proposed for the initially installed version actually contains an upgrade to a version that’s strictly newer than the currently running one. This assumption used to hold in the v1 scheme, but it is not true anymore in the v2 scheme (it’s only true when running version == initially installed version, i.e. when one runs a Tails that was never upgraded).

This bug explains both Bug #17425 and Bug #17426. The fix I’m working on is meant to address both instances of this problem simultaneously.

> but I hate to speculate, and I don’t want to mix everything in a single ticket if this ends up being caused by different things.)

Good thinking!