Bug #17163

"SSH is using the default SocksPort" test suite scenario is fragile

Added by intrigeri 2019-10-18 16:48:45 . Updated 2019-10-21 11:44:43 .

Status:
Resolved
Priority:
Elevated
Assignee:
segfault
Category:
Test suite
Target version:
Tails_4.0
Start date:
Due date:
% Done:

100%

Feature Branch:
test/17163-ssh-stream-isolation+force-all-tests
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

I’ve initially spotted this on Bug #16792, and then noticed that it affected all branches.
For example, this scenario failed 12 times in the last 16 test suite runs on the testing branch.
In every failed case, SSH immediately fails with “nc: connection failed, SOCKSv5 error: General SOCKS server failure”.

Interestingly, none of the scenarios in ssh.feature are affected, while they do almost the same thing. The main differences are:

  • In tor_stream_isolation.feature we have the “I monitor the network connections of SSH” CPU hog running. This might make it harder for tor to do its job.
  • In ssh.feature, we use retry_tor so we retry up to MAX_NEW_TOR_CIRCUIT_RETRIES (default: 10); while in tor_stream_isolation.feature we only try once.

In short, the fragile scenario runs in a context that makes it more likely to fail, and does not retry.

Subtasks

Related issues

Related to Tails - Bug #17013: The "is properly stream isolated" test suite mechanism is fragile Confirmed
Related to Tails - Bug #16792: Upgrade our Chutney fork Resolved
Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

History

#1 Updated by intrigeri 2019-10-18 16:49:01

  • related to Bug #17013: The "is properly stream isolated" test suite mechanism is fragile added

#2 Updated by intrigeri 2019-10-18 16:49:06

  • related to Bug #16292: On-screen keyboard not displayed in Buster when logged in in French added

#3 Updated by intrigeri 2019-10-18 16:49:11

  • related to Bug #16792: Upgrade our Chutney fork added

#4 Updated by intrigeri 2019-10-18 16:49:16

  • related to deleted (Bug #16292: On-screen keyboard not displayed in Buster when logged in in French)

#5 Updated by intrigeri 2019-10-18 16:49:24

#6 Updated by intrigeri 2019-10-18 17:03:54

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|4353ed577b09f2902c2b9ca6079968c5db85b9b8.

#7 Updated by intrigeri 2019-10-18 17:05:12

  • Feature Branch set to test/17163-ssh-stream-isolation+force-all-tests

The updated scenario passes locally, but I can’t reproduce the bug here in the first place ⇒ let’s see what Jenkins thinks.

#8 Updated by intrigeri 2019-10-18 17:05:30

  • Target version changed from Tails_4.1 to Tails_4.0

#9 Updated by intrigeri 2019-10-19 12:22:43

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (intrigeri)

No related failures in 4 full test suite runs on Jenkins!

#10 Updated by segfault 2019-10-19 14:18:02

  • Assignee set to segfault

#11 Updated by segfault 2019-10-19 14:36:28

  • Status changed from Needs Validation to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:tails|810b556034a75aff49fc0b2663e76c6d3d4cce50.

#12 Updated by intrigeri 2019-10-21 11:44:43

  • Status changed from Fix committed to Resolved