Bug #17126

"Using VeraCrypt encrypted volumes" test suite regression

Added by segfault 2019-10-06 05:25:01 . Updated 2019-10-06 05:51:02 .

Status:
Resolved
Priority:
Normal
Assignee:
segfault
Category:
Target version:
Start date:
Due date:
% Done:

0%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Four VeraCrypt scenarios are failing since feature/17098-refactor-greeter was merged.

Subtasks

Related issues

Blocks Tails - Feature #16209: Core work: Foundations Team Confirmed

History

#1 Updated by segfault 2019-10-06 05:25:19

#2 Updated by intrigeri 2019-10-06 05:29:35

I think I’ve fixed this on devel earlier today.

#3 Updated by intrigeri 2019-10-06 05:33:10

> I think I’ve fixed this on devel earlier today.

Gah, that’s not how I should communicate here.

So:

  • I hope commit:c296ed8cb0539d1fe7089709cab219ac9d1fea30 + commit:78f7e163ff0267148c1ec3f5114182c888fa0608 fix it but I did not check yet. I would appreciate a review :)
  • I should have proactively mentioned this somewhere so you don’t spend time on it too.
  • I’m glad you noticed this regression! Sometimes I feel a bit alone analyzing test suite results and I’m very happy to see you’re on top of things here :)))

#4 Updated by segfault 2019-10-06 05:51:02

  • Status changed from Confirmed to Resolved

> I hope c296ed8cb0539d1fe7089709cab219ac9d1fea30 + 78f7e163ff0267148c1ec3f5114182c888fa0608 fix it but I did not check yet. I would appreciate a review :)

Ah yes, that is the same fix I found :)

Btw, I didn’t mean to change volume.py (or any files that are unrelated to the greeter) as part of Feature #17098. That’s why I didn’t test it and didn’t notice the bug.

> I should have proactively mentioned this somewhere so you don’t spend time on it too.

Don’t worry, I didn’t spend much time on it. And I should have checked current devel first.