Feature #17098

Refactor Greeter

Added by segfault 2019-09-26 16:11:26 . Updated 2020-04-15 06:02:25 .

Status:
Resolved
Priority:
Normal
Assignee:
intrigeri
Category:
Target version:
Tails_4.0
Start date:
Due date:
% Done:

100%

Feature Branch:
https://salsa.debian.org/tails-team/tails/merge_requests/39/commits
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Welcome Screen
Deliverable for:

Description

Subtasks

History

#1 Updated by segfault 2019-09-26 16:14:21

After I worked a lot on the Greeter recently, I went crazy today and did a major refactoring. I hope someone finds the time to do a review :S
To make it all worse, I stopped writing meaningful commit messages quite early (I changed so much that the overhead of describing it all would have been too much).

#2 Updated by segfault 2019-09-26 16:14:45

  • Target version set to Tails_4.0
  • Feature Branch set to feature/17098-refactor-greeter

#3 Updated by segfault 2019-09-26 16:25:57

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|e8d086e79f54e3f37a12742b9613adde11e121ca.

#4 Updated by segfault 2019-09-26 16:29:45

The branch is based on feature/16095-curate-languages-in-greeter. I squashed all my “Refactor” commits into one commit, because I in later commits I changed a lot of the code I already had changed before, so reviewing the changes commit by commit would be even more work.

There will be merge conflicts with Feature #17085 which I will solve once one of the branches was merged into devel.

#5 Updated by segfault 2019-09-28 23:19:26

There will also be merge conflicts with Bug #17082, i.e. I will have to move config/chroot_local-includes/usr/local/lib/python3/dist-packages/tailsgreeter to config/chroot_local-includes/usr/lib/python3/dist-packages/tailsgreeter again.

#6 Updated by segfault 2019-10-03 15:24:55

  • Status changed from In Progress to Needs Validation
  • Assignee deleted (segfault)

#7 Updated by segfault 2019-10-03 15:53:00

  • Status changed from Needs Validation to In Progress

Applied in changeset commit:tails|a9480d30587e4aa26a52797d3219383b20bd0af4.

#8 Updated by segfault 2019-10-04 07:59:28

  • Status changed from In Progress to Needs Validation

#9 Updated by segfault 2019-10-04 13:42:20

  • Status changed from Needs Validation to In Progress

Applied in changeset commit:tails|9ce0d48ea8654e1ff362a9400931fb2bc4efe152.

#10 Updated by segfault 2019-10-04 14:01:22

  • Status changed from In Progress to Needs Validation
  • Feature Branch changed from feature/17098-refactor-greeter to https://salsa.debian.org/tails-team/tails/merge_requests/39/commits

#11 Updated by intrigeri 2019-10-05 07:12:27

  • Assignee set to intrigeri

#12 Updated by intrigeri 2019-10-05 15:04:42

  • Status changed from Needs Validation to Resolved
  • % Done changed from 0 to 100

Applied in changeset commit:tails|53c6c19a4ede83bcc99337a46c70b8dfe7277f42.

#13 Updated by intrigeri 2020-04-15 06:02:25

  • Affected tool changed from Greeter to Welcome Screen