Tails

#1 Updated by intrigeri 2019-01-16 14:48:47

• Subject changed from Rebase our custom NetworkManager package to Rebase our custom NetworkManager package on top of 1.6.2-3+deb9u2

#2 Updated by intrigeri 2019-01-16 16:59:05

• blocks Feature #15507: Core work 2019Q1: Foundations Team added

#3 Updated by intrigeri 2019-01-16 17:13:06

• related to Bug #11720: DHCP requests leak hostname on Stretch added

#4 Updated by intrigeri 2019-01-16 17:13:27

• related to Feature #12306: Rebase our custom NetworkManager package on 1.6.2-1 added

#5 Updated by intrigeri 2019-01-16 17:40:49

• Status changed from Confirmed to In Progress

Applied in changeset commit:tails|40809965b9d85df7b9d4543526579eb8f1d0c872.

#6 Updated by intrigeri 2019-01-16 17:41:54

• % Done changed from 0 to 10

OK, I’m very confused. I was expecting dhcp.feature to tell us about this as soon as our custom package was superseded by a newer one, coming from Debian, on the devel branch. Either dhcp.feature is buggy and succeeds when it should fail, or we don’t need this patch anymore.

I’ve tracked this down to a bug in our test suite and pushed a tentative fix. This should make the test suite fail until a new NM is uploaded, which is good. Will now update our NM package.

#7 Updated by intrigeri 2019-01-16 18:04:08

• Assignee changed from intrigeri to anonym
• QA Check set to Ready for QA
• Feature Branch set to bugfix/16365-update-network-manager

Uploaded 1.6.2-3+deb9u2+0.tails1, enabled the corresponding APT overlay. I can’t really spend more time on this before the freeze; mayyybe tomorrow night but don’t count on it. so I’ve tried to do the best I could so that if everything goes fine, it’s super cheap to validate and merge my work (and worst case, to follow-up on it):

So, if my theory + fix are correct:

• the 1st test suite run on this branch (at commit:40809965b9d85df7b9d4543526579eb8f1d0c872, with the test suite fix + Debian’s NM) should fail dhcp.feature
• the 2nd test suite run on this branch (at commit:ff0b71ab774d621a986a0c55db5499afed08cd57, with the test suite fix + updated custom NM) should pass dhcp.feature

#8 Updated by intrigeri 2019-01-17 05:40:31

• % Done changed from 10 to 50

intrigeri wrote:
> So, if my theory + fix are correct:
>
> * the 1st test suite run on this branch (at commit:40809965b9d85df7b9d4543526579eb8f1d0c872, with the test suite fix + Debian’s NM) should fail dhcp.feature
> * the 2nd test suite run on this branch (at commit:ff0b71ab774d621a986a0c55db5499afed08cd57, with the test suite fix + updated custom NM) should pass dhcp.feature

Confirmed.

#9 Updated by anonym 2019-01-18 12:13:36

• Status changed from In Progress to Fix committed
• % Done changed from 50 to 100

Applied in changeset commit:tails|15b53959e413c024918f383615e34efd9ee98973.

#10 Updated by anonym 2019-01-18 13:25:44

• Assignee deleted (anonym)
• QA Check changed from Ready for QA to Pass

Looks good! I manually tested on bare metal that various network-manager related things worked, and everything worked as usual. Merged!

#11 Updated by anonym 2019-01-30 11:50:34

• Status changed from Fix committed to Resolved