Bug #11720

DHCP requests leak hostname on Stretch

Added by intrigeri 2016-08-25 08:41:01 . Updated 2016-08-26 08:28:10 .

Status:
Resolved
Priority:
Elevated
Assignee:
intrigeri
Category:
Target version:
Tails_3.0
Start date:
2016-08-25
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

Upstream bug: https://bugzilla.gnome.org/show_bug.cgi?id=768076

Subtasks

Related issues

Related to Tails - Bug #11630: Check what to do wrt. NetworkManager's internal DHCP client vs. isc-dhcp-client Resolved 2016-08-11
Related to Tails - Bug #16365: Rebase our custom NetworkManager package on top of 1.6.2-3+deb9u2 Resolved 2019-01-16

History

#1 Updated by intrigeri 2016-08-25 08:41:43

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10

I have a fix that seems to work locally, but we need a new automated test: adding new connection without providing the complete config file, e.g. using the GUI or nmcli. Rationale: by providing a complete config file, that says dhcp-send-hostname=false, we are not testing what would happen with a connection added like users do.

#2 Updated by intrigeri 2016-08-25 09:04:50

My fix does not work for newly added connections. Next things to try:

  • drop customization of the list of plugins
  • set dhcp-send-hostname=false directly in NetworkManager.conf
  • set dhcp-send-hostname=false in a [ip] block
  • set dhcp-send-hostname=false in a [ip4] block

#3 Updated by intrigeri 2016-08-25 09:07:39

  • related to Bug #11630: Check what to do wrt. NetworkManager's internal DHCP client vs. isc-dhcp-client added

#4 Updated by intrigeri 2016-08-25 12:32:18

  • Description updated

#5 Updated by intrigeri 2016-08-25 12:34:58

  • % Done changed from 10 to 20

So, what we need is apparently not supported in NM (and it might have been pure luck that it worked as we wanted in the past). I’ve commented on the upstream bug (see description). Until this is fixed on their side, our best option is probably to patch NetworkManager so that it never adds the config line about sending hostname in the dhclient configuration it generates.

#6 Updated by intrigeri 2016-08-26 08:28:11

  • Status changed from In Progress to Resolved
  • % Done changed from 20 to 100

Applied in changeset commit:a0158d97fc2260df8e6b1b67235f2eea914f6a81.

#7 Updated by intrigeri 2019-01-16 17:13:07

  • related to Bug #16365: Rebase our custom NetworkManager package on top of 1.6.2-3+deb9u2 added