Bug #16338

Tor Launcher is not localized

Added by anonym 2019-01-10 10:53:17 . Updated 2019-03-20 14:27:26 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Internationalization
Target version:
Tails_3.13
Start date:
2019-01-10
Due date:
% Done:

100%

Feature Branch:
bugfix/16338-tor-launcher-localization+force-all-tests
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Tor Launcher
Deliverable for:

Description

Regression introduced when migrating to Tor Browser 8.x in Tails 3.9~rc1 (Tails 3.8 with the last Tor Browser 7.5.x release is fine).

Subtasks

Related issues

Related to Tails - Bug #15388: Network Setting Wizard doesn't work in Swedish Resolved 2018-03-08
Has duplicate Tails - Feature #16444: tor-launcher is missing translations Duplicate 2019-02-08
Blocks Tails - Feature #15507: Core work 2019Q1: Foundations Team Resolved 2018-04-08

History

#1 Updated by anonym 2019-01-10 10:53:37

#2 Updated by anonym 2019-01-10 11:04:10

Here’s the fix:

--- a/config/chroot_local-includes/usr/local/bin/tor-launcher
+++ b/config/chroot_local-includes/usr/local/bin/tor-launcher
@@ -18,8 +18,11 @@ fi

 PROFILE="${HOME}/.tor-launcher/profile.default"
 if [ ! -d "${PROFILE}" ]; then
-  mkdir -p "${PROFILE}"
-  configure_best_tor_launcher_locale "${PROFILE}"
+    mkdir -p "${PROFILE}/extensions"
+    for ext in "${TBB_EXT}"/langpack-*.xpi; do
+        ln -s "${ext}" "${PROFILE}/extensions"
+    done
+    configure_best_tor_launcher_locale "${PROFILE}"
 fi

 exec_unconfined_firefox \

However, since we probably have to rework everything Tor Launcher-related (Bug #15709) we might want to hold off on this, and possibly just reject it.

#3 Updated by intrigeri 2019-01-10 12:10:46

> However, since we probably have to rework everything Tor Launcher-related (Bug #15709) we might want to hold off on this, and possibly just reject it.

My take on this is: batch this with the branch + build + test + QA for the Tor Browser upgrade in 3.12, so it’ll come almost for free. And if that’s not possible or does not work, reject.

#4 Updated by anonym 2019-01-10 12:14:56

  • Status changed from Confirmed to In Progress

Applied in changeset commit:tails|4a32a5531a7134fea3434e4abd23ce5d3439f112.

#5 Updated by anonym 2019-01-10 12:17:55

Thanks, intri, that’s a great idea!

#6 Updated by anonym 2019-01-15 13:11:50

Wow, I was very confused and pushed this to the feature/16337-tor-browser-8.5+force-all-test. Dropped from that branch + force-pushed, FWIW.

#7 Updated by anonym 2019-01-29 15:28:11

  • Target version changed from Tails_3.12 to Tails_3.13

I failed (well, forgot) to do this. :/

#8 Updated by intrigeri 2019-02-08 07:17:48

  • has duplicate Feature #16444: tor-launcher is missing translations added

#9 Updated by anonym 2019-02-14 09:26:49

  • % Done changed from 0 to 40
  • QA Check set to Dev Needed
  • Feature Branch set to bugfix/16338-tor-launcher-localization

#10 Updated by anonym 2019-02-25 10:00:19

  • Category set to Internationalization
  • Assignee deleted (anonym)
  • % Done changed from 40 to 50
  • QA Check changed from Dev Needed to Ready for QA
  • Affected tool changed from Browser to Tor Launcher

Jenkins likes what is sees: https://jenkins.tails.boum.org/job/test_Tails_ISO_bugfix-16338-tor-launcher-localization/11/

#11 Updated by intrigeri 2019-02-25 15:17:29

  • Assignee set to anonym
  • QA Check changed from Ready for QA to Info Needed

Most (or even all?) tests that use Tor Launcher are fragile so please +force-all-tests.

#12 Updated by anonym 2019-03-01 09:42:05

  • QA Check changed from Info Needed to Ready for QA
  • Feature Branch changed from bugfix/16338-tor-launcher-localization to bugfix/16338-tor-launcher-localization+force-all-tests

#13 Updated by intrigeri 2019-03-08 14:19:18

  • related to Bug #15388: Network Setting Wizard doesn't work in Swedish added

#14 Updated by intrigeri 2019-03-08 14:19:46

Can you please check that we don’t reintroduce Bug #15388 while fixing this bug?

#15 Updated by intrigeri 2019-03-11 14:48:07

  • Assignee changed from anonym to intrigeri

I’ll at least check the status.

#16 Updated by intrigeri 2019-03-11 15:51:18

Code review passes modulo a comment needed updating (done: commit:d7fcf03aba7fdaf9d783fa30a7f870a0d43d3678). No related test failures on Jenkins but it only tests Tor Launcher in English (otherwise we would have spotted this very bug earlier).

Successfully tested manually in English, Spanish, French, Farsi, Swedish, and Chinese (that all have at least some degree of localization).

intrigeri wrote:
> Can you please check that we don’t reintroduce Bug #15388 while fixing this bug?

I did that and we’re good :)

⇒ Merging!

#17 Updated by intrigeri 2019-03-11 15:52:17

  • Status changed from In Progress to Fix committed
  • % Done changed from 50 to 100

Applied in changeset commit:tails|c3e4e2caf1b81d879857d6425a938abbcb82e4ed.

#18 Updated by intrigeri 2019-03-11 15:52:46

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#19 Updated by CyrilBrulebois 2019-03-20 14:27:26

  • Status changed from Fix committed to Resolved