Bug #15746

Don't display the Enigmail setup wizard by default when starting Thunderbird

Added by intrigeri 2018-07-22 02:07:48 . Updated 2018-09-05 16:14:40 .

Status:
Resolved
Priority:
Elevated
Assignee:
Category:
Target version:
Tails_3.9
Start date:
2018-07-22
Due date:
% Done:

100%

Feature Branch:
bugfix/15746-hide-enigmail-config-wizard
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Email Client
Deliverable for:

Description

We did not display it before Tails 3.8 (in line with the decision made on Feature #10436) but Tails 3.8 displays it. It should not.

Subtasks

Related issues

Related to Tails - Feature #15658: Enable Enigmail by default if a GnuPG secret key is detected Confirmed 2018-06-15
Related to Tails - Bug #15693: Enigmail Wizard Setup shows up at every Tails session Resolved 2018-06-29
Related to Tails - Bug #12680: Persistent Thunderbird blocks future 0000tails.js prefs changes Resolved 2017-06-10
Blocks Tails - Feature #15334: Core work 2018Q3: Foundations Team Resolved 2018-02-20

History

#1 Updated by intrigeri 2018-07-22 02:08:27

  • related to Feature #15658: Enable Enigmail by default if a GnuPG secret key is detected added

#2 Updated by intrigeri 2018-08-08 11:49:00

  • related to Bug #15693: Enigmail Wizard Setup shows up at every Tails session added

#3 Updated by intrigeri 2018-08-08 11:55:05

  • related to Bug #12680: Persistent Thunderbird blocks future 0000tails.js prefs changes added

#4 Updated by intrigeri 2018-08-08 13:58:38

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10
  • Feature Branch set to bugfix/15746-hide-enigmail-config-wizard

I think we want to set extensions.enigmail.configuredVersion to the current version if, and only if, the Thunderbird profile was not initialized yet. This way, in theory:

  • when starting Thunderbird for the first time, the wizard won’t be displayed; I’ve claimed the opposite in commit:5a5cab28cd481be4cf71bd130a5241bc07400d0e so I’ll need to re-check what’s going on
  • once the user has started Thunderbird, Enigmail stores its current version number in the pref, so on following runs Enigmail will only display dialogs if it has a specific upgrade path (from the configuredVersion to the current version) that needs user interaction, which should only happen on upgrades and very rarely (my understanding of the code says that only the upgrade from < 1.7 triggers this currently; that was 4 years ago)
  • I see no code that can fire up the wizard upon upgrades so once we’ve fully disabled it on startup, the only ways for users to configure Enigmail will be to start the setup wizard themselves, just like before Tails 3.8

#5 Updated by intrigeri 2018-08-08 15:03:28

  • Assignee changed from intrigeri to segfault
  • % Done changed from 10 to 50
  • Estimated time set to 1 h
  • QA Check set to Ready for QA

Implemented, seems to work fine. It would be great if you could test it in various scenarios (persistent profile created with 3.8, persistent profile created on an ISO built from this branch, non-persistent profile), hence the higher time allocation than usual for a simple code change. But frankly I don’t think you’ll use all the budget.

#6 Updated by segfault 2018-08-14 14:20:31

Code review passes, now building an ISO to test it.

#7 Updated by segfault 2018-08-14 15:52:57

  • Assignee changed from segfault to intrigeri
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

Works as expected

#8 Updated by intrigeri 2018-08-14 16:08:07

  • Status changed from In Progress to Fix committed
  • Assignee deleted (intrigeri)

Thank you, merged!

#9 Updated by intrigeri 2018-09-05 16:14:40

  • Status changed from Fix committed to Resolved

#10 Updated by segfault 2018-10-03 10:08:56