Tails

#1 Updated by intrigeri 2017-06-29 10:33:45

• blocks Feature #13234: Core work 2017Q3: Foundations Team added

#3 Updated by intrigeri 2017-09-07 08:31:35

• related to Feature #12639: Upgrade Thunderbird to 52.x added

#4 Updated by intrigeri 2017-09-07 08:33:48

• Priority changed from Normal to Elevated

(If we ignore this problem in 3.2, Feature #12639 might break existing profiles somewhat…)

Next step is perhaps to check if that extensions.enigmail.configuredVersion pref is actually useful: it was added in a seemingly unrelated commit (commit:432ba8efefce14057bac9a30afb113f297bc9472) without any explanation. Perhaps we could actually get rid of 0000tails.js entirely and be done with it?

#5 Updated by anonym 2017-09-13 16:15:43

• Feature Branch set to feature/12639-thunderbird-52

#6 Updated by anonym 2017-09-13 17:28:50

• Status changed from Confirmed to In Progress

Applied in changeset commit:74f1aed4e848edf270c61e44a884cda758a218c7.

#7 Updated by intrigeri 2017-09-14 15:59:36

• Assignee changed from anonym to intrigeri
• % Done changed from 0 to 50
• QA Check set to Ready for QA

I’ll assume this is ready for QA too.

#8 Updated by anonym 2017-09-14 16:10:02

• Affected tool set to Email Client

I manually tested this, and it works fine!

#10 Updated by intrigeri 2017-09-14 16:53:58

• Assignee changed from intrigeri to anonym
• QA Check changed from Ready for QA to Dev Needed

I’ve upgraded some Tails with Thunderbird persistence to an ISO built from this branch. The migration code works as intended (profile.default/preferences/0000tails.js does not contain extensions.enigmail.configuredVersion), but it isn’t sufficient to achieve the desired effect: while /etc/xul-ext/enigmail.js says 1.9.8.1 (as expected), about:config still says that extensions.enigmail.configuredVersion == 1.9.7, marked as modified by the user, which I think was we wanted to avoid with the added migration code (“too old versions might trigger work-around code to run unnecessarily”).

I see that: profile.default/prefs.js:user_pref("extensions.enigmail.configuredVersion", "1.9.7"); and if I remove it and restart Thunderbird, then everything is fine again! :)

Did this work better for you, or did you only look at the config files you could think of, instead of looking at the resulting config actually used by Thunderbird?

I guess we need another command in live-persist to remove the unwanted pref from prefs.js.

#11 Updated by anonym 2017-09-14 17:05:35

• Assignee changed from anonym to intrigeri
• QA Check changed from Dev Needed to Ready for QA

I was only considering preferences/0000tails.js, so I only verified that the file was removed. It didn’t occur to me that the pref also would appear in prefs.js in a profile that was actually used previously.

On it!

#12 Updated by intrigeri 2017-09-14 17:20:11

• Assignee changed from intrigeri to anonym
• QA Check changed from Ready for QA to Dev Needed

(Assuming this metadata change was a mistake.)

I see. Lesson learnt: always zoom out and check the expected outcome on the big picture rather than just checking that the code does what we believe should be enough :)

#13 Updated by anonym 2017-09-14 17:28:33

• Assignee changed from anonym to intrigeri
• % Done changed from 50 to 70
• QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:
> (Assuming this metadata change was a mistake.)

Ever since the Redmine upgrade (I think) my browser is confused and seems to pick up past field values as soon as I click “Edit” (i.e. the values I get in the fields do not reflect current actual state). I will now try to forcefully clean my browser history.

So, I’ve pushed a fix. I’ve so far only tested it in an environment where I set up the same directory structure + mounts. I’m not 100% confident in this, but if you want me to test it properly I’m afraid it will take ~1 hour, because my libvirt/qemu/kvm/something is really misbehaving. If so, please assign it back to me!

#14 Updated by intrigeri 2017-09-14 18:48:28

• Assignee changed from intrigeri to anonym
• QA Check changed from Ready for QA to Dev Needed

anonym wrote:
> intrigeri wrote:
> > (Assuming this metadata change was a mistake.)
>
> Ever since the Redmine upgrade (I think) my browser is confused and seems to pick up past field values as soon as I click “Edit” (i.e. the values I get in the fields do not reflect current actual state).

That’s been the case on Redmine ever since I can remember when one edits an issue that someone else has modified in the meantime, without fully reloading the page first.

> So, I’ve pushed a fix. I’ve so far only tested it in an environment where I set up the same directory structure + mounts. I’m not 100% confident in this, but if you want me to test it properly I’m afraid it will take ~1 hour, because my libvirt/qemu/kvm/something is really misbehaving. If so, please assign it back to me!

Please test it properly (spare laptop?) or give me an automated test case (that we can drop immediately once tested, of course).

I’ll look at this first thing tomorrow morning.

#15 Updated by anonym 2017-09-15 03:18:36

• Assignee changed from anonym to intrigeri
• QA Check changed from Dev Needed to Ready for QA

Manual test (without any shortcuts) successful!

#17 Updated by intrigeri 2017-09-15 06:55:24

• Status changed from In Progress to Fix committed
• % Done changed from 70 to 100

Applied in changeset commit:03c5e9f8976b95bd5e9da1af9de3df2c03c02a21.

#18 Updated by intrigeri 2017-09-15 06:56:39

• Assignee deleted (intrigeri)
• QA Check changed from Ready for QA to Pass

Merged! Please review the aforementioned fix I’ve added.

#19 Updated by anonym 2017-09-28 18:48:51

• Status changed from Fix committed to Resolved

#20 Updated by intrigeri 2018-08-08 11:55:05

• related to Bug #15746: Don't display the Enigmail setup wizard by default when starting Thunderbird added