Tails

#1 Updated by intrigeri 2018-06-18 17:02:08

• Assignee set to sajolida
• Target version set to Tails_3.8
• Deliverable for set to 299

#2 Updated by sajolida 2018-06-25 16:15:49

• Target version changed from Tails_3.8 to Tails_3.9

#3 Updated by sajolida 2018-06-26 15:23:37

• Assignee changed from sajolida to segfault
• QA Check set to Ready for QA

After watching the videos again I think I understand the problem better. People thought that Disks was the place where to specify the keyfile and didn’t understand that they had to use Disks as a full alternative to GVfs monitor.

I think that the confusion arises from the fact that Disks is presented below all the other unlocking parameters, as if it was the place to specify a keyfile (but not a password for example).

So what about presenting Disks first and not in the list of unlocking parameters?

That could be:

Set options to unlock the volume
================================

The volume Generic Flash Disk (8.2 GB Drive) might be a VeraCrypt volume as it contains random data.

To unlock a volume that uses keyfiles, use _the *Disks* utility_ instead.

Password: [                 ]

[ ] Remember Password
[ ] Hidden Volume
[ ] Windows System Volume

[   Cancel   ] [   Unlock   ]

I’m also:

• Replacing the button with a link. Now that this appears on top of the dialog despite not being the most popular option, it feels right to try to take less pixels.
• Saying the Disks utility instead of Disks. See Feature #15669.

#4 Updated by segfault 2018-06-28 11:15:04

• Assignee changed from segfault to sajolida
• QA Check changed from Ready for QA to Info Needed

sajolida wrote:
> After watching the videos again I think I understand the problem better. People thought that Disks was the place where to specify the keyfile and didn’t understand that they had to use Disks as a full alternative to GVfs monitor.
>
> I think that the confusion arises from the fact that Disks is presented below all the other unlocking parameters, as if it was the place to specify a keyfile (but not a password for example).
>
> So what about presenting Disks first and not in the list of unlocking parameters?
>
> That could be:
>
> […]
>
> I’m also:
>
> * Replacing the button with a link. Now that this appears on top of the dialog despite not being the most popular option, it feels right to try to take less pixels.
> * Saying the Disks utility instead of Disks. See Feature #15669.

I like it. But unfortunately, links are not supported in GNOME Shell’s labels :(
So we will have to use a button or make the whole label clickable or figure out something else.

#5 Updated by segfault 2018-06-28 13:28:16

• File Shell Unlock Dialog Open Disks Button.png added

I implemented the other changes, i.e. moved Disks above the other options and saying the Disks utility. See the attached screenshot.

#6 Updated by sajolida 2018-07-06 18:00:57

• Assignee changed from sajolida to segfault

Great! Changing the order was the most important part!

Nitpicking: I gave you wrong instructions because of the different syntax between Markdown and Redmine. The GNOME Style Guide uses italic for applications name. So it should be “the Disks utility” and not “the Disks utility”. Sorry for the confusion! And if it’s a pain to change, please ignore that :)

#7 Updated by intrigeri 2018-07-09 09:38:13

• Subject changed from Rethink how Disks is pointed to from GVfs monitor to Improve how Disks is pointed to from GVfs monitor
• Status changed from Confirmed to In Progress
• % Done changed from 0 to 10
• QA Check deleted (Info Needed)
• Type of work changed from User interface design to Code

#8 Updated by segfault 2018-07-26 08:51:17

• Subject changed from Improve how Disks is pointed to from GVfs monitor to Improve how Disks is pointed to from the GNOME Shell dialog

#10 Updated by intrigeri 2018-08-09 10:32:56

• Priority changed from Normal to High

segfault wrote:
> > Nitpicking: I gave you wrong instructions because of the different syntax between Markdown and Redmine. The GNOME Style Guide uses italic for applications name. So it should be “the Disks utility” and not “the Disks utility”. Sorry for the confusion! And if it’s a pain to change, please ignore that :)
>
> Fixed on the branch based on upstream master, so that this will be correct when merged in upstream. I also fixed it in my branch based on the version we use in Tails, but I won’t build a new package just for this.

If I understand correctly this will be a translatable string change so I’d rather see this applied in the RC and not during the freeze, in order to avoid the strings becoming fuzzy. There might be other reasons (packaging improvements from Feature #15521) to rebuild this package anyway.

#11 Updated by segfault 2018-08-12 21:03:29

• Priority changed from High to Normal

I included this in the new gnome-shell package built as part of Feature #15221.

#12 Updated by segfault 2018-08-12 21:29:39

• Status changed from In Progress to Resolved
• Assignee deleted (segfault)

I think we are done here, it will be upstreamed along with https://gitlab.gnome.org/GNOME/gnome-shell/merge_requests/126 (tracked on Feature #15222).