Bug #15616
devel branch FTBFS: xul-ext-ublock-origin is not installable
100%
Description
Subtasks
Related issues
Related to Tails - |
Resolved | 2017-11-19 | |
Blocks Tails - |
Resolved | 2018-01-01 |
History
#1 Updated by intrigeri 2018-05-23 09:36:39
- related to
Bug #14993: uBlock is broken in Tails 3.3 added
#2 Updated by intrigeri 2018-05-23 09:38:18
- blocks
Feature #15139: Core work 2018Q2: Foundations Team added
#3 Updated by intrigeri 2018-05-23 09:44:07
- Status changed from Confirmed to In Progress
- % Done changed from 0 to 10
- Affected tool set to Browser
To fix Bug #14933 we added APT pinning to fetch that package from sid. And now the package from sid switched from a xul-ext to a webext. We could add pinning to also fetch webext-ublock-origin from sid but then we’ll need to update install_debian_extensions()
somehow (and possibly other bits of our uBlock / Tor Browser integration). I’d rather handle this transition to Feature #15023 and for now, fix the current problem by uploading the latest, working version we’ve been shipping (1.13.8+dfsg-1) to our custom APT repo.
#4 Updated by intrigeri 2018-05-23 09:44:40
- Feature Branch set to bugfix/15616-ublock-1.16.x
#5 Updated by intrigeri 2018-05-23 09:58:22
- Feature Branch changed from bugfix/15616-ublock-1.16.x to bugfix/15616-ublock-1.13.x
#6 Updated by intrigeri 2018-05-23 10:10:58
intrigeri wrote:
> […[ for now, fix the current problem by uploading the latest, working version we’ve been shipping (1.13.8+dfsg-1) to our custom APT repo.
Done on the topic branch. If this fixes the build and installs the correct version I’ll ask kibi, lamby or segfault to review.
#7 Updated by intrigeri 2018-05-24 08:41:18
- Assignee changed from intrigeri to segfault
- % Done changed from 10 to 50
lamby, segfault: can any of you review this as part of FT work? (First come, first serve.)
I expect 0.5 hour of focused work will be enough to:
- check my reasoning above
- do a quick “code” review of the topic branch
- check that the
.build-manifest
and.packages
in the last Jenkins build reference the correct mention of ublock-origin, that is the same one as the one found in the corresponding files in https://git-tails.immerda.ch/tails/tree/wiki/src/torrents/files/ - check that the APT overlay repo added by this branch (https://deb.tails.boum.org/dists/bugfix-15616-ublock-1.16.x/) only contains the expected package
But if for some reason up to 1 hour is needed, that’ll be fine. Just tell me.
#8 Updated by lamby 2018-05-24 13:15:45
Just had a look at this. That version of ublock origin does indeed appear on the ISO after booting (and the manifest, etc. etc.).
19988 Source: ublock-origin
19989 Version: 1.13.8+dfsg-1
Although I’m missing something here as that APT repo contains nothing at all. eg. all the Packages/Sources files listed in https://deb.tails.boum.org/dists/bugfix-15616-ublock-1.16.x/Release are 0-bytes. :)
#9 Updated by intrigeri 2018-05-24 13:22:22
- Assignee changed from segfault to lamby
> Although I’m missing something here as that APT repo contains nothing at all. eg.
> all the Packages/Sources files listed in
> https://deb.tails.boum.org/dists/bugfix-15616-ublock-1.16.x/Release are 0-bytes. :)
Sorry, typo :/ Correct URL is https://deb.tails.boum.org/dists/bugfix-15616-ublock-1.13.x/
#10 Updated by lamby 2018-05-24 13:24:00
No worries. It’s on the linked ISO (downloaded, etc.)
#11 Updated by intrigeri 2018-05-26 06:42:06
(Once you’re done with the review, reassign to me and if happy, set “QA Check” to “Pass” :)
#12 Updated by lamby 2018-05-26 07:38:14
- Assignee changed from lamby to intrigeri
- QA Check set to Pass
> (Once you’re done with the review, reassign to me and if happy, set “QA Check” to “Pass” :)
TIL!
(done)
#13 Updated by intrigeri 2018-05-26 08:47:35
Thanks, merging!
#14 Updated by intrigeri 2018-05-26 08:48:09
- Status changed from In Progress to Fix committed
- Assignee deleted (
intrigeri) - Target version changed from Tails_3.8 to Tails_3.9
- % Done changed from 50 to 100
#15 Updated by intrigeri 2018-09-05 16:08:11
- Status changed from Fix committed to Resolved