Bug #12249

Greeter's Formats popover may be cut

Added by alant 2017-02-17 16:18:25 . Updated 2020-04-15 06:01:44 .

Status:
Resolved
Priority:
Low
Assignee:
Category:
Target version:
Start date:
2017-02-17
Due date:
% Done:

100%

Feature Branch:
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Welcome Screen
Deliverable for:

Description

When starting Tails under libvirt/qemu whithout a persistent volume, the Formats popover is cut:


Files


Subtasks


Related issues

Related to Tails - Bug #12364: Race condition at greeter startup Rejected 2017-05-16

History

#1 Updated by alant 2017-02-17 18:38:41

  • Assignee changed from alant to intrigeri
  • QA Check set to Ready for QA
  • Feature Branch set to greeter:bugfix/12249-formats-popover-cut

This was happening on bare metal too. It should be fixed in bugfix/12249-formats-popover-cut, tested under libvirt/qemu with and without persistence and on bare metal.

#2 Updated by intrigeri 2017-03-17 12:14:24

  • blocked by Bug #12079: New Greeter breaks startup of Terminal by setting invalid values for some LC_* variables added

#3 Updated by intrigeri 2017-03-17 12:15:00

I’ll review this only if needed, i.e. once Bug #12079 has reached a conclusion.

#4 Updated by intrigeri 2017-03-18 08:11:45

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 60

Code review passes.

#5 Updated by intrigeri 2017-03-18 09:02:16

  • Assignee changed from intrigeri to alant
  • Priority changed from Normal to Elevated
  • QA Check changed from Ready for QA to Dev Needed

Merged, but I’ve just seen the popover being cut in the bottow => can you please fix that?

#6 Updated by alant 2017-03-18 17:53:27

  • Assignee changed from alant to intrigeri
  • QA Check changed from Dev Needed to Info Needed

intrigeri wrote:
> Merged, but I’ve just seen the popover being cut in the bottow => can you please fix that?

Please elaborate on how to reproduce this issue, and which popover is cut. I don’t acheive to reproduce it.

#7 Updated by intrigeri 2017-03-18 18:17:10

  • Assignee changed from intrigeri to alant
  • QA Check changed from Info Needed to Dev Needed

Demonstrated to Alan.

#8 Updated by alant 2017-03-19 00:02:54

The remaining issue seems to only happen with the headerbar with square angles, as Bug #12364. I suspect that some services required by the greeter are sometimes not yet started, as after restarting the greeter the issue doesn’t show up anymore. When we’ll have Feature #12373 this should be easier to debug.

#9 Updated by alant 2017-03-19 16:31:39

  • blocks deleted (Bug #12079: New Greeter breaks startup of Terminal by setting invalid values for some LC_* variables)

#10 Updated by alant 2017-03-19 16:31:53

#11 Updated by alant 2017-03-20 21:01:07

Please review and merge at 3b4403 but don’t close the ticket. It beotter spread extranous space required for the popover to be shown completly among sections of the interface.

This ticket should however be kept open as long as Bug #12364 is not resolved.

#12 Updated by alant 2017-03-20 21:01:36

  • QA Check changed from Dev Needed to Ready for QA

#13 Updated by intrigeri 2017-04-02 09:04:23

anonym, I’d like to see this fix in 3.0~beta4 (April 18, same day as 2.12). Any chance you review this in time, e.g. during the 2.12 freeze? If not, please reassign to me.

#14 Updated by anonym 2017-04-16 18:25:22

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 60 to 100
  • QA Check changed from Ready for QA to Pass

Merged!

But the issue is still not fully resolved: if the popover is open and I resize the window vertically I can easily find situations where the popover gets cut. Only parts of the border is cut, however, so I find this “problem” completely irrelevant.

I find it a slight bit worse that with a screen with 480 pixels of vertical resolution the popover will end up underneath the GNOME top panel, completely blocking the text entry. Still, sort of irrelevant given that no one likely uses that small resolutions these days.

Any way, I think what we have is good enough, so I consider this ticket closed; if someone feels differently about this, please re-open it!

#15 Updated by intrigeri 2017-04-18 15:18:13

  • Status changed from Fix committed to In Progress
  • Assignee set to alant
  • Target version changed from Tails_3.0 to Tails_3.0~rc1
  • % Done changed from 100 to 50

Alan wrote “This ticket should however be kept open as long as 12364 is not resolved” so reassigning to him. What’s the next step?

#16 Updated by alant 2017-05-11 15:26:19

  • Assignee changed from alant to intrigeri

intrigeri wrote:
> Alan wrote “This ticket should however be kept open as long as 12364 is not resolved” so reassigning to him.

The problem is that if the screen is not high enouge or the user shrinks the window the problem may still occur.

> What’s the next step?

Fix Bug #12364. Prehaps having this ticket still open is a duplicate though.

#17 Updated by intrigeri 2017-05-16 13:32:50

#18 Updated by intrigeri 2017-05-16 13:32:58

#19 Updated by intrigeri 2017-05-16 13:33:26

  • blocked by Bug #12364: Race condition at greeter startup added

#20 Updated by intrigeri 2017-05-16 13:34:19

  • Assignee deleted (intrigeri)
  • Priority changed from Elevated to Normal
  • Target version deleted (Tails_3.0~rc1)
  • QA Check deleted (Pass)
  • Feature Branch deleted (greeter:bugfix/12249-formats-popover-cut)

Leaving it opened in the hope duplicates don’t get reported, marked as blocked by the likely root cause of the problem. Not a blocker for 3.0 IMO.

#21 Updated by intrigeri 2017-06-04 14:05:47

See Bug #12364#note-52 for debugging instructions.

#22 Updated by intrigeri 2017-06-04 14:07:40

#23 Updated by intrigeri 2017-06-04 14:10:53

  • blocks deleted (Bug #12364: Race condition at greeter startup)

#24 Updated by intrigeri 2017-06-04 14:11:46

  • related to Bug #12364: Race condition at greeter startup added

#25 Updated by Anonymous 2017-06-29 12:15:55

  • Priority changed from Normal to Low

So, anyone who can somewhat reliably reproduce any of these bugs, please:

  • get used to add the debug option in the boot loader;
  • send a WhisperBack bug report every time you hit any of these problems, clearly stating which one(s), and provide a contact email address;
  • ideally, send the boot.svg file generated by systemd-analyze plot > boot.svg to alan@boum.org and intrigeri@boum.org, referring to the bug report you’ll have sent already.

Setting loprio because most people don’t use such small screens anyway.

#26 Updated by Anonymous 2018-01-15 09:57:41

  • Status changed from In Progress to Resolved
  • % Done changed from 50 to 100

A fix has been merged. No news since 7 months on this ticket, no new bug reports on the issue -> seems we’re good. Closing.

#27 Updated by intrigeri 2020-04-15 06:01:44

  • Affected tool changed from Greeter to Welcome Screen