Tails

#1 Updated by intrigeri 2017-02-19 09:07:40

• Description updated

#3 Updated by intrigeri 2017-04-18 15:07:11

• Assignee set to anonym
• Target version changed from Tails_3.0 to Tails_3.0~rc1

Wanna take it?

#5 Updated by anonym 2017-05-15 15:56:06

• Status changed from Confirmed to In Progress
• Assignee changed from anonym to intrigeri
• % Done changed from 0 to 50
• QA Check set to Ready for QA
• Feature Branch set to tails:feature/11712-thunderbird t-p-s:master

I believe all migrations (code, use docs, design docs, release process, persistence) is fixed now.

#6 Updated by intrigeri 2017-05-16 07:02:11

• Assignee changed from intrigeri to anonym
• QA Check changed from Ready for QA to Info Needed

Thanks! I see that Bug #11964 has the same topic branch. So, just to clarify: is Feature #12242 blocked by Bug #11964 in any way?

#7 Updated by intrigeri 2017-05-16 16:44:04

• QA Check changed from Info Needed to Ready for QA

#8 Updated by intrigeri 2017-05-16 16:44:23

• Assignee changed from anonym to intrigeri

in

#9 Updated by intrigeri 2017-05-16 17:16:23

• Assignee changed from intrigeri to anonym
• QA Check changed from Ready for QA to Dev Needed

I see no change in t-p-s:master. Forgot to push?

#10 Updated by anonym 2017-05-16 17:32:33

• Assignee changed from anonym to intrigeri
• QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:
> I see no change in t-p-s:master. Forgot to push?

Yes, sorry! Now pushed!

#11 Updated by intrigeri 2017-05-16 17:42:44

• Assignee changed from intrigeri to anonym
• QA Check changed from Ready for QA to Dev Needed

• There’s still a link to https://tails.boum.org/doc/anonymous_internet/claws_mail_to_icedove. Rename and add redirect?
• I see ‘Note that we now need secrets for “Thunderbird”’; please file a sysadmin ticket for me to adjust our infra accordinly… or keep supporting the old name?
• wrt. commit:b3abf4e5f57d31f59ad34c4f71188fb57879b65f: this only works well if there’s at least one persistence.conf, which is why we used ls previously. I expect the updated code will still work, but will spit errors to STDERR when persistence is disabled, correct? I’m no big fan of this change.
• Given the AppArmor “open attachments” thing is not ready, is Apparmor-hide-open-attachment.patch. the right thing to do?
• Care to rewrite or comment sed -i "\_^$(escape '._' "${PRESET}")\s_d" "${CONFIG}"? I gave up trying to understand it :/

Other than than, code review passes at commit:5d848fb956b4628ee79006a2a994d212b69fca48 :)

#12 Updated by anonym 2017-05-17 23:52:32

• Assignee changed from anonym to intrigeri
• % Done changed from 50 to 60
• QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:
> * There’s still a link to https://tails.boum.org/doc/anonymous_internet/claws_mail_to_icedove. Rename and add redirect?

We agreed off-band to simply drop the migration from Claws Mail (we dropped it almost 1½ years ago).

> * I see ‘Note that we now need secrets for “Thunderbird”’; please file a sysadmin ticket for me to adjust our infra accordinly… or keep supporting the old name?

Both are supported at the same time. If you keep your checkout of our shared secrets repo up-to-date you already have the new secrets. Is our infra not automatically doing that?

> * wrt. commit:b3abf4e5f57d31f59ad34c4f71188fb57879b65f: this only works well if there’s at least one persistence.conf, which is why we used ls previously. I expect the updated code will still work, but will spit errors to STDERR when persistence is disabled, correct? I’m no big fan of this change.

Argh, of course. Reverted!

> * Given the AppArmor “open attachments” thing is not ready, is Apparmor-hide-open-attachment.patch. the right thing to do?

Well, it will make it easier to test whatever is cooked up for Bug #11964 since no new thunderbird must be built (so it can be tested live on e.g. 3.0~rc1). Also, note that the patch result is the current upstream code, and it doesn’t seem to have broken neither Thunderbird nor Firefox.

> * Care to rewrite or comment sed -i "\_^$(escape '._' "${PRESET}")\s_d" "${CONFIG}"? I gave up trying to understand it :/

See commit:225730198e.

> Other than than, code review passes at commit:5d848fb956b4628ee79006a2a994d212b69fca48 :)

Thanks for the review!

#17 Updated by intrigeri 2017-05-18 16:05:01

• Status changed from In Progress to Fix committed
• % Done changed from 60 to 100

Applied in changeset commit:bd903d7e4f6a0599a133e7af46f99069b4d2ebf3.

#18 Updated by intrigeri 2017-05-18 16:08:46

• Assignee deleted (intrigeri)
• QA Check changed from Ready for QA to Pass

#19 Updated by intrigeri 2017-05-23 09:08:59

• Status changed from Fix committed to Resolved

#20 Updated by intrigeri 2018-01-02 14:29:24

• related to Bug #12734: Thunderbird doesn't start if ~/.icedove exists and is empty added