Bug #11199

Redesign Tor status extension icon which looks too sad to be connected

Added by emmapeel 2016-03-08 16:16:19 . Updated 2016-04-26 09:13:23 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Start date:
2016-03-08
Due date:
% Done:

100%

Feature Branch:
bugfix/11199-tor-status-contrast
Type of work:
Graphics
Blueprint:

Starter:
Affected tool:
Onion Circuits
Deliverable for:

Description

Several users complain that the new Onion Icon does not look connected when it is.

They feel that:

- It looks empty besides other icons like battery or wifi

- It could have more contrast compared to the disconnected onion

- Could be ‘fuller’
- The other icons that have colors make it look sad (if all the icons were complying the Gnome Guidelines it will not look so bad, but for example Pidgin has a nice full green ball)


Files


Subtasks


Related issues

Has duplicate Tails - Feature #11454: Bring back the green onion icon when Tor is ready Rejected 2016-05-21

History

#1 Updated by anonym 2016-03-08 16:54:22

Somewhat related, I find it hard (due to my subpar eyesight) to distinguish between the two states: Feature #6841#note-31, Feature #6841#note-34, Feature #6841#note-35. Short story: the “X” melts into the shaded part of the onion unless I look carefully.

I suspect more contrast or colour would fix it.

#2 Updated by sajolida 2016-03-09 11:02:12

  • Subject changed from Onion circuits: icon looks too sad to be connected to Redesign Tor status extension icon which looks too sad to be connected
  • Status changed from New to Confirmed

The icons we have in there that have colors are all from the TopIcons extension and are meant to disappear, see Bug #8309. The design guidelines for GNOME Shell is to have only monochromatic icons.

So we should stick to monochrome even though it’s less expressive.

#3 Updated by sajolida 2016-03-10 18:07:54

The favicon for trac.torproject.org is small and the shape looks better. See attachment.

#5 Updated by intrigeri 2016-04-01 16:45:40

  • Assignee set to intrigeri
  • Target version set to Tails_2.3
  • Starter deleted (Yes)

I’ll do a quick fix for the contrast between the two states expressed by this icon. I’ll try to do that for 2.3. Then, other people (possibly waiting for Tor’s new design that’s in the works) can push this further as they wish (get in touch with sajolida first, he knows more).

#6 Updated by intrigeri 2016-04-14 21:33:51

  • Status changed from Confirmed to In Progress
  • % Done changed from 0 to 10
  • Feature Branch set to bugfix/11199-tor-status-contrast

Icon modified, next step is updating the test suite. anonym: if you want to take that next step and merge, e.g. if I don’t manage to do it by the end of the week (and then I won’t do it in time for 2.3), feel free to.

#7 Updated by intrigeri 2016-04-15 03:09:12

  • Assignee changed from intrigeri to anonym
  • % Done changed from 10 to 50
  • QA Check set to Ready for QA

Test suite updated => please review and merge, but don’t mark as fix committed as other people want to go further so reassign to sajolida who has more info about it. Note that I didn’t update the screenshots in the doc, to save time and .git space, since the change is so minor and it’s expected that the icon will change again.

#8 Updated by anonym 2016-04-22 17:52:25

  • Status changed from In Progress to Fix committed
  • Assignee deleted (anonym)
  • % Done changed from 50 to 100
  • QA Check changed from Ready for QA to Pass

It looks good to me and it does fix my issue, raised in Bug #11199#note-1, which I suppose is the same as the original request for “more contrast compared to the disconnected onion”. Given that sajolida vetoed the request for more color, and didn’t really comment on the rest, I decided to merge the branch and close the ticket, and let someone open a new ticket if they feel there’s something more to do. It doesn’t feel ideal, I guess since this in the area where I don’t feel I have the “authority” to make decisions by myself (essentially everything that’s not about code, release process or design docs).

#9 Updated by anonym 2016-04-26 09:13:23

  • Status changed from Fix committed to Resolved

#10 Updated by elouann 2016-05-23 00:08:26

  • has duplicate Feature #11454: Bring back the green onion icon when Tor is ready added