Bug #10375

Increase the number of Tor circuit retries in the test suite

Added by kytv 2015-10-15 05:37:56 . Updated 2015-11-06 06:05:24 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Tails_1.7
Start date:
2015-10-15
Due date:
% Done:

100%

Feature Branch:
kytv:test/10375-bump-Tor-retry-limit
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:
267

Description

The main rationales for this are OFTC’s blocking of Tor and communication problems with the keyservers.

anonym wrote:
> OFTC blocking is still a problem. We could try bumping the retries from 5 to 10. Thoughts?

I think raising the default to 10 or more would be fine. Any users that may want to run the test suite can set this however they’d like.

Subtasks

History

#1 Updated by kytv 2015-10-15 05:38:16

  • Description updated

#2 Updated by kytv 2015-10-15 05:38:37

#3 Updated by kytv 2015-10-15 05:53:16

  • Description updated

#4 Updated by anonym 2015-10-15 06:36:45

kytv wrote:
> I think raising the default to 10 or more would be fine. Any users that may want to run the test suite can set this however they’d like.

Let’s try 10. We value robustness over performance, I guess. However, there’s some limit: if we need more, then Feature #9517 was not the right solution for Bug #9072 (and it should be reopened).

(Meta: redmine refuses to add any of those as Related tickets, complaining about “circular dependency”. Argh!)

#5 Updated by kytv 2015-10-15 09:03:32

  • Tracker changed from Feature to Bug
  • Status changed from Confirmed to In Progress
  • Assignee set to anonym
  • QA Check set to Ready for QA
  • Feature Branch set to kytv:test/10375-bump-Tor-retry-limit

Done.

#6 Updated by kytv 2015-10-15 09:10:18

  • % Done changed from 0 to 50

#7 Updated by intrigeri 2015-10-16 02:35:46

  • blocks #8668 added

#8 Updated by anonym 2015-10-16 07:06:19

  • Assignee changed from anonym to kytv
  • QA Check changed from Ready for QA to Dev Needed

This branch does not remove the @fragile tags for the IRC tests you added in your devel’s commit 1e5fd8f. Please push a revert of that commit. (I would have done this myself if it wasn’t for the fact that I cannot merge your devel per Bug #10378#note-12.)

#9 Updated by anonym 2015-10-16 10:04:51

anonym wrote:
> This branch does not remove the @fragile tags for the IRC tests you added in your devel’s commit 1e5fd8f. Please push a revert of that commit. (I would have done this myself if it wasn’t for the fact that I cannot merge your devel per Bug #10378#note-12.)

I now see that 1e5fd8f added fragile due to Bug #10376, so sorry for the noise.

However, as you noted on IRC, this might have uncovered a small problem with the scheme for Bug #10288: if there are two (or more) reasons to tagging a scenario @fragile, what to do? Luckily, Cucumber has no issue with the same tag being specified multiple times for a scenario (and --tag TAG@@ and --tag ~TAG@@ still works the same as with only once instance), so the scheme will work: the revert will cause a merge conflict, and we remove only one of the @fragile tags. I’ve updated the description of Bug #10288 to make this clear.

#10 Updated by anonym 2015-10-16 10:20:40

anonym wrote:
> However, as you noted on IRC, this might have uncovered a small problem with the scheme for Bug #10288: if there are two (or more) reasons to tagging a scenario @fragile, what to do? Luckily, Cucumber has no issue with the same tag being specified multiple times for a scenario (and --tag TAG@@ and --tag ~TAG@@ still works the same as with only once instance), so the scheme will work: the revert will cause a merge conflict, and we remove only one of the @fragile tags. I’ve updated the description of Bug #10288 to make this clear.

Actually, that idea won’t work. I updated the (end of the) description of Bug #10288 with another solution. It got really complicated, so let’s see if the instructions are clear enough for you to implement… :S

#11 Updated by kytv 2015-11-04 10:43:58

  • Status changed from In Progress to Fix committed
  • Target version deleted (Tails_1.7)
  • % Done changed from 50 to 100
  • QA Check deleted (Dev Needed)

This was actually merged in 02bfdf71ece80fe5678a7b96f91105634135b071

#12 Updated by kytv 2015-11-04 10:44:11

  • Assignee deleted (kytv)

#13 Updated by intrigeri 2015-11-05 02:30:50

  • Status changed from Fix committed to Resolved
  • Target version set to Tails_1.7

#14 Updated by intrigeri 2015-11-06 06:05:24

  • Deliverable for set to 267