Feature #10340

Automatically test the Greeter's Disable All Networking option

Added by anonym 2015-10-06 03:33:21 . Updated 2020-04-15 06:01:50 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Tails_2.0
Start date:
2015-10-06
Due date:
% Done:

100%

Feature Branch:
test/10340-disable-all-networking
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Welcome Screen
Deliverable for:

Description

This is best done by:

  • Checking that NetworkManager is not running.
  • Using the ‘no network devices are present’ step from the (not yet merged as of writing this) test/6302-mac-spoofing branch.
  • Checking that there’s no network traffic for a while after booting Tails, just to be really sure, I guess.

Subtasks

Related issues

Blocked by Tails - Feature #6302: Write MAC spoofing tests Resolved 2013-09-26

History

#1 Updated by anonym 2015-10-06 03:33:41

#2 Updated by anonym 2015-10-06 03:34:12

  • Assignee set to kytv
  • Target version set to Tails_1.7

#3 Updated by anonym 2015-10-06 03:35:55

#4 Updated by anonym 2015-10-06 03:36:43

  • blocks #8538 added

#5 Updated by anonym 2015-10-06 03:43:28

  • QA Check set to Dev Needed

kytv, to help us get this into Tails 1.7, I suggest that you create a new branch based on feature/6811-disable-networking, merge in test/6302-mac-spoofing (for the missing step, see the ticket description) and write a test in a new feature file (one scenario is enough). It’d be great if you can do this early (=> early reviews, no matter the state of Feature #6302), so there’s a chance we can get this into Tails 1.7.

#6 Updated by intrigeri 2015-10-09 15:53:53

During this cycle, I’d rather see kytv focus on Icedove, his late deliverables, and test suite robustness on Jenkins, than on this bonus, unscheduled feature. This can wait for 1.8, no?

#7 Updated by kytv 2015-11-04 10:46:03

  • Target version changed from Tails_1.7 to Tails_1.8

#8 Updated by anonym 2015-11-23 04:57:02

#9 Updated by kytv 2015-11-26 07:55:56

  • Status changed from Confirmed to In Progress

#10 Updated by kytv 2015-11-27 09:48:14

  • % Done changed from 0 to 50
  • Feature Branch set to kytv/test/10430-disable-all-networking

#11 Updated by kytv 2015-11-27 11:27:53

  • Assignee changed from kytv to anonym
  • QA Check changed from Dev Needed to Ready for QA

#12 Updated by kytv 2015-12-01 04:01:43

  • Parent task set to Feature #8547
  • Feature Branch changed from kytv/test/10430-disable-all-networking to kytv/test/10340-disable-all-networking

I renamed the branch to reference the correct ticket number, re-pushed, and added the parent task.

#13 Updated by intrigeri 2015-12-05 13:53:24

  • Assignee changed from anonym to kytv
  • QA Check changed from Ready for QA to Dev Needed

Hi! Sorry for the burden, but at this point can you please merge feature/jessie into your branch, and make sure the new tests pass on a Jessie ISO?

#14 Updated by kytv 2015-12-06 06:32:50

  • Assignee changed from kytv to anonym
  • QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:
> Hi! Sorry for the burden, but at this point can you please merge feature/jessie into your branch, and make sure the new tests pass on a Jessie ISO?

Not a problem. :)

network-manager is at the running state when Disable all networking is enabled in Jessie. This is a change in behaviour from Wheezy but networking is really disabled, so this may not be a problem.

(Minimal) Changes pushed

#15 Updated by kytv 2015-12-16 13:39:02

  • Target version changed from Tails_1.8 to Tails_2.0

Bumping to 2.0, already made jessie compatible.

#16 Updated by anonym 2016-01-19 15:27:38

  • Assignee changed from anonym to intrigeri
  • Feature Branch changed from kytv/test/10340-disable-all-networking to test/10340-disable-all-networking

I feel responsible for this branch since I have let the review slide for so long. I’ve fixed it up. intrigeri, what do you think of my commits, in particular commit:a4fb817. Please merge if you are fine with them

#17 Updated by intrigeri 2016-01-21 16:01:51

  • % Done changed from 50 to 60

Code review passes, testing.

#18 Updated by intrigeri 2016-01-21 16:28:39

  • Status changed from In Progress to Fix committed
  • % Done changed from 60 to 100

Applied in changeset commit:8a01831b2da3dd7243f77a9a9e65b549f232e954.

#19 Updated by intrigeri 2016-01-21 16:36:42

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

#20 Updated by anonym 2016-01-27 13:31:46

  • Status changed from Fix committed to Resolved

#21 Updated by intrigeri 2020-04-15 06:01:50

  • Affected tool changed from Greeter to Welcome Screen