Feature #10278

Automatically test that services that we disable are not started

Added by anonym 2015-09-26 07:07:09 . Updated 2019-09-30 08:06:15 .

Status:
In Progress
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Start date:
2015-09-26
Due date:
% Done:

50%

Feature Branch:
spriver:feature/10277
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

I.e. verify Bug #8313

Subtasks

History

#1 Updated by anonym 2015-09-26 07:07:24

#2 Updated by anonym 2015-09-26 07:10:03

  • Target version set to Tails_2.0

#3 Updated by kytv 2015-09-26 07:29:24

  • Tracker changed from Bug to Feature

#4 Updated by intrigeri 2015-10-03 15:24:39

Same comment + question as on Feature #10279#note-3.

#5 Updated by anonym 2015-11-11 04:10:23

  • Target version deleted (Tails_2.0)

#6 Updated by anonym 2015-11-11 04:10:36

#7 Updated by intrigeri 2016-11-10 14:32:23

#8 Updated by spriver 2017-05-29 12:24:15

  • Assignee set to anonym
  • QA Check set to Ready for QA
  • Feature Branch set to spriver:feature/10277

#9 Updated by intrigeri 2017-06-28 15:15:02

  • Target version set to Tails_3.2

#10 Updated by anonym 2017-06-29 13:33:07

  • blocks Feature #13239: Core work 2017Q3: Test suite maintenance added

#11 Updated by anonym 2017-08-16 12:28:02

  • Status changed from Confirmed to In Progress
  • Assignee changed from anonym to spriver
  • % Done changed from 0 to 50
  • QA Check changed from Ready for QA to Dev Needed

Your test does exactly what is asked for in a clean way. Great! I was about to merge it but…

… I think we asked for too little. :) We also mask several units, and a masked unit is a type of disabled unit:

$ git grep -w mask config/chroot_local-hooks/52-update-rc.d
config/chroot_local-hooks/52-update-rc.d:systemctl mask systemd-networkd.service
config/chroot_local-hooks/52-update-rc.d:systemctl mask hwclock-save.service
config/chroot_local-hooks/52-update-rc.d:systemctl mask systemd-timesyncd.service
config/chroot_local-hooks/52-update-rc.d:systemctl mask apt-daily.timer
config/chroot_local-hooks/52-update-rc.d:systemctl mask pppd-dns.service


So I propose you also test that these units are masked. I suggest changing the step

Then /^the (\S+) systemd unit file is disabled$/ do |unit_name|


to

Then /^the (\S+) systemd unit file is (active|inactive) and (\S+)$/ do |unit_name, active_status, loaded_status|


and then use the stdout instead of return status of systemctl is-enabled and systemctl is-active.

Makes sense?

#12 Updated by intrigeri 2017-09-07 12:58:56

  • Target version changed from Tails_3.2 to Tails_3.3

#13 Updated by intrigeri 2017-09-24 09:46:28

  • blocked by deleted (Feature #13239: Core work 2017Q3: Test suite maintenance)

#14 Updated by anonym 2017-11-15 11:30:50

  • Target version changed from Tails_3.3 to Tails_3.5

#15 Updated by anonym 2018-01-23 19:52:34

  • Target version changed from Tails_3.5 to Tails_3.6

#16 Updated by bertagaz 2018-03-14 11:32:09

  • Target version changed from Tails_3.6 to Tails_3.7

#17 Updated by bertagaz 2018-05-10 11:09:15

  • Target version changed from Tails_3.7 to Tails_3.8

#18 Updated by intrigeri 2018-06-26 16:27:52

  • Target version changed from Tails_3.8 to Tails_3.9

#19 Updated by intrigeri 2018-09-05 16:26:52

  • Target version changed from Tails_3.9 to Tails_3.10.1

#20 Updated by intrigeri 2018-10-24 17:03:36

  • Target version changed from Tails_3.10.1 to Tails_3.11

#21 Updated by CyrilBrulebois 2018-12-16 13:53:25

  • Target version changed from Tails_3.11 to Tails_3.12

#22 Updated by intrigeri 2019-01-27 10:48:17

  • Target version deleted (Tails_3.12)

#23 Updated by intrigeri 2019-09-30 08:06:15

  • Assignee deleted (spriver)

(I’ve discussed this with spriver out-of-band. Conclusion: anyone should feel free to take this ticket if they’d like to.)