Feature #9915

Review CSS and HTML by expert

Added by tchou 2015-08-06 02:13:46 . Updated 2016-11-04 13:21:24 .

Status:
Rejected
Priority:
Normal
Assignee:
naar
Category:
Installation
Target version:
Start date:
2015-08-06
Due date:
% Done:

0%

Feature Branch:
Type of work:
Website
Blueprint:

Starter:
Affected tool:
Installation Assistant
Deliverable for:

Description

Once we are on polishing the css and html, review the code by an expert (probably u).

Files

0001-Why-shouldn-t-this-be-consistent-with-the-rest-of-th.patch (1042 B) sajolida, 2015-12-11 07:19:57

Subtasks

History

#1 Updated by sajolida 2015-08-06 10:24:20

Maybe that could be a subtask of Feature #9310 directly?

#2 Updated by tchou 2015-08-06 14:59:39

Maybe, but maybe it will be probably latter, or before.
I feel that it will be when I will feel that it’s time for that, and it can be early or late. I think it gonna be late, even if it will lead to deep modifications.

#3 Updated by sajolida 2015-08-07 07:27:45

  • Status changed from New to Confirmed
  • Assignee set to tchou

Ok!

#4 Updated by sajolida 2015-08-14 11:02:23

The notes from the summit say “late 2015 :u: review the CSS and HTML from the Installation Assistant made by :tchou:”.

#5 Updated by intrigeri 2015-08-18 05:08:56

  • Assignee deleted (tchou)

Setting assignee accordingly.

#6 Updated by Anonymous 2015-08-24 07:05:41

Hi @tchou. can you ping me when you feel it’s ready and tell me where i can find the code?

Thanks!

#7 Updated by BitingBird 2015-08-25 14:20:24

  • Category set to Installation
  • Affected tool set to Installation Assistant

#8 Updated by Anonymous 2015-09-25 13:21:27

  • Assignee set to tchou

reassignung to you until ready.

#9 Updated by sajolida 2015-11-23 09:02:41

  • Target version set to 246

#10 Updated by sajolida 2015-11-24 02:51:04

#11 Updated by sajolida 2015-11-27 04:43:41

  • Target version changed from 246 to Tails_2.0

#12 Updated by sajolida 2015-12-11 07:19:59

See patch in attachment.

#13 Updated by tchou 2016-01-04 10:02:44

  • Assignee changed from tchou to sajolida
  • QA Check set to Info Needed

I can’t read the patch : “The page you were trying to access doesn’t exist or has been removed.”

#14 Updated by tchou 2016-01-04 10:11:23

  • Assignee deleted (sajolida)

Hey u, the code should me more or less ready in 10 days.
Do you know if you have some time left, and how many time do you need ?

#15 Updated by Anonymous 2016-01-06 11:25:42

  • Assignee set to tchou

Where can I see this? Do you want me to simply review it and report back or should I make modifications if necessary? Is there anything in particular you want me to focus on when reviewing?

With this info i can give you a time estimate.

#16 Updated by tchou 2016-01-08 13:38:57

  • Assignee deleted (tchou)

> Where can I see this?
The code is currently online in http://tails.boum.org/install, but there is still some work in progress. I will say you wich file are concerned.

> Do you want me to simply review it and report back or should I make modifications
if necessary? Is there anything in particular you want me to focus on when reviewing?

The code will be fonctionnal (at least on ff, tbb and chrome), but maybe maybe you could have some hints on refacto, css class naming… I don’t expect modifications (except if you want to) but comments.

> With this info i can give you a time estimate.

#17 Updated by intrigeri 2016-01-08 15:18:20

  • Assignee set to tchou

> I will say you wich file are concerned.

(Tweaking ticket metadata accordingly.)

#18 Updated by tchou 2016-01-13 13:18:01

  • Assignee changed from tchou to naar

I think we will have i11y issues too.
Naar could you have a look ? (in a few weeks, the code is not ready).

#19 Updated by sajolida 2016-01-22 19:19:38

Definitely not blocking the release.

#20 Updated by sajolida 2016-01-29 18:19:58

  • Target version changed from Tails_2.0 to Tails_2.2

#21 Updated by sajolida 2016-03-15 15:03:51

  • Target version deleted (Tails_2.2)

#22 Updated by sajolida 2016-11-04 13:21:24

  • Status changed from Confirmed to Rejected

I don’t think that this is really needed.