Feature #9877

Unused @gksu@ step in test suite

Added by kytv 2015-08-02 03:13:07 . Updated 2015-09-22 15:04:31 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Start date:
2015-08-02
Due date:
% Done:

100%

Feature Branch:
kytv:test/9877-remove-unused-step
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

While investigating Feature #5330 I found this step which doesn’t appear to be used anymore.

diff --git a/features/step_definitions/common_steps.rb b/features/step_definitions/common_steps.rb
index 08f66e2..fad9cd3 100644
--- a/features/step_definitions/common_steps.rb
+++ b/features/step_definitions/common_steps.rb
@@ -454,15 +454,6 @@ Then /^all Internet traffic has only flowed through Tor$/ do
   leaks.assert_no_leaks
 end

-Given /^I enter the sudo password in the gksu prompt$/ do
-  next if @skip_steps_while_restoring_background
-  @screen.wait('GksuAuthPrompt.png', 60)
-  sleep 1 # wait for weird fade-in to unblock the "Ok" button
-  @screen.type(@sudo_password)
-  @screen.type(Sikuli::Key.ENTER)
-  @screen.waitVanish('GksuAuthPrompt.png', 10)
-end
-
 Given /^I enter the sudo password in the pkexec prompt$/ do
   next if @skip_steps_while_restoring_background
   step "I enter the \"#{@sudo_password}\" password in the pkexec prompt"

Perhaps it should be removed.


Subtasks


History

#1 Updated by kytv 2015-08-02 03:14:51

Note: Added as a subtask of Feature #5330 due to this comment in that ticket’s description:

> Just run git grep sleep features/step_definitions/*.rb for an up-to-date list of these “violations”.

…which showed this gksu step.

#2 Updated by kytv 2015-08-04 05:27:17

  • Status changed from New to In Progress
  • Assignee changed from kytv to intrigeri
  • QA Check set to Ready for QA
  • Feature Branch set to kytv:test/9877-remove-unused-step

With this commit there’s one less result for the command git grep sleep features/step_definitions/*.rb specified in Feature #5330.

#3 Updated by intrigeri 2015-08-04 08:10:34

  • Assignee changed from intrigeri to anonym
  • Target version changed from Tails_1.5 to Tails_1.6

#4 Updated by kytv 2015-09-02 10:10:07

Applied in changeset commit:8f3de945e6c74ace6fae9809f9c66bc3ebe58e5d.

#5 Updated by anonym 2015-09-02 10:10:08

  • Status changed from In Progress to Fix committed
  • % Done changed from 0 to 100

Applied in changeset commit:0182f3026469f330747afc4e2c19da737263d38c.

#6 Updated by anonym 2015-09-02 10:10:29

  • Assignee deleted (anonym)
  • QA Check changed from Ready for QA to Pass

#7 Updated by bertagaz 2015-09-22 15:04:31

  • Status changed from Fix committed to Resolved
  • QA Check deleted (Pass)