Bug #9795
execute_successfully reports errors via stdout
100%
Description
It just puts the error instead of including it the exception it raises. Not only is this not standard, it also makes the errors seep through e.g. try_for iterations when the exception is caught and the error should be completely ignored.
Subtasks
History
#1 Updated by anonym 2015-07-23 09:19:58
- Status changed from Confirmed to In Progress
Applied in changeset commit:e44082b755d954e51ba125a41dcf2454130f6856.
#2 Updated by anonym 2015-07-23 09:21:00
- Assignee changed from anonym to kytv
- % Done changed from 0 to 50
- QA Check set to Ready for QA
- Feature Branch set to test/9795-proper-execute_successfully-exceptions
#3 Updated by kytv 2015-07-23 11:00:05
- Assignee changed from kytv to anonym
- QA Check changed from Ready for QA to Pass
Perfect.
The code looks good and it does what it should.
(Thank you, now I know the proper way to do this)
#4 Updated by anonym 2015-08-03 17:00:20
- Assignee changed from anonym to intrigeri
- QA Check changed from Pass to Ready for QA
> QA Check changed from Ready for QA to Pass
Have we changed anything in our process, or was this a mistake?
#5 Updated by intrigeri 2015-08-04 02:05:49
> Have we changed anything in our process, or was this a mistake?
We’ve done this quite a few times recently: I’m been merging almost blindly (just quickly looking at the diff, not running the tests) your stuff once kytv is happy with it.
#6 Updated by intrigeri 2015-08-04 02:07:18
- Status changed from In Progress to Fix committed
- % Done changed from 50 to 100
Applied in changeset commit:66a7c1415ff58016f7c2d9a5e4a2bba641831555.
#7 Updated by intrigeri 2015-08-04 02:08:48
- Assignee deleted (
intrigeri) - QA Check changed from Ready for QA to Pass
Merged! Note that this branch wasn’t merged into experimental; may you please try to do that more consistently in the future? (I often forget too.)
#8 Updated by BitingBird 2015-08-11 10:46:41
- Status changed from Fix committed to Resolved