Bug #9715

Retry wget in the test suite when failing to resolve a host

Added by kytv 2015-07-09 06:29:55 . Updated 2015-08-11 10:48:17 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Test suite
Target version:
Start date:
2015-07-09
Due date:
% Done:

100%

Feature Branch:
kytv:test/9715-wget
Type of work:
Code
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

An example when it fails:

spawn returned: [0, "", ""]
    And I save the state so the background can be restored next scenario # features/step_definitions/common_steps.rb:418
calling as amnesia: wget -O - 'http://example.com/'
call returned: [4, "", "--2015-07-09 13:24:20--  http://example.com/\nResolving example.com (example.com)... [Jul 09 13:24:21] ERROR torsocks[5911]: Unable to resolve. Status reply: 4 (in socks5_recv_resolve_reply() at socks5.c:657)\nfailed: Non-recoverable failure in name resolution.\nwget: unable to resolve host address `example.com'\n"]
Command failed: wget -O - 'http://example.com/'
error code: 4
stderr: --2015-07-09 13:24:20--  http://example.com/
Resolving example.com (example.com)... [Jul 09 13:24:21] ERROR torsocks[5911]: Unable to resolve. Status reply: 4 (in socks5_recv_resolve_reply() at socks5.c:657)
failed: Non-recoverable failure in name resolution.
wget: unable to resolve host address `example.com'
.
<false> is not true.

  Scenario: wget(1) should work for HTTP and go through Tor. # features/torified_misc.feature:15
    When I successfully wget "http://example.com/" to stdout # features/step_definitions/torified_misc.rb:32
      ExecutionFailedInVM (ExecutionFailedInVM)
      ./features/support/helpers/vm_helper.rb:382:in `rescue in execute_successfully'
      ./features/support/helpers/vm_helper.rb:378:in `execute_successfully'
      ./features/step_definitions/torified_misc.rb:36:in `/^I successfully wget "([^"]+)" to stdout(?:| with the '([^']+)' options)$/'
      features/torified_misc.feature:16:in `When I successfully wget "http://example.com/" to stdout'
    And the wget standard output contains "Example Domain"   # features/step_definitions/torified_misc.rb

Subtasks


History

#1 Updated by kytv 2015-07-09 06:30:17

  • related to Feature #9515: Improve test suite robustness vs transient network errors added

#2 Updated by kytv 2015-07-09 06:31:12

  • related to deleted (Feature #9515: Improve test suite robustness vs transient network errors)

#3 Updated by kytv 2015-07-09 06:31:34

#4 Updated by kytv 2015-07-13 09:02:00

  • Status changed from Confirmed to In Progress
  • Assignee changed from kytv to intrigeri
  • % Done changed from 0 to 30
  • QA Check set to Ready for QA
  • Feature Branch set to kytv:test/9715-wget

Rebased against devel. Pretty much Feature #9668 but for wget.

#5 Updated by intrigeri 2015-07-16 03:11:35

  • blocks #8538 added

#6 Updated by kytv 2015-07-16 03:40:24

Applied in changeset commit:4c3a3564799aa6b118e7981c7164656991f0040f.

#7 Updated by intrigeri 2015-07-16 03:40:24

  • Status changed from In Progress to Fix committed
  • % Done changed from 30 to 100

Applied in changeset commit:5be4ca90036865f7fc3040c02dda558fb2779557.

#8 Updated by intrigeri 2015-07-16 03:41:01

  • Assignee deleted (intrigeri)
  • QA Check changed from Ready for QA to Pass

Yay, merged!

#9 Updated by BitingBird 2015-08-11 10:48:17

  • Status changed from Fix committed to Resolved