Tails

#1 Updated by kytv 2015-07-09 03:54:33

• Status changed from Confirmed to In Progress
• QA Check set to Ready for QA
• Feature Branch set to kytv:test/9709-log-to-file

This branch fixes the problem for me.

Again, apologies for not noticing xvfb not getting cleaned up when the log file was set. :|

#2 Updated by intrigeri 2015-07-09 09:07:05

• Assignee changed from intrigeri to kytv
• % Done changed from 0 to 50
• QA Check changed from Ready for QA to Dev Needed

kytv wrote:
> This branch fixes the problem for me.

Thanks for stealing my work :) And indeed, using a helper function is the way to go IMO.

Now, test_suite_cleanup() has a problem: we’re under set -e, so if xvfb was killed already for some reason, then the program will exit without removing control chars from the log file. I suggest adding a || true, or something.

#3 Updated by kytv 2015-07-09 13:55:24

• Assignee changed from kytv to intrigeri
• QA Check changed from Dev Needed to Ready for QA

intrigeri wrote:

> Now, test_suite_cleanup() has a problem: we’re under set -e, so if xvfb was killed already for some reason, then the program will exit without removing control chars from the log file. I suggest adding a || true, or something.

Ah, good catch WRT set -e.

Changes pushed.

#5 Updated by intrigeri 2015-07-09 23:13:08

• Status changed from In Progress to Fix committed
• % Done changed from 50 to 100

Applied in changeset commit:7880ec2abc3cf2af0934a862d1c9a7f4c4da7f93.

#6 Updated by intrigeri 2015-07-09 23:14:06

• Assignee deleted (intrigeri)
• QA Check changed from Ready for QA to Pass

#7 Updated by BitingBird 2015-08-11 10:48:11

• Status changed from Fix committed to Resolved