Feature #9684

Upstream our changes to the puppet-archive module

Added by bertagaz 2015-07-04 11:26:09 . Updated 2015-08-26 06:11:03 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Continuous Integration
Target version:
Start date:
2015-07-04
Due date:
% Done:

100%

Feature Branch:
puppet-jenkins:features/9618-stronger_plugin_verification
Type of work:
Sysadmin
Blueprint:

Starter:
0
Affected tool:
Deliverable for:
266

Description

In order to have our feature/stronger_plugin_verification branch of the puppet-Jenkins module proposed upstream, we first need to upstream our features/file_owner_and_mode_support branch of the puppet-archive module that it depends on.

A similar patch has already been proposed to the upstream

Once merged, we’ll have to update our puppet-archive module to the latest upstream and then adapt our puppet-jenkins branch if needed.


Subtasks


Related issues

Has duplicate Tails - Feature #9619: Upstream our changes to the puppet-archive module. Duplicate

History

#1 Updated by bertagaz 2015-07-04 11:26:22

#2 Updated by bertagaz 2015-07-04 11:26:58

This ticket is replacing the unusable Feature #9619 ticket.

#3 Updated by intrigeri 2015-07-04 11:45:48

> This ticket is replacing the unusable Feature #9619 ticket.

… but Feature #9619 is still open.

#4 Updated by bertagaz 2015-07-06 02:52:08

Same answer as for Feature #9683 :)

#5 Updated by bertagaz 2015-07-07 04:06:32

  • Assignee changed from bertagaz to intrigeri
  • QA Check set to Ready for QA
  • Feature Branch set to puppet-jenkins:features/9618-stronger_plugin_verification

I’ve updated our puppet-archive module to the latest 0.8.0 tag which contains the $user parameter support.

I’ve adapted the related puppet-jenkins branch to use this new puppet-archive module.

I’ve installed several Jenkins plugins since then and it works fine. I think this branch is ready to ask for a merge upstream.

Beware that I had to rewrite our puppet-jenkins module history quite a bit since last week, as well as the Lizard manifest. The live deployment was not that easy in the end.

#6 Updated by bertagaz 2015-07-07 04:08:36

  • % Done changed from 0 to 50

#7 Updated by intrigeri 2015-07-07 06:36:51

  • blocks #8668 added

#8 Updated by intrigeri 2015-07-07 06:37:22

  • has duplicate Feature #9619: Upstream our changes to the puppet-archive module. added

#9 Updated by intrigeri 2015-07-07 06:40:23

  • Assignee changed from intrigeri to bertagaz

> I’ve updated our puppet-archive module to the latest 0.8.0 tag which contains the $user parameter support.
> I’ve adapted the related puppet-jenkins branch to use this new puppet-archive module.
> I’ve installed several Jenkins plugins since then and it works fine.

Yay! So this ticket can be closed since we don’t need any change upstream in the archive module anymore, right? If my understanding is correct, then just mark it as resolved :)

> I think this branch is ready to ask for a merge upstream.

Cool. Assuming “this branch” is puppet-jenkins:features/9618-stronger_plugin_verification, then that should be tracked in another subtask of Bug #9682, since it’s not about upstreaming changes to the archive plugin, right?

#10 Updated by bertagaz 2015-07-07 07:02:38

  • Status changed from In Progress to Resolved
  • Assignee deleted (bertagaz)
  • % Done changed from 50 to 100
  • QA Check deleted (Ready for QA)

intrigeri wrote:
> > I’ve updated our puppet-archive module to the latest 0.8.0 tag which contains the $user parameter support.
> > I’ve adapted the related puppet-jenkins branch to use this new puppet-archive module.
> > I’ve installed several Jenkins plugins since then and it works fine.
>
> Yay! So this ticket can be closed since we don’t need any change upstream in the archive module anymore, right? If my understanding is correct, then just mark it as resolved :)

Done.

> > I think this branch is ready to ask for a merge upstream.
>
> Cool. Assuming “this branch” is puppet-jenkins:features/9618-stronger_plugin_verification, then that should be tracked in another subtask of Bug #9682, since it’s not about upstreaming changes to the archive plugin, right?

Yes, but to be honest I thought this task/branch could as well be tracked with Bug #9682 itself. Or would that be too messy for you?

#11 Updated by intrigeri 2015-07-07 07:41:29

>> > I think this branch is ready to ask for a merge upstream.
>>
>> Cool. Assuming “this branch” is
>> puppet-jenkins:features/9618-stronger_plugin_verification, then that should be
>> tracked in another subtask of Bug #9682, since it’s not about upstreaming changes to
>> the archive plugin, right?

> Yes, but to be honest I thought this task/branch could as well be tracked with Bug #9682 itself. Or would that be too messy for you?

Works for me, as long as it’s clear on Bug #9682 what’s the next thing to do :)

#12 Updated by intrigeri 2015-07-09 01:48:59

  • Subject changed from Upstream our changes to the puppet-archive module. to Upstream our changes to the puppet-archive module

#13 Updated by intrigeri 2015-08-26 06:11:04

  • Deliverable for set to 266