Tails

#2 Updated by intrigeri 2015-06-18 07:11:05

• Tracker changed from Bug to Feature
• Subject changed from tails-installer needs to use syslinux-amd64 on amd64 platforms to Have Tails Installer use syslinux-amd64 on amd64 platforms
• Category set to Installation
• Status changed from New to Confirmed

#3 Updated by intrigeri 2015-06-18 07:11:37

• blocks #8538 added

#4 Updated by Anonymous 2015-06-22 05:13:39

• Status changed from Confirmed to In Progress
• Assignee set to intrigeri
• % Done changed from 0 to 20
• QA Check set to Ready for QA
• Feature Branch set to 451f:liveusb-creator/feature/jessie_syslinux64

please review, thanks.

#5 Updated by intrigeri 2015-06-29 02:58:46

• Assignee deleted (intrigeri)
• Target version changed from Tails_1.4.1 to Tails_1.5
• QA Check changed from Ready for QA to Dev Needed

OK, looks good. Here are some comments:

• Please configure your Git to prevent you from introducing trailing whitespace (the proposed branch does). Then, remove the newly introduced whitespace.
• I have some doubts wrt. the processor_arch bits: what we need to know is the architecture being used by the OS userspace that’s running, not the CPU’s architecture (e.g. one can very well run a 32-bit OS on a 64-bit CPU, and then syslinux-amd64 won’t work); if the current implementation does the right thing (looking at the OS’ arch and not the CPU’s one) then this function seems wrongly named. And if the implementation doesn’t do the right thing, then it needs to be fixed. Sorry that the specification on this ticket was not very clear.
• Please rebase this branch on top of feature/jessie: it has a couple commits that have nothing to do on this branch AFAICT.

#6 Updated by Anonymous 2015-06-30 02:43:14

• Feature Branch changed from 451f:liveusb-creator/feature/jessie_syslinux64 to 451f:liveusb-creator/feature/jessie_syslinux64_2

Thanks for the precision! I’ve found an easier way to implement this now, rebased my changes upon feature/jessie and double checked for trailing whitespace.

#7 Updated by Anonymous 2015-06-30 02:50:36

• Assignee set to intrigeri
• % Done changed from 20 to 30
• QA Check changed from Dev Needed to Ready for QA

I’ve tested it now on a Debian Jessie 64bit system.

#8 Updated by intrigeri 2015-07-01 11:18:05

• Assignee deleted (intrigeri)
• % Done changed from 30 to 60
• QA Check changed from Ready for QA to Dev Needed

platform_architecture() doesn’t seem to exist => are you sure you tested the exact code you submitted for review? Perhaps you meant platform.architecture() instead?

By the way, I’ve tested in a 32-bit chroot (with a 64-bit kernel, and 64-bit CPU) that platform.architecture() indeed returns “32bit” there => once the above issue is fixed, I’m happy to merge this into feature/jessie :)

#9 Updated by Anonymous 2015-07-03 03:02:09

• Assignee set to intrigeri
• QA Check changed from Dev Needed to Ready for QA

Correct. I’ve updated the branch and retested the code.

#10 Updated by intrigeri 2015-07-03 04:26:37

• Status changed from In Progress to Resolved
• Assignee deleted (intrigeri)
• % Done changed from 60 to 100
• QA Check changed from Ready for QA to Pass

Merged into feature/jessie :) I’ll wait for a few more changes to pile up before I build an updated package, but if you need one, tell me.

#11 Updated by Anonymous 2015-07-04 05:49:10

• Status changed from Resolved to In Progress
• Assignee set to intrigeri
• % Done changed from 100 to 90
• QA Check changed from Pass to Ready for QA

I’ve pushed some changes to this branch which should now work much better.

#12 Updated by intrigeri 2015-07-04 07:11:03

• Status changed from In Progress to Resolved
• Assignee deleted (intrigeri)
• % Done changed from 90 to 100
• QA Check changed from Ready for QA to Pass

Merged, thanks!