Tails

#2 Updated by BitingBird 2015-05-13 22:17:03

• Status changed from New to Confirmed

#4 Updated by BitingBird 2015-05-25 23:13:14

• Assignee set to BitingBird
• Target version set to Tails_1.4.1
• QA Check set to Ready for QA

#5 Updated by BitingBird 2015-05-25 23:14:05

• Status changed from Confirmed to In Progress

#6 Updated by BitingBird 2015-05-28 20:23:23

• Assignee changed from BitingBird to muri
• QA Check changed from Ready for QA to Dev Needed

You’re added to the contributors on the Redmine now, you’ll be able to assign tickets to yourself :)

I really like your patch, you found some really good links. But I think you should remove the link to freenode and say instead that their .onion is down, because it’s the server that’s the most asked, and as-is, your note leads users to believe that it should work.

Also, the part “and most IRC software doesn’t provide another way to block than blocking them by IP address” is grammatically strange. Maybe end the sentence after “spambots”, and make another sentence for it?

Thanks for working on the doc!

#8 Updated by BitingBird 2015-05-30 19:26:32

• Assignee changed from muri to BitingBird
• QA Check changed from Dev Needed to Ready for QA

#9 Updated by BitingBird 2015-06-12 09:18:55

• Assignee changed from BitingBird to sajolida
• % Done changed from 0 to 50
• QA Check changed from Ready for QA to Pass

Looks good, review passes -> please merge :)

#10 Updated by sajolida 2015-06-24 08:48:29

• Target version deleted (Tails_1.4.1)

Tails 1.4.1 is getting closer and I still have other reviews in the queue, so I’m removing the target version for this one.

#11 Updated by sajolida 2015-07-07 01:06:50

• Assignee changed from sajolida to muri
• QA Check changed from Pass to Dev Needed

Hi muri, thanks for working on this and sorry for the late review.

I think that your patch addresses well the issue, contains the relevant information, and is integrated correctly in the documentation.

Still, I’ll do my usual formatting and nitpicking comments. Feel free to apply yourself the parts you find relevant and then I might do some other minor adjustements myself before merging:

• In use as simpler words as possible. In your patch the only problematic word for me is “spambots”. Our users probably know “spam” or “spammer” already but maybe not “spambots”. It’s probably OK to say “because of spam” or “because of spammers”.
• Use terminology consistently. It’s better to use as few different terms as possible when refering to things that are the same for the user. In this case, your text would be simplier mentioning only “IRC servers” without distinguishing “IRC networks” (which would be a set of IRC servers) and “IRC software” (which would be the software running on IRC servers). Even if your version might be slightly more correct technically speaking, having three different terms might make it more difficult to understand the subtle differences between them.
• Use typography consistently, spell acronyms in full-caps: “IRC” (and not “irc”).
• Beware of indefinite pronouns like “it”, “them”, and so on which are very often ambiguous, in your patch “blocking them” is quite far away from “spambots” and maybe it’s better to repeat “spam” or “spammer” instead of “them”.
• Limit the number of words to the minimum. When writing documentation it usually take 2 or 3 rewrites to get to the final phrasing which should be as short and clear as possible. On each rewrite it’s usually possible to get rid of 20-30% of words. Here are some examples on your patch:
  • “most IRC software doesn’t provide another way to block than blocking them by IP address” could become “most IRC servers blocks spam by IP address” (–53%). Also note here that you are missing an explanation on why Tor IP addresses are blocked. You should also explain that spammers use Tor.
  • “Some irc servers have a webpage where they explain what their policy is” could become “Some IRC servers explain their policy regarding Tor” (–61%). Note that it’s also recommended to introduce bullet lists explicitely, here maybe with “For example:”

If you want to learn more about doc writing, I highly recommend reading the GNOME Documentation Style Guide: https://developer.gnome.org/gdp-style-guide/2.32/gdp-style-guide.html.

#12 Updated by sajolida 2015-07-07 07:11:22

• Feature Branch set to doc/9398-irc-blocking-tor

#15 Updated by BitingBird 2015-08-11 06:20:06

• Target version set to Tails_1.6

This should be really great to have live at some point -> assigning for next release.

muri, if you’re giving up on this, please assign me instead - I’ll bring it to the end.

Cheers,

#16 Updated by muri 2015-08-13 10:21:59

• Assignee changed from muri to BitingBird

sorry, too little time atm, to much other stuff going on, assigning to bitingbird. thanks for taking over

#18 Updated by sajolida 2015-09-04 10:51:00

• Assignee changed from BitingBird to sajolida
• QA Check changed from Dev Needed to Ready for QA

BitingBird can do reviews, but she can’t merge. I’m not sure she’ll be available to review this these days, so I’ll take it over.

Marking this as “Ready for QA”, then.

#19 Updated by sajolida 2015-09-16 06:51:07

• Assignee changed from sajolida to muri

Thanks for following up on this. We’re almost there now! I pushed a bunch of more simplications with edc29c3..d140878, can you have a look? Especially 619f7d3: I felt that this sentence was not bring much as it was. If you’re fine with this I’ll merge.

#20 Updated by muri 2015-09-16 07:52:32

• Assignee changed from muri to sajolida

hi,
you’re right about 619f7d3, the sentence was unnecessary. i reviewed all the changes and i’m fine with all of them. thanks for taking the time to finalize!

#21 Updated by sajolida 2015-09-17 04:40:41

• Status changed from In Progress to Resolved
• % Done changed from 50 to 100

Applied in changeset commit:18017559c22ce2734edc0efb7f4bfa1615a46f10.

#22 Updated by sajolida 2015-09-17 04:41:10

• Assignee deleted (sajolida)
• QA Check deleted (Ready for QA)