Bug #9390

"merge policy" could link to doc about how to do a good review

Added by BitingBird 2015-05-12 23:42:59 . Updated 2015-06-09 07:08:14 .

Status:
Resolved
Priority:
Normal
Assignee:
Category:
Target version:
Tails_1.4.1
Start date:
2015-05-12
Due date:
% Done:

100%

Feature Branch:
bitingbird:contrib/9390-reviews
Type of work:
Contributors documentation
Blueprint:

Starter:
Affected tool:
Deliverable for:

Description

https://tails.boum.org/contribute/merge_policy/#index4h2 could have a link to https://www.kateheddleston.com/blog/criticism-and-ineffective-feedback (a blog post that explains how to do good reviews) or http://www.cowgirlcoder.com/articles/wintech1297.htm

Subtasks

History

#1 Updated by BitingBird 2015-05-13 16:18:59

  • Status changed from New to Confirmed
  • Assignee set to BitingBird
  • Target version set to Tails_1.4.1

sajolida confirms that it’s a good idea -> I’ll do it

#2 Updated by BitingBird 2015-05-20 12:31:59

  • Status changed from Confirmed to In Progress
  • Assignee changed from BitingBird to sajolida
  • % Done changed from 0 to 30
  • QA Check set to Ready for QA
  • Feature Branch set to bitingbird:contrib/9390-reviews

Added a few lines and the link in contrib/Git merge policy#review

Please review :)

#3 Updated by sajolida 2015-06-08 17:07:57

  • Status changed from In Progress to Resolved
  • % Done changed from 30 to 100

Applied in changeset commit:d39386eb8e6e1f4ee2f2c999bfb87dfe55a98186.

#4 Updated by sajolida 2015-06-08 17:08:51

  • Status changed from Resolved to In Progress
  • % Done changed from 100 to 30

Cool! I merged this one as such :)

#5 Updated by BitingBird 2015-06-08 17:48:53

  • Status changed from In Progress to Resolved
  • Assignee deleted (sajolida)
  • QA Check changed from Ready for QA to Pass

#6 Updated by intrigeri 2015-06-09 07:08:14

  • % Done changed from 30 to 100